* [Qemu-devel] [PATCH 0/2] hw/display: Compile various display devices as common object
@ 2019-08-12 11:37 Philippe Mathieu-Daudé
2019-08-12 11:37 ` [Qemu-devel] [PATCH 1/2] hw/display/sm501: Remove unused include Philippe Mathieu-Daudé
` (2 more replies)
0 siblings, 3 replies; 11+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-08-12 11:37 UTC (permalink / raw)
To: qemu-devel
Cc: Thomas Huth, Markus Armbruster, qemu-ppc, Gerd Hoffmann,
Philippe Mathieu-Daudé
This series move various generic display devices to $(common-obj-y),
so they are compiled once for all targets.
'make world' is reduced by 54 objects.
Philippe Mathieu-Daudé (2):
hw/display/sm501: Remove unused include
hw/display: Compile various display devices as common object
hw/display/Makefile.objs | 18 +++++++++---------
hw/display/sm501.c | 1 -
2 files changed, 9 insertions(+), 10 deletions(-)
--
2.20.1
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Qemu-devel] [PATCH 1/2] hw/display/sm501: Remove unused include
2019-08-12 11:37 [Qemu-devel] [PATCH 0/2] hw/display: Compile various display devices as common object Philippe Mathieu-Daudé
@ 2019-08-12 11:37 ` Philippe Mathieu-Daudé
2019-08-12 11:47 ` Thomas Huth
2019-08-21 9:07 ` Laurent Vivier
2019-08-12 11:37 ` [Qemu-devel] [PATCH 2/2] hw/display: Compile various display devices as common object Philippe Mathieu-Daudé
2019-08-12 11:56 ` [Qemu-devel] [PATCH 0/2] " BALATON Zoltan
2 siblings, 2 replies; 11+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-08-12 11:37 UTC (permalink / raw)
To: qemu-devel
Cc: Thomas Huth, Markus Armbruster, qemu-ppc, Gerd Hoffmann,
Philippe Mathieu-Daudé
The "cpu.h" include makes devices target-specific. Since it
is not used, remove it, so the device become generic (we can
now compile it once for all targets).
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
hw/display/sm501.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/display/sm501.c b/hw/display/sm501.c
index 5918f59b2b..b15fb1ab00 100644
--- a/hw/display/sm501.c
+++ b/hw/display/sm501.c
@@ -28,7 +28,6 @@
#include "qapi/error.h"
#include "qemu/log.h"
#include "qemu/module.h"
-#include "cpu.h"
#include "hw/hw.h"
#include "hw/char/serial.h"
#include "ui/console.h"
--
2.20.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [Qemu-devel] [PATCH 1/2] hw/display/sm501: Remove unused include
2019-08-12 11:37 ` [Qemu-devel] [PATCH 1/2] hw/display/sm501: Remove unused include Philippe Mathieu-Daudé
@ 2019-08-12 11:47 ` Thomas Huth
2019-08-21 9:07 ` Laurent Vivier
1 sibling, 0 replies; 11+ messages in thread
From: Thomas Huth @ 2019-08-12 11:47 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: qemu-trivial, Gerd Hoffmann, qemu-ppc, Markus Armbruster
On 8/12/19 1:37 PM, Philippe Mathieu-Daudé wrote:
> The "cpu.h" include makes devices target-specific. Since it
> is not used, remove it, so the device become generic (we can
> now compile it once for all targets).
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/display/sm501.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/display/sm501.c b/hw/display/sm501.c
> index 5918f59b2b..b15fb1ab00 100644
> --- a/hw/display/sm501.c
> +++ b/hw/display/sm501.c
> @@ -28,7 +28,6 @@
> #include "qapi/error.h"
> #include "qemu/log.h"
> #include "qemu/module.h"
> -#include "cpu.h"
> #include "hw/hw.h"
> #include "hw/char/serial.h"
> #include "ui/console.h"
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Qemu-devel] [PATCH 1/2] hw/display/sm501: Remove unused include
2019-08-12 11:37 ` [Qemu-devel] [PATCH 1/2] hw/display/sm501: Remove unused include Philippe Mathieu-Daudé
2019-08-12 11:47 ` Thomas Huth
@ 2019-08-21 9:07 ` Laurent Vivier
1 sibling, 0 replies; 11+ messages in thread
From: Laurent Vivier @ 2019-08-21 9:07 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: Thomas Huth, qemu-ppc, Markus Armbruster, Gerd Hoffmann
Le 12/08/2019 à 13:37, Philippe Mathieu-Daudé a écrit :
> The "cpu.h" include makes devices target-specific. Since it
> is not used, remove it, so the device become generic (we can
> now compile it once for all targets).
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/display/sm501.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/display/sm501.c b/hw/display/sm501.c
> index 5918f59b2b..b15fb1ab00 100644
> --- a/hw/display/sm501.c
> +++ b/hw/display/sm501.c
> @@ -28,7 +28,6 @@
> #include "qapi/error.h"
> #include "qemu/log.h"
> #include "qemu/module.h"
> -#include "cpu.h"
> #include "hw/hw.h"
> #include "hw/char/serial.h"
> #include "ui/console.h"
>
Applied to my trivial-patches branch.
[fixed a conflict with with 650d103d3ea9 ("Include hw/hw.h exactly
where needed")]
Thanks,
Laurent
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Qemu-devel] [PATCH 2/2] hw/display: Compile various display devices as common object
2019-08-12 11:37 [Qemu-devel] [PATCH 0/2] hw/display: Compile various display devices as common object Philippe Mathieu-Daudé
2019-08-12 11:37 ` [Qemu-devel] [PATCH 1/2] hw/display/sm501: Remove unused include Philippe Mathieu-Daudé
@ 2019-08-12 11:37 ` Philippe Mathieu-Daudé
2019-08-12 11:51 ` Thomas Huth
2019-08-21 9:00 ` Gerd Hoffmann
2019-08-12 11:56 ` [Qemu-devel] [PATCH 0/2] " BALATON Zoltan
2 siblings, 2 replies; 11+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-08-12 11:37 UTC (permalink / raw)
To: qemu-devel
Cc: Thomas Huth, Markus Armbruster, qemu-ppc, Gerd Hoffmann,
Philippe Mathieu-Daudé
Various display devices are not target-specific and can
be compiled once for all the targets.
After this commit, the 'make world' target is reduced by
54 objects
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
hw/display/Makefile.objs | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/hw/display/Makefile.objs b/hw/display/Makefile.objs
index a64998fc7b..0f11d55b14 100644
--- a/hw/display/Makefile.objs
+++ b/hw/display/Makefile.objs
@@ -31,13 +31,13 @@ obj-$(CONFIG_MILKYMIST_TMU2) += milkymist-tmu2.o
milkymist-tmu2.o-cflags := $(X11_CFLAGS) $(OPENGL_CFLAGS)
milkymist-tmu2.o-libs := $(X11_LIBS) $(OPENGL_LIBS)
-obj-$(CONFIG_OMAP) += omap_dss.o
+common-obj-$(CONFIG_OMAP) += omap_dss.o
obj-$(CONFIG_OMAP) += omap_lcdc.o
-obj-$(CONFIG_PXA2XX) += pxa2xx_lcd.o
-obj-$(CONFIG_RASPI) += bcm2835_fb.o
-obj-$(CONFIG_SM501) += sm501.o
-obj-$(CONFIG_TCX) += tcx.o
-obj-$(CONFIG_CG3) += cg3.o
+common-obj-$(CONFIG_PXA2XX) += pxa2xx_lcd.o
+common-obj-$(CONFIG_RASPI) += bcm2835_fb.o
+common-obj-$(CONFIG_SM501) += sm501.o
+common-obj-$(CONFIG_TCX) += tcx.o
+common-obj-$(CONFIG_CG3) += cg3.o
obj-$(CONFIG_VGA) += vga.o
@@ -53,7 +53,7 @@ virtio-gpu.o-cflags := $(VIRGL_CFLAGS)
virtio-gpu.o-libs += $(VIRGL_LIBS)
virtio-gpu-3d.o-cflags := $(VIRGL_CFLAGS)
virtio-gpu-3d.o-libs += $(VIRGL_LIBS)
-obj-$(CONFIG_DPCD) += dpcd.o
-obj-$(CONFIG_XLNX_ZYNQMP_ARM) += xlnx_dp.o
+common-obj-$(CONFIG_DPCD) += dpcd.o
+common-obj-$(CONFIG_XLNX_ZYNQMP_ARM) += xlnx_dp.o
-obj-$(CONFIG_ATI_VGA) += ati.o ati_2d.o ati_dbg.o
+common-obj-$(CONFIG_ATI_VGA) += ati.o ati_2d.o ati_dbg.o
--
2.20.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [Qemu-devel] [PATCH 2/2] hw/display: Compile various display devices as common object
2019-08-12 11:37 ` [Qemu-devel] [PATCH 2/2] hw/display: Compile various display devices as common object Philippe Mathieu-Daudé
@ 2019-08-12 11:51 ` Thomas Huth
2019-08-21 9:00 ` Gerd Hoffmann
1 sibling, 0 replies; 11+ messages in thread
From: Thomas Huth @ 2019-08-12 11:51 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: Gerd Hoffmann, qemu-ppc, Markus Armbruster
On 8/12/19 1:37 PM, Philippe Mathieu-Daudé wrote:
> Various display devices are not target-specific and can
> be compiled once for all the targets.
> After this commit, the 'make world' target is reduced by
> 54 objectts
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Qemu-devel] [PATCH 2/2] hw/display: Compile various display devices as common object
2019-08-12 11:37 ` [Qemu-devel] [PATCH 2/2] hw/display: Compile various display devices as common object Philippe Mathieu-Daudé
2019-08-12 11:51 ` Thomas Huth
@ 2019-08-21 9:00 ` Gerd Hoffmann
2019-08-21 10:31 ` Philippe Mathieu-Daudé
1 sibling, 1 reply; 11+ messages in thread
From: Gerd Hoffmann @ 2019-08-21 9:00 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Thomas Huth, qemu-ppc, qemu-devel, Markus Armbruster
On Mon, Aug 12, 2019 at 01:37:38PM +0200, Philippe Mathieu-Daudé wrote:
> Various display devices are not target-specific and can
> be compiled once for all the targets.
> After this commit, the 'make world' target is reduced by
> 54 objects
Doesn't apply, needs a rebase.
cheers,
Gerd
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Qemu-devel] [PATCH 2/2] hw/display: Compile various display devices as common object
2019-08-21 9:00 ` Gerd Hoffmann
@ 2019-08-21 10:31 ` Philippe Mathieu-Daudé
2019-08-21 10:47 ` Laurent Vivier
0 siblings, 1 reply; 11+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-08-21 10:31 UTC (permalink / raw)
To: Gerd Hoffmann, Laurent Vivier
Cc: Thomas Huth, qemu-ppc, qemu-devel, Markus Armbruster
Hi Gerd,
On 8/21/19 11:00 AM, Gerd Hoffmann wrote:
> On Mon, Aug 12, 2019 at 01:37:38PM +0200, Philippe Mathieu-Daudé wrote:
>> Various display devices are not target-specific and can
>> be compiled once for all the targets.
>> After this commit, the 'make world' target is reduced by
>> 54 objects
>
> Doesn't apply, needs a rebase.
Laurent fixed the trivial conflict in patch #1.
Since patch #2 depends of patch #1, can you Ack it so Laurent queue it
in his trivial queue?
Thanks,
Phil.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Qemu-devel] [PATCH 2/2] hw/display: Compile various display devices as common object
2019-08-21 10:31 ` Philippe Mathieu-Daudé
@ 2019-08-21 10:47 ` Laurent Vivier
2019-08-21 11:13 ` Gerd Hoffmann
0 siblings, 1 reply; 11+ messages in thread
From: Laurent Vivier @ 2019-08-21 10:47 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, Gerd Hoffmann
Cc: Thomas Huth, qemu-ppc, qemu-devel, Markus Armbruster
Le 21/08/2019 à 12:31, Philippe Mathieu-Daudé a écrit :
> Hi Gerd,
>
> On 8/21/19 11:00 AM, Gerd Hoffmann wrote:
>> On Mon, Aug 12, 2019 at 01:37:38PM +0200, Philippe Mathieu-Daudé wrote:
>>> Various display devices are not target-specific and can
>>> be compiled once for all the targets.
>>> After this commit, the 'make world' target is reduced by
>>> 54 objects
>>
>> Doesn't apply, needs a rebase.
>
> Laurent fixed the trivial conflict in patch #1.
>
> Since patch #2 depends of patch #1, can you Ack it so Laurent queue it
> in his trivial queue?
Patch #2 applies cleanly once the patch #1 is fixed.
Gerd, if you acknowledge it I add it to my queue.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Qemu-devel] [PATCH 2/2] hw/display: Compile various display devices as common object
2019-08-21 10:47 ` Laurent Vivier
@ 2019-08-21 11:13 ` Gerd Hoffmann
0 siblings, 0 replies; 11+ messages in thread
From: Gerd Hoffmann @ 2019-08-21 11:13 UTC (permalink / raw)
To: Laurent Vivier
Cc: Thomas Huth, Markus Armbruster, qemu-devel, qemu-ppc,
Philippe Mathieu-Daudé
On Wed, Aug 21, 2019 at 12:47:07PM +0200, Laurent Vivier wrote:
> Le 21/08/2019 à 12:31, Philippe Mathieu-Daudé a écrit :
> > Hi Gerd,
> >
> > On 8/21/19 11:00 AM, Gerd Hoffmann wrote:
> >> On Mon, Aug 12, 2019 at 01:37:38PM +0200, Philippe Mathieu-Daudé wrote:
> >>> Various display devices are not target-specific and can
> >>> be compiled once for all the targets.
> >>> After this commit, the 'make world' target is reduced by
> >>> 54 objects
> >>
> >> Doesn't apply, needs a rebase.
> >
> > Laurent fixed the trivial conflict in patch #1.
> >
> > Since patch #2 depends of patch #1, can you Ack it so Laurent queue it
> > in his trivial queue?
>
> Patch #2 applies cleanly once the patch #1 is fixed.
>
> Gerd, if you acknowledge it I add it to my queue.
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Qemu-devel] [PATCH 0/2] hw/display: Compile various display devices as common object
2019-08-12 11:37 [Qemu-devel] [PATCH 0/2] hw/display: Compile various display devices as common object Philippe Mathieu-Daudé
2019-08-12 11:37 ` [Qemu-devel] [PATCH 1/2] hw/display/sm501: Remove unused include Philippe Mathieu-Daudé
2019-08-12 11:37 ` [Qemu-devel] [PATCH 2/2] hw/display: Compile various display devices as common object Philippe Mathieu-Daudé
@ 2019-08-12 11:56 ` BALATON Zoltan
2 siblings, 0 replies; 11+ messages in thread
From: BALATON Zoltan @ 2019-08-12 11:56 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Thomas Huth, Gerd Hoffmann, qemu-ppc, qemu-devel, Markus Armbruster
On Mon, 12 Aug 2019, Philippe Mathieu-Daudé wrote:
> This series move various generic display devices to $(common-obj-y),
> so they are compiled once for all targets.
>
> 'make world' is reduced by 54 objects.
>
> Philippe Mathieu-Daudé (2):
> hw/display/sm501: Remove unused include
> hw/display: Compile various display devices as common object
>
> hw/display/Makefile.objs | 18 +++++++++---------
> hw/display/sm501.c | 1 -
> 2 files changed, 9 insertions(+), 10 deletions(-)
Acked-by: BALATON Zoltan <balaton@eik.bme.hu>
For sm501 and ati-vga parts.
Regards,
BALATON Zoltan
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2019-08-21 11:22 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-12 11:37 [Qemu-devel] [PATCH 0/2] hw/display: Compile various display devices as common object Philippe Mathieu-Daudé
2019-08-12 11:37 ` [Qemu-devel] [PATCH 1/2] hw/display/sm501: Remove unused include Philippe Mathieu-Daudé
2019-08-12 11:47 ` Thomas Huth
2019-08-21 9:07 ` Laurent Vivier
2019-08-12 11:37 ` [Qemu-devel] [PATCH 2/2] hw/display: Compile various display devices as common object Philippe Mathieu-Daudé
2019-08-12 11:51 ` Thomas Huth
2019-08-21 9:00 ` Gerd Hoffmann
2019-08-21 10:31 ` Philippe Mathieu-Daudé
2019-08-21 10:47 ` Laurent Vivier
2019-08-21 11:13 ` Gerd Hoffmann
2019-08-12 11:56 ` [Qemu-devel] [PATCH 0/2] " BALATON Zoltan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).