* [Qemu-devel] [PATCH V2 1/2] tests.acceptance.avocado_qemu: Add support for powerpc
@ 2019-08-19 8:28 sathnaga
2019-08-24 9:32 ` David Gibson
0 siblings, 1 reply; 3+ messages in thread
From: sathnaga @ 2019-08-19 8:28 UTC (permalink / raw)
To: qemu-devel
Cc: ehabkost, groug, qemu-ppc, clg, crosa, Satheesh Rajendran, david
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=y, Size: 1264 bytes --]
From: Satheesh Rajendran <sathnaga@linux.vnet.ibm.com>
Current acceptance test will not run properly in powerpc
environment due qemu target is different from arch, this
usually matches, except with bi-endian architectures like ppc64.
uname would return `ppc64` or `ppc64le` based `big` or `little`
endian but qemu `target` is always `ppc64`. Let's handle it.
Reviewed-by: Cédric Le Goater <clg@kaod.org>
Signed-off-by: Satheesh Rajendran <sathnaga@linux.vnet.ibm.com>
---
tests/acceptance/avocado_qemu/__init__.py | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/acceptance/avocado_qemu/__init__.py b/tests/acceptance/avocado_qemu/__init__.py
index aee5d820ed..bd41e0443c 100644
--- a/tests/acceptance/avocado_qemu/__init__.py
+++ b/tests/acceptance/avocado_qemu/__init__.py
@@ -39,6 +39,9 @@ def pick_default_qemu_bin(arch=None):
"""
if arch is None:
arch = os.uname()[4]
+ # qemu binary path does not match arch for powerpc, handle it
+ if 'ppc64le' in arch:
+ arch = 'ppc64'
qemu_bin_relative_path = os.path.join("%s-softmmu" % arch,
"qemu-system-%s" % arch)
if is_readable_executable_file(qemu_bin_relative_path):
--
2.21.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH V2 1/2] tests.acceptance.avocado_qemu: Add support for powerpc
2019-08-19 8:28 [Qemu-devel] [PATCH V2 1/2] tests.acceptance.avocado_qemu: Add support for powerpc sathnaga
@ 2019-08-24 9:32 ` David Gibson
2019-08-27 16:00 ` Cleber Rosa
0 siblings, 1 reply; 3+ messages in thread
From: David Gibson @ 2019-08-24 9:32 UTC (permalink / raw)
To: sathnaga; +Cc: ehabkost, qemu-devel, groug, qemu-ppc, clg, crosa
[-- Attachment #1: Type: text/plain, Size: 1712 bytes --]
On Mon, Aug 19, 2019 at 01:58:20PM +0530, sathnaga@linux.vnet.ibm.com wrote:
> From: Satheesh Rajendran <sathnaga@linux.vnet.ibm.com>
>
> Current acceptance test will not run properly in powerpc
> environment due qemu target is different from arch, this
> usually matches, except with bi-endian architectures like ppc64.
> uname would return `ppc64` or `ppc64le` based `big` or `little`
> endian but qemu `target` is always `ppc64`. Let's handle it.
>
> Reviewed-by: Cédric Le Goater <clg@kaod.org>
> Signed-off-by: Satheesh Rajendran <sathnaga@linux.vnet.ibm.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
I sent a similar patch a little while back, but it seems it got lost.
> ---
> tests/acceptance/avocado_qemu/__init__.py | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/tests/acceptance/avocado_qemu/__init__.py b/tests/acceptance/avocado_qemu/__init__.py
> index aee5d820ed..bd41e0443c 100644
> --- a/tests/acceptance/avocado_qemu/__init__.py
> +++ b/tests/acceptance/avocado_qemu/__init__.py
> @@ -39,6 +39,9 @@ def pick_default_qemu_bin(arch=None):
> """
> if arch is None:
> arch = os.uname()[4]
> + # qemu binary path does not match arch for powerpc, handle it
> + if 'ppc64le' in arch:
> + arch = 'ppc64'
> qemu_bin_relative_path = os.path.join("%s-softmmu" % arch,
> "qemu-system-%s" % arch)
> if is_readable_executable_file(qemu_bin_relative_path):
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH V2 1/2] tests.acceptance.avocado_qemu: Add support for powerpc
2019-08-24 9:32 ` David Gibson
@ 2019-08-27 16:00 ` Cleber Rosa
0 siblings, 0 replies; 3+ messages in thread
From: Cleber Rosa @ 2019-08-27 16:00 UTC (permalink / raw)
To: David Gibson; +Cc: ehabkost, groug, qemu-devel, qemu-ppc, clg, sathnaga
On Sat, Aug 24, 2019 at 07:32:55PM +1000, David Gibson wrote:
> On Mon, Aug 19, 2019 at 01:58:20PM +0530, sathnaga@linux.vnet.ibm.com wrote:
> > From: Satheesh Rajendran <sathnaga@linux.vnet.ibm.com>
> >
> > Current acceptance test will not run properly in powerpc
> > environment due qemu target is different from arch, this
> > usually matches, except with bi-endian architectures like ppc64.
> > uname would return `ppc64` or `ppc64le` based `big` or `little`
> > endian but qemu `target` is always `ppc64`. Let's handle it.
> >
> > Reviewed-by: Cédric Le Goater <clg@kaod.org>
> > Signed-off-by: Satheesh Rajendran <sathnaga@linux.vnet.ibm.com>
>
> Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
>
> I sent a similar patch a little while back, but it seems it got lost.
>
>
> > ---
> > tests/acceptance/avocado_qemu/__init__.py | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/tests/acceptance/avocado_qemu/__init__.py b/tests/acceptance/avocado_qemu/__init__.py
> > index aee5d820ed..bd41e0443c 100644
> > --- a/tests/acceptance/avocado_qemu/__init__.py
> > +++ b/tests/acceptance/avocado_qemu/__init__.py
> > @@ -39,6 +39,9 @@ def pick_default_qemu_bin(arch=None):
> > """
> > if arch is None:
> > arch = os.uname()[4]
> > + # qemu binary path does not match arch for powerpc, handle it
> > + if 'ppc64le' in arch:
> > + arch = 'ppc64'
> > qemu_bin_relative_path = os.path.join("%s-softmmu" % arch,
> > "qemu-system-%s" % arch)
> > if is_readable_executable_file(qemu_bin_relative_path):
>
> --
> David Gibson | I'll have my music baroque, and my code
> david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
> | _way_ _around_!
> http://www.ozlabs.org/~dgibson
Yes, I remember that. I have the feeling the discussion evolved into
"let's do it for all other arch differences", because I found a patch
here about that. Anyway, sorry about that.
I've queued this one.
- Cleber.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-08-27 16:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-19 8:28 [Qemu-devel] [PATCH V2 1/2] tests.acceptance.avocado_qemu: Add support for powerpc sathnaga
2019-08-24 9:32 ` David Gibson
2019-08-27 16:00 ` Cleber Rosa
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).