* [PATCH 0/1] BZ#1751431:guest-get-memory-block-info is not supported @ 2019-10-17 12:34 Basil Salman 2019-10-17 12:34 ` [PATCH 1/1] qga: Add "guest-get-memory-block-info" to blacklist Basil Salman 2019-10-31 13:20 ` [PATCH 0/1] BZ#1751431:guest-get-memory-block-info is not supported Basil Salman 0 siblings, 2 replies; 4+ messages in thread From: Basil Salman @ 2019-10-17 12:34 UTC (permalink / raw) To: qemu-devel, Michael Roth; +Cc: Yan Vugenfirer From: Basil Salman <bsalman@redhat.com> "guest-get-memory-block-info" is enabled according to "get-info" output, while the command is only supported for linux with sysfs. "guest-get-memory-block-info" command was added to blacklist. Basil Salman (1): qga: Add "guest-get-memory-block-info" to blacklist qga/commands-posix.c | 3 ++- qga/commands-win32.c | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) -- 2.17.2 ^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/1] qga: Add "guest-get-memory-block-info" to blacklist 2019-10-17 12:34 [PATCH 0/1] BZ#1751431:guest-get-memory-block-info is not supported Basil Salman @ 2019-10-17 12:34 ` Basil Salman 2019-10-31 18:28 ` Marc-André Lureau 2019-10-31 13:20 ` [PATCH 0/1] BZ#1751431:guest-get-memory-block-info is not supported Basil Salman 1 sibling, 1 reply; 4+ messages in thread From: Basil Salman @ 2019-10-17 12:34 UTC (permalink / raw) To: qemu-devel, Michael Roth; +Cc: Yan Vugenfirer From: Basil Salman <bsalman@redhat.com> Memory block commands are only supported for linux with sysfs, "guest-get-memory-block-info" was not in blacklist for other cases. Reported on: https://bugzilla.redhat.com/show_bug.cgi?id=1751431 Signed-off-by: Basil Salman <bsalman@redhat.com> --- qga/commands-posix.c | 3 ++- qga/commands-win32.c | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index dfc05f5b8a..1c1a165dae 100644 --- a/qga/commands-posix.c +++ b/qga/commands-posix.c @@ -2730,7 +2730,8 @@ GList *ga_command_blacklist_init(GList *blacklist) "guest-suspend-hybrid", "guest-network-get-interfaces", "guest-get-vcpus", "guest-set-vcpus", "guest-get-memory-blocks", "guest-set-memory-blocks", - "guest-get-memory-block-size", NULL}; + "guest-get-memory-block-size", "guest-get-memory-block-info", + NULL}; char **p = (char **)list; while (*p) { diff --git a/qga/commands-win32.c b/qga/commands-win32.c index 6b67f16faf..1c9ec9c094 100644 --- a/qga/commands-win32.c +++ b/qga/commands-win32.c @@ -1894,7 +1894,7 @@ GList *ga_command_blacklist_init(GList *blacklist) "guest-suspend-hybrid", "guest-set-vcpus", "guest-get-memory-blocks", "guest-set-memory-blocks", - "guest-get-memory-block-size", + "guest-get-memory-block-size", "guest-get-memory-block-info", NULL}; char **p = (char **)list_unsupported; -- 2.17.2 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] qga: Add "guest-get-memory-block-info" to blacklist 2019-10-17 12:34 ` [PATCH 1/1] qga: Add "guest-get-memory-block-info" to blacklist Basil Salman @ 2019-10-31 18:28 ` Marc-André Lureau 0 siblings, 0 replies; 4+ messages in thread From: Marc-André Lureau @ 2019-10-31 18:28 UTC (permalink / raw) To: Basil Salman; +Cc: Yan Vugenfirer, QEMU, Michael Roth On Thu, Oct 17, 2019 at 2:35 PM Basil Salman <basil@daynix.com> wrote: > > From: Basil Salman <bsalman@redhat.com> > > Memory block commands are only supported for linux with sysfs, > "guest-get-memory-block-info" was not in blacklist for other > cases. > > Reported on: > https://bugzilla.redhat.com/show_bug.cgi?id=1751431 > > Signed-off-by: Basil Salman <bsalman@redhat.com> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com> > --- > qga/commands-posix.c | 3 ++- > qga/commands-win32.c | 2 +- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/qga/commands-posix.c b/qga/commands-posix.c > index dfc05f5b8a..1c1a165dae 100644 > --- a/qga/commands-posix.c > +++ b/qga/commands-posix.c > @@ -2730,7 +2730,8 @@ GList *ga_command_blacklist_init(GList *blacklist) > "guest-suspend-hybrid", "guest-network-get-interfaces", > "guest-get-vcpus", "guest-set-vcpus", > "guest-get-memory-blocks", "guest-set-memory-blocks", > - "guest-get-memory-block-size", NULL}; > + "guest-get-memory-block-size", "guest-get-memory-block-info", > + NULL}; > char **p = (char **)list; > > while (*p) { > diff --git a/qga/commands-win32.c b/qga/commands-win32.c > index 6b67f16faf..1c9ec9c094 100644 > --- a/qga/commands-win32.c > +++ b/qga/commands-win32.c > @@ -1894,7 +1894,7 @@ GList *ga_command_blacklist_init(GList *blacklist) > "guest-suspend-hybrid", > "guest-set-vcpus", > "guest-get-memory-blocks", "guest-set-memory-blocks", > - "guest-get-memory-block-size", > + "guest-get-memory-block-size", "guest-get-memory-block-info", > NULL}; > char **p = (char **)list_unsupported; > > -- > 2.17.2 > > -- Marc-André Lureau ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 0/1] BZ#1751431:guest-get-memory-block-info is not supported 2019-10-17 12:34 [PATCH 0/1] BZ#1751431:guest-get-memory-block-info is not supported Basil Salman 2019-10-17 12:34 ` [PATCH 1/1] qga: Add "guest-get-memory-block-info" to blacklist Basil Salman @ 2019-10-31 13:20 ` Basil Salman 1 sibling, 0 replies; 4+ messages in thread From: Basil Salman @ 2019-10-31 13:20 UTC (permalink / raw) To: qemu-devel, Michael Roth; +Cc: Yan Vugenfirer [-- Attachment #1: Type: text/plain, Size: 538 bytes --] PING On Thu, Oct 17, 2019 at 3:34 PM Basil Salman <basil@daynix.com> wrote: > From: Basil Salman <bsalman@redhat.com> > > "guest-get-memory-block-info" is enabled according to "get-info" output, > while the command is only supported for linux with sysfs. > > "guest-get-memory-block-info" command was added to blacklist. > > Basil Salman (1): > qga: Add "guest-get-memory-block-info" to blacklist > > qga/commands-posix.c | 3 ++- > qga/commands-win32.c | 2 +- > 2 files changed, 3 insertions(+), 2 deletions(-) > > -- > 2.17.2 > > [-- Attachment #2: Type: text/html, Size: 976 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-10-31 18:31 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-10-17 12:34 [PATCH 0/1] BZ#1751431:guest-get-memory-block-info is not supported Basil Salman 2019-10-17 12:34 ` [PATCH 1/1] qga: Add "guest-get-memory-block-info" to blacklist Basil Salman 2019-10-31 18:28 ` Marc-André Lureau 2019-10-31 13:20 ` [PATCH 0/1] BZ#1751431:guest-get-memory-block-info is not supported Basil Salman
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).