qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [Fail] tests/test-util-filemonitor fails
@ 2019-08-08  2:07 Wei Yang
  2019-08-08  8:02 ` Daniel P. Berrangé
  0 siblings, 1 reply; 10+ messages in thread
From: Wei Yang @ 2019-08-08  2:07 UTC (permalink / raw)
  To: qemu-devel, berrange, dgilbert, marcandre.lureau

Current qemu fails tests/test-util-filemonitor.

By bisect, it shows this commit introduced the error. 

commit ff3dc8fefe953fd3650279e064bf63b212c5699a
Author: Daniel P. Berrang茅 <berrange@redhat.com>
Date:   Wed Mar 13 17:36:18 2019 +0000

    filemon: ensure watch IDs are unique to QFileMonitor scope
    
    The watch IDs are mistakenly only unique within the scope of the
    directory being monitored. This is not useful for clients which are
    monitoring multiple directories. They require watch IDs to be unique
    globally within the QFileMonitor scope.

After revert 

"filemon: ensure watch IDs are unique to QFileMonitor scope"
"filemon: fix watch IDs to avoid potential wraparound issues"

The test pass.

-- 
Wei Yang
Help you, Help me


^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2019-11-08  8:53 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-08  2:07 [Qemu-devel] [Fail] tests/test-util-filemonitor fails Wei Yang
2019-08-08  8:02 ` Daniel P. Berrangé
2019-08-08  8:46   ` Wei Yang
2019-08-08  9:22     ` Daniel P. Berrangé
2019-08-09  0:06       ` Wei Yang
2019-08-09  9:12         ` Daniel P. Berrangé
2019-08-12  0:49           ` Wei Yang
2019-11-04 19:35           ` Miguel Arruga Vivas
2019-11-05  9:54             ` Daniel P. Berrangé
2019-11-08  8:52               ` Miguel Arruga Vivas

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).