* [PATCH] linux-user/strace: Improve output of various syscalls
@ 2019-11-19 19:04 Helge Deller
2019-11-20 2:35 ` Aleksandar Markovic
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Helge Deller @ 2019-11-19 19:04 UTC (permalink / raw)
To: qemu-devel, Laurent Vivier, Philippe Mathieu-Daudé
Improve strace output of various syscalls which either have none
or only int-type parameters.
Signed-off-by: Helge Deller <deller@gmx.de>
diff --git a/linux-user/strace.list b/linux-user/strace.list
index 1de4319dcf..5163717087 100644
--- a/linux-user/strace.list
+++ b/linux-user/strace.list
@@ -26,7 +26,7 @@
{ TARGET_NR_afs_syscall, "afs_syscall" , NULL, NULL, NULL },
#endif
#ifdef TARGET_NR_alarm
-{ TARGET_NR_alarm, "alarm" , NULL, NULL, NULL },
+{ TARGET_NR_alarm, "alarm" , "%s(%d)", NULL, NULL },
#endif
#ifdef TARGET_NR_aplib
{ TARGET_NR_aplib, "aplib" , NULL, NULL, NULL },
@@ -116,13 +116,13 @@
{ TARGET_NR_dipc, "dipc" , NULL, NULL, NULL },
#endif
#ifdef TARGET_NR_dup
-{ TARGET_NR_dup, "dup" , NULL, NULL, NULL },
+{ TARGET_NR_dup, "dup" , "%s(%d)", NULL, NULL },
#endif
#ifdef TARGET_NR_dup2
-{ TARGET_NR_dup2, "dup2" , NULL, NULL, NULL },
+{ TARGET_NR_dup2, "dup2" , "%s(%d,%d)", NULL, NULL },
#endif
#ifdef TARGET_NR_dup3
-{ TARGET_NR_dup3, "dup3" , NULL, NULL, NULL },
+{ TARGET_NR_dup3, "dup3" , "%s(%d,%d,%d)", NULL, NULL },
#endif
#ifdef TARGET_NR_epoll_create
{ TARGET_NR_epoll_create, "epoll_create" , NULL, NULL, NULL },
@@ -191,7 +191,7 @@
{ TARGET_NR_fanotify_mark, "fanotify_mark" , NULL, NULL, NULL },
#endif
#ifdef TARGET_NR_fchdir
-{ TARGET_NR_fchdir, "fchdir" , NULL, NULL, NULL },
+{ TARGET_NR_fchdir, "fchdir" , "%s(%d)", NULL, NULL },
#endif
#ifdef TARGET_NR_fchmod
{ TARGET_NR_fchmod, "fchmod" , "%s(%d,%#o)", NULL, NULL },
@@ -287,7 +287,7 @@
{ TARGET_NR_getdtablesize, "getdtablesize" , NULL, NULL, NULL },
#endif
#ifdef TARGET_NR_getegid
-{ TARGET_NR_getegid, "getegid" , NULL, NULL, NULL },
+{ TARGET_NR_getegid, "getegid" , "%s()", NULL, NULL },
#endif
#ifdef TARGET_NR_getegid32
{ TARGET_NR_getegid32, "getegid32" , NULL, NULL, NULL },
@@ -299,7 +299,7 @@
{ TARGET_NR_geteuid32, "geteuid32" , NULL, NULL, NULL },
#endif
#ifdef TARGET_NR_getgid
-{ TARGET_NR_getgid, "getgid" , NULL, NULL, NULL },
+{ TARGET_NR_getgid, "getgid" , "%s()", NULL, NULL },
#endif
#ifdef TARGET_NR_getgid32
{ TARGET_NR_getgid32, "getgid32" , NULL, NULL, NULL },
@@ -329,10 +329,10 @@
{ TARGET_NR_getpeername, "getpeername" , NULL, NULL, NULL },
#endif
#ifdef TARGET_NR_getpgid
-{ TARGET_NR_getpgid, "getpgid" , NULL, NULL, NULL },
+{ TARGET_NR_getpgid, "getpgid" , "%s(%u)", NULL, NULL },
#endif
#ifdef TARGET_NR_getpgrp
-{ TARGET_NR_getpgrp, "getpgrp" , NULL, NULL, NULL },
+{ TARGET_NR_getpgrp, "getpgrp" , "%s()", NULL, NULL },
#endif
#ifdef TARGET_NR_getpid
{ TARGET_NR_getpid, "getpid" , "%s()", NULL, NULL },
@@ -432,7 +432,7 @@
{ TARGET_NR_io_cancel, "io_cancel" , NULL, NULL, NULL },
#endif
#ifdef TARGET_NR_ioctl
-{ TARGET_NR_ioctl, "ioctl" , NULL, NULL, NULL },
+{ TARGET_NR_ioctl, "ioctl" , "%s(%d,%#x,%#x,%#x,%#x,%#x)", NULL, NULL },
#endif
#ifdef TARGET_NR_io_destroy
{ TARGET_NR_io_destroy, "io_destroy" , NULL, NULL, NULL },
@@ -1257,22 +1257,22 @@
{ TARGET_NR_setdomainname, "setdomainname" , NULL, NULL, NULL },
#endif
#ifdef TARGET_NR_setfsgid
-{ TARGET_NR_setfsgid, "setfsgid" , NULL, NULL, NULL },
+{ TARGET_NR_setfsgid, "setfsgid" , "%s(%u)", NULL, NULL },
#endif
#ifdef TARGET_NR_setfsgid32
-{ TARGET_NR_setfsgid32, "setfsgid32" , NULL, NULL, NULL },
+{ TARGET_NR_setfsgid32, "setfsgid32" , "%s(%u)" , NULL, NULL },
#endif
#ifdef TARGET_NR_setfsuid
-{ TARGET_NR_setfsuid, "setfsuid" , NULL, NULL, NULL },
+{ TARGET_NR_setfsuid, "setfsuid" , "%s(%u)" , NULL, NULL },
#endif
#ifdef TARGET_NR_setfsuid32
{ TARGET_NR_setfsuid32, "setfsuid32" , NULL, NULL, NULL },
#endif
#ifdef TARGET_NR_setgid
-{ TARGET_NR_setgid, "setgid" , NULL, NULL, NULL },
+{ TARGET_NR_setgid, "setgid" , "%s(%u)", NULL, NULL },
#endif
#ifdef TARGET_NR_setgid32
-{ TARGET_NR_setgid32, "setgid32" , NULL, NULL, NULL },
+{ TARGET_NR_setgid32, "setgid32" , "%s(%u)", NULL, NULL },
#endif
#ifdef TARGET_NR_setgroups
{ TARGET_NR_setgroups, "setgroups" , NULL, NULL, NULL },
@@ -1296,7 +1296,7 @@
{ TARGET_NR_setns, "setns" , NULL, NULL, NULL },
#endif
#ifdef TARGET_NR_setpgid
-{ TARGET_NR_setpgid, "setpgid" , NULL, NULL, NULL },
+{ TARGET_NR_setpgid, "setpgid" , "%s(%u,%u)", NULL, NULL },
#endif
#ifdef TARGET_NR_setpgrp
{ TARGET_NR_setpgrp, "setpgrp" , NULL, NULL, NULL },
@@ -1311,22 +1311,22 @@
{ TARGET_NR_setregid32, "setregid32" , NULL, NULL, NULL },
#endif
#ifdef TARGET_NR_setresgid
-{ TARGET_NR_setresgid, "setresgid" , NULL, NULL, NULL },
+{ TARGET_NR_setresgid, "setresgid" , "%s(%u,%u,%u)", NULL, NULL },
#endif
#ifdef TARGET_NR_setresgid32
{ TARGET_NR_setresgid32, "setresgid32" , NULL, NULL, NULL },
#endif
#ifdef TARGET_NR_setresuid
-{ TARGET_NR_setresuid, "setresuid" , NULL, NULL, NULL },
+{ TARGET_NR_setresuid, "setresuid" , "%s(%u,%u,%u)", NULL, NULL },
#endif
#ifdef TARGET_NR_setresuid32
-{ TARGET_NR_setresuid32, "setresuid32" , NULL, NULL, NULL },
+{ TARGET_NR_setresuid32, "setresuid32" , "%s(%u,%u,%u)", NULL, NULL },
#endif
#ifdef TARGET_NR_setreuid
-{ TARGET_NR_setreuid, "setreuid" , NULL, NULL, NULL },
+{ TARGET_NR_setreuid, "setreuid" , "%s(%u,%u)", NULL, NULL },
#endif
#ifdef TARGET_NR_setreuid32
-{ TARGET_NR_setreuid32, "setreuid32" , NULL, NULL, NULL },
+{ TARGET_NR_setreuid32, "setreuid32" , "%s(%u,%u)", NULL, NULL },
#endif
#ifdef TARGET_NR_setrlimit
{ TARGET_NR_setrlimit, "setrlimit" , NULL, NULL, NULL },
@@ -1335,7 +1335,7 @@
{ TARGET_NR_set_robust_list, "set_robust_list" , NULL, NULL, NULL },
#endif
#ifdef TARGET_NR_setsid
-{ TARGET_NR_setsid, "setsid" , NULL, NULL, NULL },
+{ TARGET_NR_setsid, "setsid" , "%s()", NULL, NULL },
#endif
#ifdef TARGET_NR_setsockopt
{ TARGET_NR_setsockopt, "setsockopt" , NULL, NULL, NULL },
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] linux-user/strace: Improve output of various syscalls 2019-11-19 19:04 [PATCH] linux-user/strace: Improve output of various syscalls Helge Deller @ 2019-11-20 2:35 ` Aleksandar Markovic 2019-11-20 20:44 ` Aleksandar Markovic 2019-11-20 20:57 ` Aleksandar Markovic 2 siblings, 0 replies; 5+ messages in thread From: Aleksandar Markovic @ 2019-11-20 2:35 UTC (permalink / raw) To: Helge Deller; +Cc: Philippe Mathieu-Daudé, qemu-devel, Laurent Vivier [-- Attachment #1: Type: text/plain, Size: 224 bytes --] > > #ifdef TARGET_NR_ioctl > -{ TARGET_NR_ioctl, "ioctl" , NULL, NULL, NULL }, > +{ TARGET_NR_ioctl, "ioctl" , "%s(%d,%#x,%#x,%#x,%#x,%#x)", NULL, NULL }, > #endif ioctl() has only three arguments. Regards, Aleksandar [-- Attachment #2: Type: text/html, Size: 480 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] linux-user/strace: Improve output of various syscalls 2019-11-19 19:04 [PATCH] linux-user/strace: Improve output of various syscalls Helge Deller 2019-11-20 2:35 ` Aleksandar Markovic @ 2019-11-20 20:44 ` Aleksandar Markovic 2019-11-20 20:57 ` Aleksandar Markovic 2 siblings, 0 replies; 5+ messages in thread From: Aleksandar Markovic @ 2019-11-20 20:44 UTC (permalink / raw) To: Helge Deller; +Cc: Philippe Mathieu-Daudé, QEMU Developers, Laurent Vivier > @@ -26,7 +26,7 @@ > { TARGET_NR_afs_syscall, "afs_syscall" , NULL, NULL, NULL }, > #endif > #ifdef TARGET_NR_alarm > -{ TARGET_NR_alarm, "alarm" , NULL, NULL, NULL }, > +{ TARGET_NR_alarm, "alarm" , "%s(%d)", NULL, NULL }, > #endif Man page says: unsigned int alarm(unsigned int seconds) The sole argument is unsigned int - therefore "%d" should be "%u", shouldn't it? -------------------------------------------------- This is not a part of your changes, but appeared in your patch diff: > #ifdef TARGET_NR_epoll_create > { TARGET_NR_epoll_create, "epoll_create" , NULL, NULL, NULL }, From man pages: int epoll_create(int size); So, this also belongs to the category "has only int-type parameter,' and "%s(%d)" should be used, no? --------------------------------------------------- > #ifdef TARGET_NR_setresgid > -{ TARGET_NR_setresgid, "setresgid" , NULL, NULL, NULL }, > +{ TARGET_NR_setresgid, "setresgid" , "%s(%u,%u,%u)", NULL, NULL }, > #endif > #ifdef TARGET_NR_setresgid32 > { TARGET_NR_setresgid32, "setresgid32" , NULL, NULL, NULL }, > #endif Why are you here correcting setresgid(), but leaving setresgid32() intact, even though they have the same argument type pattern? -------------------------------------------------- I have these objections, however, in general, I salute the patch, and your efforts to improve QEMU linux-user strace, it is a quite useful debug tool, and thanks for doing this! :) Yours, Aleksandar ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] linux-user/strace: Improve output of various syscalls 2019-11-19 19:04 [PATCH] linux-user/strace: Improve output of various syscalls Helge Deller 2019-11-20 2:35 ` Aleksandar Markovic 2019-11-20 20:44 ` Aleksandar Markovic @ 2019-11-20 20:57 ` Aleksandar Markovic 2019-11-20 21:02 ` Aleksandar Markovic 2 siblings, 1 reply; 5+ messages in thread From: Aleksandar Markovic @ 2019-11-20 20:57 UTC (permalink / raw) To: Helge Deller; +Cc: Philippe Mathieu-Daudé, QEMU Developers, Laurent Vivier On Tue, Nov 19, 2019 at 8:05 PM Helge Deller <deller@gmx.de> wrote: > > Improve strace output of various syscalls which either have none > or only int-type parameters. > > Signed-off-by: Helge Deller <deller@gmx.de> > A very good patch! It would be even better if it covered ALL syscalls either without parameter or with all int-like parameters. I believe this table can be very useful to you, for the purpose of identifying such syscalls, and completing your patch: https://blog.rchapman.org/posts/Linux_System_Call_Table_for_x86_64/ Regards, Aleksandar > diff --git a/linux-user/strace.list b/linux-user/strace.list > index 1de4319dcf..5163717087 100644 > --- a/linux-user/strace.list > +++ b/linux-user/strace.list > @@ -26,7 +26,7 @@ > { TARGET_NR_afs_syscall, "afs_syscall" , NULL, NULL, NULL }, > #endif > #ifdef TARGET_NR_alarm > -{ TARGET_NR_alarm, "alarm" , NULL, NULL, NULL }, > +{ TARGET_NR_alarm, "alarm" , "%s(%d)", NULL, NULL }, > #endif > #ifdef TARGET_NR_aplib > { TARGET_NR_aplib, "aplib" , NULL, NULL, NULL }, > @@ -116,13 +116,13 @@ > { TARGET_NR_dipc, "dipc" , NULL, NULL, NULL }, > #endif > #ifdef TARGET_NR_dup > -{ TARGET_NR_dup, "dup" , NULL, NULL, NULL }, > +{ TARGET_NR_dup, "dup" , "%s(%d)", NULL, NULL }, > #endif > #ifdef TARGET_NR_dup2 > -{ TARGET_NR_dup2, "dup2" , NULL, NULL, NULL }, > +{ TARGET_NR_dup2, "dup2" , "%s(%d,%d)", NULL, NULL }, > #endif > #ifdef TARGET_NR_dup3 > -{ TARGET_NR_dup3, "dup3" , NULL, NULL, NULL }, > +{ TARGET_NR_dup3, "dup3" , "%s(%d,%d,%d)", NULL, NULL }, > #endif > #ifdef TARGET_NR_epoll_create > { TARGET_NR_epoll_create, "epoll_create" , NULL, NULL, NULL }, > @@ -191,7 +191,7 @@ > { TARGET_NR_fanotify_mark, "fanotify_mark" , NULL, NULL, NULL }, > #endif > #ifdef TARGET_NR_fchdir > -{ TARGET_NR_fchdir, "fchdir" , NULL, NULL, NULL }, > +{ TARGET_NR_fchdir, "fchdir" , "%s(%d)", NULL, NULL }, > #endif > #ifdef TARGET_NR_fchmod > { TARGET_NR_fchmod, "fchmod" , "%s(%d,%#o)", NULL, NULL }, > @@ -287,7 +287,7 @@ > { TARGET_NR_getdtablesize, "getdtablesize" , NULL, NULL, NULL }, > #endif > #ifdef TARGET_NR_getegid > -{ TARGET_NR_getegid, "getegid" , NULL, NULL, NULL }, > +{ TARGET_NR_getegid, "getegid" , "%s()", NULL, NULL }, > #endif > #ifdef TARGET_NR_getegid32 > { TARGET_NR_getegid32, "getegid32" , NULL, NULL, NULL }, > @@ -299,7 +299,7 @@ > { TARGET_NR_geteuid32, "geteuid32" , NULL, NULL, NULL }, > #endif > #ifdef TARGET_NR_getgid > -{ TARGET_NR_getgid, "getgid" , NULL, NULL, NULL }, > +{ TARGET_NR_getgid, "getgid" , "%s()", NULL, NULL }, > #endif > #ifdef TARGET_NR_getgid32 > { TARGET_NR_getgid32, "getgid32" , NULL, NULL, NULL }, > @@ -329,10 +329,10 @@ > { TARGET_NR_getpeername, "getpeername" , NULL, NULL, NULL }, > #endif > #ifdef TARGET_NR_getpgid > -{ TARGET_NR_getpgid, "getpgid" , NULL, NULL, NULL }, > +{ TARGET_NR_getpgid, "getpgid" , "%s(%u)", NULL, NULL }, > #endif > #ifdef TARGET_NR_getpgrp > -{ TARGET_NR_getpgrp, "getpgrp" , NULL, NULL, NULL }, > +{ TARGET_NR_getpgrp, "getpgrp" , "%s()", NULL, NULL }, > #endif > #ifdef TARGET_NR_getpid > { TARGET_NR_getpid, "getpid" , "%s()", NULL, NULL }, > @@ -432,7 +432,7 @@ > { TARGET_NR_io_cancel, "io_cancel" , NULL, NULL, NULL }, > #endif > #ifdef TARGET_NR_ioctl > -{ TARGET_NR_ioctl, "ioctl" , NULL, NULL, NULL }, > +{ TARGET_NR_ioctl, "ioctl" , "%s(%d,%#x,%#x,%#x,%#x,%#x)", NULL, NULL }, > #endif > #ifdef TARGET_NR_io_destroy > { TARGET_NR_io_destroy, "io_destroy" , NULL, NULL, NULL }, > @@ -1257,22 +1257,22 @@ > { TARGET_NR_setdomainname, "setdomainname" , NULL, NULL, NULL }, > #endif > #ifdef TARGET_NR_setfsgid > -{ TARGET_NR_setfsgid, "setfsgid" , NULL, NULL, NULL }, > +{ TARGET_NR_setfsgid, "setfsgid" , "%s(%u)", NULL, NULL }, > #endif > #ifdef TARGET_NR_setfsgid32 > -{ TARGET_NR_setfsgid32, "setfsgid32" , NULL, NULL, NULL }, > +{ TARGET_NR_setfsgid32, "setfsgid32" , "%s(%u)" , NULL, NULL }, > #endif > #ifdef TARGET_NR_setfsuid > -{ TARGET_NR_setfsuid, "setfsuid" , NULL, NULL, NULL }, > +{ TARGET_NR_setfsuid, "setfsuid" , "%s(%u)" , NULL, NULL }, > #endif > #ifdef TARGET_NR_setfsuid32 > { TARGET_NR_setfsuid32, "setfsuid32" , NULL, NULL, NULL }, > #endif > #ifdef TARGET_NR_setgid > -{ TARGET_NR_setgid, "setgid" , NULL, NULL, NULL }, > +{ TARGET_NR_setgid, "setgid" , "%s(%u)", NULL, NULL }, > #endif > #ifdef TARGET_NR_setgid32 > -{ TARGET_NR_setgid32, "setgid32" , NULL, NULL, NULL }, > +{ TARGET_NR_setgid32, "setgid32" , "%s(%u)", NULL, NULL }, > #endif > #ifdef TARGET_NR_setgroups > { TARGET_NR_setgroups, "setgroups" , NULL, NULL, NULL }, > @@ -1296,7 +1296,7 @@ > { TARGET_NR_setns, "setns" , NULL, NULL, NULL }, > #endif > #ifdef TARGET_NR_setpgid > -{ TARGET_NR_setpgid, "setpgid" , NULL, NULL, NULL }, > +{ TARGET_NR_setpgid, "setpgid" , "%s(%u,%u)", NULL, NULL }, > #endif > #ifdef TARGET_NR_setpgrp > { TARGET_NR_setpgrp, "setpgrp" , NULL, NULL, NULL }, > @@ -1311,22 +1311,22 @@ > { TARGET_NR_setregid32, "setregid32" , NULL, NULL, NULL }, > #endif > #ifdef TARGET_NR_setresgid > -{ TARGET_NR_setresgid, "setresgid" , NULL, NULL, NULL }, > +{ TARGET_NR_setresgid, "setresgid" , "%s(%u,%u,%u)", NULL, NULL }, > #endif > #ifdef TARGET_NR_setresgid32 > { TARGET_NR_setresgid32, "setresgid32" , NULL, NULL, NULL }, > #endif > #ifdef TARGET_NR_setresuid > -{ TARGET_NR_setresuid, "setresuid" , NULL, NULL, NULL }, > +{ TARGET_NR_setresuid, "setresuid" , "%s(%u,%u,%u)", NULL, NULL }, > #endif > #ifdef TARGET_NR_setresuid32 > -{ TARGET_NR_setresuid32, "setresuid32" , NULL, NULL, NULL }, > +{ TARGET_NR_setresuid32, "setresuid32" , "%s(%u,%u,%u)", NULL, NULL }, > #endif > #ifdef TARGET_NR_setreuid > -{ TARGET_NR_setreuid, "setreuid" , NULL, NULL, NULL }, > +{ TARGET_NR_setreuid, "setreuid" , "%s(%u,%u)", NULL, NULL }, > #endif > #ifdef TARGET_NR_setreuid32 > -{ TARGET_NR_setreuid32, "setreuid32" , NULL, NULL, NULL }, > +{ TARGET_NR_setreuid32, "setreuid32" , "%s(%u,%u)", NULL, NULL }, > #endif > #ifdef TARGET_NR_setrlimit > { TARGET_NR_setrlimit, "setrlimit" , NULL, NULL, NULL }, > @@ -1335,7 +1335,7 @@ > { TARGET_NR_set_robust_list, "set_robust_list" , NULL, NULL, NULL }, > #endif > #ifdef TARGET_NR_setsid > -{ TARGET_NR_setsid, "setsid" , NULL, NULL, NULL }, > +{ TARGET_NR_setsid, "setsid" , "%s()", NULL, NULL }, > #endif > #ifdef TARGET_NR_setsockopt > { TARGET_NR_setsockopt, "setsockopt" , NULL, NULL, NULL }, > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] linux-user/strace: Improve output of various syscalls 2019-11-20 20:57 ` Aleksandar Markovic @ 2019-11-20 21:02 ` Aleksandar Markovic 0 siblings, 0 replies; 5+ messages in thread From: Aleksandar Markovic @ 2019-11-20 21:02 UTC (permalink / raw) To: Helge Deller; +Cc: Philippe Mathieu-Daudé, QEMU Developers, Laurent Vivier On Wed, Nov 20, 2019 at 9:57 PM Aleksandar Markovic <aleksandar.m.mail@gmail.com> wrote: > > On Tue, Nov 19, 2019 at 8:05 PM Helge Deller <deller@gmx.de> wrote: > > > > Improve strace output of various syscalls which either have none > > or only int-type parameters. > > > > Signed-off-by: Helge Deller <deller@gmx.de> > > > > A very good patch! > > It would be even better if it covered ALL syscalls either without > parameter or with all int-like parameters. > > I believe this table can be very useful to you, for the purpose > of identifying such syscalls, and completing your patch: > > https://blog.rchapman.org/posts/Linux_System_Call_Table_for_x86_64/ > You can even add items in strace.list for, let's say: sys_sched_get_priority_max() sys_sched_get_priority_min() Both have "int policy" as a sole argument. > Regards, > Aleksandar > > > > diff --git a/linux-user/strace.list b/linux-user/strace.list > > index 1de4319dcf..5163717087 100644 > > --- a/linux-user/strace.list > > +++ b/linux-user/strace.list > > @@ -26,7 +26,7 @@ > > { TARGET_NR_afs_syscall, "afs_syscall" , NULL, NULL, NULL }, > > #endif > > #ifdef TARGET_NR_alarm > > -{ TARGET_NR_alarm, "alarm" , NULL, NULL, NULL }, > > +{ TARGET_NR_alarm, "alarm" , "%s(%d)", NULL, NULL }, > > #endif > > #ifdef TARGET_NR_aplib > > { TARGET_NR_aplib, "aplib" , NULL, NULL, NULL }, > > @@ -116,13 +116,13 @@ > > { TARGET_NR_dipc, "dipc" , NULL, NULL, NULL }, > > #endif > > #ifdef TARGET_NR_dup > > -{ TARGET_NR_dup, "dup" , NULL, NULL, NULL }, > > +{ TARGET_NR_dup, "dup" , "%s(%d)", NULL, NULL }, > > #endif > > #ifdef TARGET_NR_dup2 > > -{ TARGET_NR_dup2, "dup2" , NULL, NULL, NULL }, > > +{ TARGET_NR_dup2, "dup2" , "%s(%d,%d)", NULL, NULL }, > > #endif > > #ifdef TARGET_NR_dup3 > > -{ TARGET_NR_dup3, "dup3" , NULL, NULL, NULL }, > > +{ TARGET_NR_dup3, "dup3" , "%s(%d,%d,%d)", NULL, NULL }, > > #endif > > #ifdef TARGET_NR_epoll_create > > { TARGET_NR_epoll_create, "epoll_create" , NULL, NULL, NULL }, > > @@ -191,7 +191,7 @@ > > { TARGET_NR_fanotify_mark, "fanotify_mark" , NULL, NULL, NULL }, > > #endif > > #ifdef TARGET_NR_fchdir > > -{ TARGET_NR_fchdir, "fchdir" , NULL, NULL, NULL }, > > +{ TARGET_NR_fchdir, "fchdir" , "%s(%d)", NULL, NULL }, > > #endif > > #ifdef TARGET_NR_fchmod > > { TARGET_NR_fchmod, "fchmod" , "%s(%d,%#o)", NULL, NULL }, > > @@ -287,7 +287,7 @@ > > { TARGET_NR_getdtablesize, "getdtablesize" , NULL, NULL, NULL }, > > #endif > > #ifdef TARGET_NR_getegid > > -{ TARGET_NR_getegid, "getegid" , NULL, NULL, NULL }, > > +{ TARGET_NR_getegid, "getegid" , "%s()", NULL, NULL }, > > #endif > > #ifdef TARGET_NR_getegid32 > > { TARGET_NR_getegid32, "getegid32" , NULL, NULL, NULL }, > > @@ -299,7 +299,7 @@ > > { TARGET_NR_geteuid32, "geteuid32" , NULL, NULL, NULL }, > > #endif > > #ifdef TARGET_NR_getgid > > -{ TARGET_NR_getgid, "getgid" , NULL, NULL, NULL }, > > +{ TARGET_NR_getgid, "getgid" , "%s()", NULL, NULL }, > > #endif > > #ifdef TARGET_NR_getgid32 > > { TARGET_NR_getgid32, "getgid32" , NULL, NULL, NULL }, > > @@ -329,10 +329,10 @@ > > { TARGET_NR_getpeername, "getpeername" , NULL, NULL, NULL }, > > #endif > > #ifdef TARGET_NR_getpgid > > -{ TARGET_NR_getpgid, "getpgid" , NULL, NULL, NULL }, > > +{ TARGET_NR_getpgid, "getpgid" , "%s(%u)", NULL, NULL }, > > #endif > > #ifdef TARGET_NR_getpgrp > > -{ TARGET_NR_getpgrp, "getpgrp" , NULL, NULL, NULL }, > > +{ TARGET_NR_getpgrp, "getpgrp" , "%s()", NULL, NULL }, > > #endif > > #ifdef TARGET_NR_getpid > > { TARGET_NR_getpid, "getpid" , "%s()", NULL, NULL }, > > @@ -432,7 +432,7 @@ > > { TARGET_NR_io_cancel, "io_cancel" , NULL, NULL, NULL }, > > #endif > > #ifdef TARGET_NR_ioctl > > -{ TARGET_NR_ioctl, "ioctl" , NULL, NULL, NULL }, > > +{ TARGET_NR_ioctl, "ioctl" , "%s(%d,%#x,%#x,%#x,%#x,%#x)", NULL, NULL }, > > #endif > > #ifdef TARGET_NR_io_destroy > > { TARGET_NR_io_destroy, "io_destroy" , NULL, NULL, NULL }, > > @@ -1257,22 +1257,22 @@ > > { TARGET_NR_setdomainname, "setdomainname" , NULL, NULL, NULL }, > > #endif > > #ifdef TARGET_NR_setfsgid > > -{ TARGET_NR_setfsgid, "setfsgid" , NULL, NULL, NULL }, > > +{ TARGET_NR_setfsgid, "setfsgid" , "%s(%u)", NULL, NULL }, > > #endif > > #ifdef TARGET_NR_setfsgid32 > > -{ TARGET_NR_setfsgid32, "setfsgid32" , NULL, NULL, NULL }, > > +{ TARGET_NR_setfsgid32, "setfsgid32" , "%s(%u)" , NULL, NULL }, > > #endif > > #ifdef TARGET_NR_setfsuid > > -{ TARGET_NR_setfsuid, "setfsuid" , NULL, NULL, NULL }, > > +{ TARGET_NR_setfsuid, "setfsuid" , "%s(%u)" , NULL, NULL }, > > #endif > > #ifdef TARGET_NR_setfsuid32 > > { TARGET_NR_setfsuid32, "setfsuid32" , NULL, NULL, NULL }, > > #endif > > #ifdef TARGET_NR_setgid > > -{ TARGET_NR_setgid, "setgid" , NULL, NULL, NULL }, > > +{ TARGET_NR_setgid, "setgid" , "%s(%u)", NULL, NULL }, > > #endif > > #ifdef TARGET_NR_setgid32 > > -{ TARGET_NR_setgid32, "setgid32" , NULL, NULL, NULL }, > > +{ TARGET_NR_setgid32, "setgid32" , "%s(%u)", NULL, NULL }, > > #endif > > #ifdef TARGET_NR_setgroups > > { TARGET_NR_setgroups, "setgroups" , NULL, NULL, NULL }, > > @@ -1296,7 +1296,7 @@ > > { TARGET_NR_setns, "setns" , NULL, NULL, NULL }, > > #endif > > #ifdef TARGET_NR_setpgid > > -{ TARGET_NR_setpgid, "setpgid" , NULL, NULL, NULL }, > > +{ TARGET_NR_setpgid, "setpgid" , "%s(%u,%u)", NULL, NULL }, > > #endif > > #ifdef TARGET_NR_setpgrp > > { TARGET_NR_setpgrp, "setpgrp" , NULL, NULL, NULL }, > > @@ -1311,22 +1311,22 @@ > > { TARGET_NR_setregid32, "setregid32" , NULL, NULL, NULL }, > > #endif > > #ifdef TARGET_NR_setresgid > > -{ TARGET_NR_setresgid, "setresgid" , NULL, NULL, NULL }, > > +{ TARGET_NR_setresgid, "setresgid" , "%s(%u,%u,%u)", NULL, NULL }, > > #endif > > #ifdef TARGET_NR_setresgid32 > > { TARGET_NR_setresgid32, "setresgid32" , NULL, NULL, NULL }, > > #endif > > #ifdef TARGET_NR_setresuid > > -{ TARGET_NR_setresuid, "setresuid" , NULL, NULL, NULL }, > > +{ TARGET_NR_setresuid, "setresuid" , "%s(%u,%u,%u)", NULL, NULL }, > > #endif > > #ifdef TARGET_NR_setresuid32 > > -{ TARGET_NR_setresuid32, "setresuid32" , NULL, NULL, NULL }, > > +{ TARGET_NR_setresuid32, "setresuid32" , "%s(%u,%u,%u)", NULL, NULL }, > > #endif > > #ifdef TARGET_NR_setreuid > > -{ TARGET_NR_setreuid, "setreuid" , NULL, NULL, NULL }, > > +{ TARGET_NR_setreuid, "setreuid" , "%s(%u,%u)", NULL, NULL }, > > #endif > > #ifdef TARGET_NR_setreuid32 > > -{ TARGET_NR_setreuid32, "setreuid32" , NULL, NULL, NULL }, > > +{ TARGET_NR_setreuid32, "setreuid32" , "%s(%u,%u)", NULL, NULL }, > > #endif > > #ifdef TARGET_NR_setrlimit > > { TARGET_NR_setrlimit, "setrlimit" , NULL, NULL, NULL }, > > @@ -1335,7 +1335,7 @@ > > { TARGET_NR_set_robust_list, "set_robust_list" , NULL, NULL, NULL }, > > #endif > > #ifdef TARGET_NR_setsid > > -{ TARGET_NR_setsid, "setsid" , NULL, NULL, NULL }, > > +{ TARGET_NR_setsid, "setsid" , "%s()", NULL, NULL }, > > #endif > > #ifdef TARGET_NR_setsockopt > > { TARGET_NR_setsockopt, "setsockopt" , NULL, NULL, NULL }, > > ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-11-20 21:04 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-11-19 19:04 [PATCH] linux-user/strace: Improve output of various syscalls Helge Deller 2019-11-20 2:35 ` Aleksandar Markovic 2019-11-20 20:44 ` Aleksandar Markovic 2019-11-20 20:57 ` Aleksandar Markovic 2019-11-20 21:02 ` Aleksandar Markovic
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).