* [PATCH 0/3] tools/virtiofsd: Fix warning reported by Clang static code analyzer
@ 2020-02-15 16:07 Philippe Mathieu-Daudé
2020-02-15 16:07 ` [PATCH 1/3] tools/virtiofsd/passthrough_ll: Remove unneeded variable assignment Philippe Mathieu-Daudé
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-02-15 16:07 UTC (permalink / raw)
To: qemu-devel
Cc: Philippe Mathieu-Daudé, Dr. David Alan Gilbert, Stefan Hajnoczi
Philippe Mathieu-Daudé (3):
tools/virtiofsd/passthrough_ll: Remove unneeded variable assignment
tools/virtiofsd/passthrough_ll: Remove unneeded variable assignment
tools/virtiofsd/fuse_lowlevel: Fix fuse_out_header.error value
tools/virtiofsd/fuse_lowlevel.c | 2 +-
tools/virtiofsd/passthrough_ll.c | 6 +-----
2 files changed, 2 insertions(+), 6 deletions(-)
--
2.21.1
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH 1/3] tools/virtiofsd/passthrough_ll: Remove unneeded variable assignment 2020-02-15 16:07 [PATCH 0/3] tools/virtiofsd: Fix warning reported by Clang static code analyzer Philippe Mathieu-Daudé @ 2020-02-15 16:07 ` Philippe Mathieu-Daudé 2020-02-16 21:19 ` Ján Tomko 2020-02-15 16:07 ` [PATCH 2/3] " Philippe Mathieu-Daudé 2020-02-15 16:07 ` [PATCH 3/3] tools/virtiofsd/fuse_lowlevel: Fix fuse_out_header.error value Philippe Mathieu-Daudé 2 siblings, 1 reply; 8+ messages in thread From: Philippe Mathieu-Daudé @ 2020-02-15 16:07 UTC (permalink / raw) To: qemu-devel Cc: Philippe Mathieu-Daudé, Dr. David Alan Gilbert, Stefan Hajnoczi Fix warning reported by Clang static code analyzer: CC tools/virtiofsd/passthrough_ll.o tools/virtiofsd/passthrough_ll.c:1083:5: warning: Value stored to 'saverr' is never read saverr = ENOMEM; ^ ~~~~~~ Fixes: 7c6b66027 Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> --- tools/virtiofsd/passthrough_ll.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/tools/virtiofsd/passthrough_ll.c b/tools/virtiofsd/passthrough_ll.c index c635fc8820..e9e71d5fc2 100644 --- a/tools/virtiofsd/passthrough_ll.c +++ b/tools/virtiofsd/passthrough_ll.c @@ -1080,8 +1080,6 @@ static void lo_mknod_symlink(fuse_req_t req, fuse_ino_t parent, return; } - saverr = ENOMEM; - saverr = lo_change_cred(req, &old); if (saverr) { goto out; -- 2.21.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 1/3] tools/virtiofsd/passthrough_ll: Remove unneeded variable assignment 2020-02-15 16:07 ` [PATCH 1/3] tools/virtiofsd/passthrough_ll: Remove unneeded variable assignment Philippe Mathieu-Daudé @ 2020-02-16 21:19 ` Ján Tomko 0 siblings, 0 replies; 8+ messages in thread From: Ján Tomko @ 2020-02-16 21:19 UTC (permalink / raw) To: Philippe Mathieu-Daudé Cc: qemu-devel, Stefan Hajnoczi, Dr. David Alan Gilbert [-- Attachment #1: Type: text/plain, Size: 578 bytes --] On Sat, Feb 15, 2020 at 05:07:14PM +0100, Philippe Mathieu-Daudé wrote: >Fix warning reported by Clang static code analyzer: > > CC tools/virtiofsd/passthrough_ll.o > tools/virtiofsd/passthrough_ll.c:1083:5: warning: Value stored to 'saverr' is never read > saverr = ENOMEM; > ^ ~~~~~~ > >Fixes: 7c6b66027 >Reported-by: Clang Static Analyzer >Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> >--- > tools/virtiofsd/passthrough_ll.c | 2 -- > 1 file changed, 2 deletions(-) > Reviewed-by: Ján Tomko <jtomko@redhat.com> Jano [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 2/3] tools/virtiofsd/passthrough_ll: Remove unneeded variable assignment 2020-02-15 16:07 [PATCH 0/3] tools/virtiofsd: Fix warning reported by Clang static code analyzer Philippe Mathieu-Daudé 2020-02-15 16:07 ` [PATCH 1/3] tools/virtiofsd/passthrough_ll: Remove unneeded variable assignment Philippe Mathieu-Daudé @ 2020-02-15 16:07 ` Philippe Mathieu-Daudé 2020-02-16 21:23 ` Ján Tomko 2020-02-15 16:07 ` [PATCH 3/3] tools/virtiofsd/fuse_lowlevel: Fix fuse_out_header.error value Philippe Mathieu-Daudé 2 siblings, 1 reply; 8+ messages in thread From: Philippe Mathieu-Daudé @ 2020-02-15 16:07 UTC (permalink / raw) To: qemu-devel Cc: Philippe Mathieu-Daudé, Dr. David Alan Gilbert, Stefan Hajnoczi Fix warning reported by Clang static code analyzer: CC tools/virtiofsd/passthrough_ll.o tools/virtiofsd/passthrough_ll.c:925:9: warning: Value stored to 'newfd' is never read newfd = -1; ^ ~~ tools/virtiofsd/passthrough_ll.c:942:9: warning: Value stored to 'newfd' is never read newfd = -1; ^ ~~ Fixes: 7c6b66027 Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> --- tools/virtiofsd/passthrough_ll.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/tools/virtiofsd/passthrough_ll.c b/tools/virtiofsd/passthrough_ll.c index e9e71d5fc2..b38e0e4d84 100644 --- a/tools/virtiofsd/passthrough_ll.c +++ b/tools/virtiofsd/passthrough_ll.c @@ -922,7 +922,6 @@ static int lo_do_lookup(fuse_req_t req, fuse_ino_t parent, const char *name, inode = lo_find(lo, &e->attr); if (inode) { close(newfd); - newfd = -1; } else { inode = calloc(1, sizeof(struct lo_inode)); if (!inode) { @@ -938,8 +937,7 @@ static int lo_do_lookup(fuse_req_t req, fuse_ino_t parent, const char *name, g_atomic_int_set(&inode->refcount, 2); inode->nlookup = 1; - inode->fd = newfd; - newfd = -1; + inode->fd = -1; inode->key.ino = e->attr.st_ino; inode->key.dev = e->attr.st_dev; pthread_mutex_init(&inode->plock_mutex, NULL); -- 2.21.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 2/3] tools/virtiofsd/passthrough_ll: Remove unneeded variable assignment 2020-02-15 16:07 ` [PATCH 2/3] " Philippe Mathieu-Daudé @ 2020-02-16 21:23 ` Ján Tomko 2020-02-17 9:36 ` Philippe Mathieu-Daudé 0 siblings, 1 reply; 8+ messages in thread From: Ján Tomko @ 2020-02-16 21:23 UTC (permalink / raw) To: Philippe Mathieu-Daudé Cc: qemu-devel, Stefan Hajnoczi, Dr. David Alan Gilbert [-- Attachment #1: Type: text/plain, Size: 1860 bytes --] On Sat, Feb 15, 2020 at 05:07:15PM +0100, Philippe Mathieu-Daudé wrote: >Fix warning reported by Clang static code analyzer: > > CC tools/virtiofsd/passthrough_ll.o > tools/virtiofsd/passthrough_ll.c:925:9: warning: Value stored to 'newfd' is never read > newfd = -1; > ^ ~~ > tools/virtiofsd/passthrough_ll.c:942:9: warning: Value stored to 'newfd' is never read > newfd = -1; > ^ ~~ > >Fixes: 7c6b66027 >Reported-by: Clang Static Analyzer >Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> >--- > tools/virtiofsd/passthrough_ll.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > >diff --git a/tools/virtiofsd/passthrough_ll.c b/tools/virtiofsd/passthrough_ll.c >index e9e71d5fc2..b38e0e4d84 100644 >--- a/tools/virtiofsd/passthrough_ll.c >+++ b/tools/virtiofsd/passthrough_ll.c >@@ -922,7 +922,6 @@ static int lo_do_lookup(fuse_req_t req, fuse_ino_t parent, const char *name, > inode = lo_find(lo, &e->attr); > if (inode) { > close(newfd); >- newfd = -1; > } else { > inode = calloc(1, sizeof(struct lo_inode)); > if (!inode) { >@@ -938,8 +937,7 @@ static int lo_do_lookup(fuse_req_t req, fuse_ino_t parent, const char *name, > g_atomic_int_set(&inode->refcount, 2); > > inode->nlookup = 1; >- inode->fd = newfd; >- newfd = -1; >+ inode->fd = -1; The functional equivalent is: inode->fd = newfd; newfd cannot contain -1 here, as checked a few lines above: newfd = openat(dir->fd, name, O_PATH | O_NOFOLLOW); if (newfd == -1) { goto out_err; } Jano > inode->key.ino = e->attr.st_ino; > inode->key.dev = e->attr.st_dev; > pthread_mutex_init(&inode->plock_mutex, NULL); >-- >2.21.1 > > [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/3] tools/virtiofsd/passthrough_ll: Remove unneeded variable assignment 2020-02-16 21:23 ` Ján Tomko @ 2020-02-17 9:36 ` Philippe Mathieu-Daudé 0 siblings, 0 replies; 8+ messages in thread From: Philippe Mathieu-Daudé @ 2020-02-17 9:36 UTC (permalink / raw) To: Ján Tomko; +Cc: qemu-devel, Stefan Hajnoczi, Dr. David Alan Gilbert On 2/16/20 10:23 PM, Ján Tomko wrote: > On Sat, Feb 15, 2020 at 05:07:15PM +0100, Philippe Mathieu-Daudé wrote: >> Fix warning reported by Clang static code analyzer: >> >> CC tools/virtiofsd/passthrough_ll.o >> tools/virtiofsd/passthrough_ll.c:925:9: warning: Value stored to >> 'newfd' is never read >> newfd = -1; >> ^ ~~ >> tools/virtiofsd/passthrough_ll.c:942:9: warning: Value stored to >> 'newfd' is never read >> newfd = -1; >> ^ ~~ >> >> Fixes: 7c6b66027 >> Reported-by: Clang Static Analyzer >> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> >> --- >> tools/virtiofsd/passthrough_ll.c | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) >> >> diff --git a/tools/virtiofsd/passthrough_ll.c >> b/tools/virtiofsd/passthrough_ll.c >> index e9e71d5fc2..b38e0e4d84 100644 >> --- a/tools/virtiofsd/passthrough_ll.c >> +++ b/tools/virtiofsd/passthrough_ll.c >> @@ -922,7 +922,6 @@ static int lo_do_lookup(fuse_req_t req, fuse_ino_t >> parent, const char *name, >> inode = lo_find(lo, &e->attr); >> if (inode) { >> close(newfd); >> - newfd = -1; >> } else { >> inode = calloc(1, sizeof(struct lo_inode)); >> if (!inode) { >> @@ -938,8 +937,7 @@ static int lo_do_lookup(fuse_req_t req, fuse_ino_t >> parent, const char *name, >> g_atomic_int_set(&inode->refcount, 2); >> >> inode->nlookup = 1; >> - inode->fd = newfd; >> - newfd = -1; >> + inode->fd = -1; > > The functional equivalent is: > inode->fd = newfd; > > newfd cannot contain -1 here, as checked a few lines above: > newfd = openat(dir->fd, name, O_PATH | O_NOFOLLOW); > if (newfd == -1) { > goto out_err; > } Correct. I'll respin, thanks for the review! > Jano > >> inode->key.ino = e->attr.st_ino; >> inode->key.dev = e->attr.st_dev; >> pthread_mutex_init(&inode->plock_mutex, NULL); >> -- >> 2.21.1 >> >> ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 3/3] tools/virtiofsd/fuse_lowlevel: Fix fuse_out_header.error value 2020-02-15 16:07 [PATCH 0/3] tools/virtiofsd: Fix warning reported by Clang static code analyzer Philippe Mathieu-Daudé 2020-02-15 16:07 ` [PATCH 1/3] tools/virtiofsd/passthrough_ll: Remove unneeded variable assignment Philippe Mathieu-Daudé 2020-02-15 16:07 ` [PATCH 2/3] " Philippe Mathieu-Daudé @ 2020-02-15 16:07 ` Philippe Mathieu-Daudé 2020-02-16 21:25 ` Ján Tomko 2 siblings, 1 reply; 8+ messages in thread From: Philippe Mathieu-Daudé @ 2020-02-15 16:07 UTC (permalink / raw) To: qemu-devel Cc: Philippe Mathieu-Daudé, Dr. David Alan Gilbert, Stefan Hajnoczi Fix warning reported by Clang static code analyzer: CC tools/virtiofsd/fuse_lowlevel.o tools/virtiofsd/fuse_lowlevel.c:195:9: warning: Value stored to 'error' is never read error = -ERANGE; ^ ~~~~~~~ Fixes: 2de121f01e Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> --- RFC because untested --- tools/virtiofsd/fuse_lowlevel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virtiofsd/fuse_lowlevel.c b/tools/virtiofsd/fuse_lowlevel.c index 704c0369b2..2dd36ec03b 100644 --- a/tools/virtiofsd/fuse_lowlevel.c +++ b/tools/virtiofsd/fuse_lowlevel.c @@ -192,7 +192,7 @@ int fuse_send_reply_iov_nofree(fuse_req_t req, int error, struct iovec *iov, if (error <= -1000 || error > 0) { fuse_log(FUSE_LOG_ERR, "fuse: bad error value: %i\n", error); - error = -ERANGE; + out.error = -ERANGE; } iov[0].iov_base = &out; -- 2.21.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 3/3] tools/virtiofsd/fuse_lowlevel: Fix fuse_out_header.error value 2020-02-15 16:07 ` [PATCH 3/3] tools/virtiofsd/fuse_lowlevel: Fix fuse_out_header.error value Philippe Mathieu-Daudé @ 2020-02-16 21:25 ` Ján Tomko 0 siblings, 0 replies; 8+ messages in thread From: Ján Tomko @ 2020-02-16 21:25 UTC (permalink / raw) To: Philippe Mathieu-Daudé Cc: qemu-devel, Stefan Hajnoczi, Dr. David Alan Gilbert [-- Attachment #1: Type: text/plain, Size: 626 bytes --] On Sat, Feb 15, 2020 at 05:07:16PM +0100, Philippe Mathieu-Daudé wrote: >Fix warning reported by Clang static code analyzer: > > CC tools/virtiofsd/fuse_lowlevel.o > tools/virtiofsd/fuse_lowlevel.c:195:9: warning: Value stored to 'error' is never read > error = -ERANGE; > ^ ~~~~~~~ > >Fixes: 2de121f01e >Reported-by: Clang Static Analyzer >Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> >--- >RFC because untested >--- > tools/virtiofsd/fuse_lowlevel.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Ján Tomko <jtomko@redhat.com> Jano [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-02-17 9:37 UTC | newest] Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-02-15 16:07 [PATCH 0/3] tools/virtiofsd: Fix warning reported by Clang static code analyzer Philippe Mathieu-Daudé 2020-02-15 16:07 ` [PATCH 1/3] tools/virtiofsd/passthrough_ll: Remove unneeded variable assignment Philippe Mathieu-Daudé 2020-02-16 21:19 ` Ján Tomko 2020-02-15 16:07 ` [PATCH 2/3] " Philippe Mathieu-Daudé 2020-02-16 21:23 ` Ján Tomko 2020-02-17 9:36 ` Philippe Mathieu-Daudé 2020-02-15 16:07 ` [PATCH 3/3] tools/virtiofsd/fuse_lowlevel: Fix fuse_out_header.error value Philippe Mathieu-Daudé 2020-02-16 21:25 ` Ján Tomko
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).