[PATCH] gdbstub: fix compiler complaining

[PATCH] gdbstub: fix compiler complaining

[Denis Plotnikov]

    ./gdbstub.c: In function ‘handle_query_thread_extra’:
        /usr/include/glib-2.0/glib/glib-autocleanups.h:28:10:
    error: ‘cpu_name’ may be used uninitialized in this function
    [-Werror=maybe-uninitialized]
        g_free (*pp);
               ^
    ./gdbstub.c:2063:26: note: ‘cpu_name’ was declared here
        g_autofree char *cpu_name;
                         ^
    cc1: all warnings being treated as errors

Signed-off-by: Denis Plotnikov <dplotnikov@virtuozzo.com>
---
 gdbstub.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gdbstub.c b/gdbstub.c
index 013fb1ac0f..171e150950 100644
--- a/gdbstub.c
+++ b/gdbstub.c
@@ -2060,8 +2060,8 @@ static void handle_query_thread_extra(GdbCmdContext *gdb_ctx, void *user_ctx)
         /* Print the CPU model and name in multiprocess mode */
         ObjectClass *oc = object_get_class(OBJECT(cpu));
         const char *cpu_model = object_class_get_name(oc);
-        g_autofree char *cpu_name;
-        cpu_name  = object_get_canonical_path_component(OBJECT(cpu));
+        g_autofree char *cpu_name =
+            object_get_canonical_path_component(OBJECT(cpu));
         g_string_printf(rs, "%s %s [%s]", cpu_model, cpu_name,
                         cpu->halted ? "halted " : "running");
     } else {
-- 
2.17.0

Re: [PATCH] gdbstub: fix compiler complaining

[Richard Henderson]

On 3/26/20 8:14 AM, Denis Plotnikov wrote:
>     ./gdbstub.c: In function ‘handle_query_thread_extra’:
>         /usr/include/glib-2.0/glib/glib-autocleanups.h:28:10:
>     error: ‘cpu_name’ may be used uninitialized in this function
>     [-Werror=maybe-uninitialized]
>         g_free (*pp);
>                ^
>     ./gdbstub.c:2063:26: note: ‘cpu_name’ was declared here
>         g_autofree char *cpu_name;
>                          ^
>     cc1: all warnings being treated as errors
> 
> Signed-off-by: Denis Plotnikov <dplotnikov@virtuozzo.com>
> ---
>  gdbstub.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~

Re: [PATCH] gdbstub: fix compiler complaining

[Alex Bennée]

Denis Plotnikov <dplotnikov@virtuozzo.com> writes:

>     ./gdbstub.c: In function ‘handle_query_thread_extra’:
>         /usr/include/glib-2.0/glib/glib-autocleanups.h:28:10:
>     error: ‘cpu_name’ may be used uninitialized in this function
>     [-Werror=maybe-uninitialized]
>         g_free (*pp);
>                ^
>     ./gdbstub.c:2063:26: note: ‘cpu_name’ was declared here
>         g_autofree char *cpu_name;
>                          ^
>     cc1: all warnings being treated as errors
>
> Signed-off-by: Denis Plotnikov <dplotnikov@virtuozzo.com>

Queued to for-5.0/random-fixes, thanks.

> ---
>  gdbstub.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gdbstub.c b/gdbstub.c
> index 013fb1ac0f..171e150950 100644
> --- a/gdbstub.c
> +++ b/gdbstub.c
> @@ -2060,8 +2060,8 @@ static void handle_query_thread_extra(GdbCmdContext *gdb_ctx, void *user_ctx)
>          /* Print the CPU model and name in multiprocess mode */
>          ObjectClass *oc = object_get_class(OBJECT(cpu));
>          const char *cpu_model = object_class_get_name(oc);
> -        g_autofree char *cpu_name;
> -        cpu_name  = object_get_canonical_path_component(OBJECT(cpu));
> +        g_autofree char *cpu_name =
> +            object_get_canonical_path_component(OBJECT(cpu));
>          g_string_printf(rs, "%s %s [%s]", cpu_model, cpu_name,
>                          cpu->halted ? "halted " : "running");
>      } else {


-- 
Alex Bennée