qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Dongjiu Geng <gengdongjiu@huawei.com>
To: <imammedo@redhat.com>, <mst@redhat.com>,
	<xiaoguangrong.eric@gmail.com>, <peter.maydell@linaro.org>,
	<shannon.zhaosl@gmail.com>, <fam@euphon.net>, <rth@twiddle.net>,
	<ehabkost@redhat.com>, <mtosatti@redhat.com>,
	<qemu-devel@nongnu.org>, <kvm@vger.kernel.org>,
	<qemu-arm@nongnu.org>, <pbonzini@redhat.com>
Cc: zhengxiang9@huawei.com, Jonathan.Cameron@huawei.com,
	linuxarm@huawei.com, gengdongjiu@huawei.com
Subject: [PATCH v25 02/10] hw/arm/virt: Introduce a RAS machine option
Date: Fri, 10 Apr 2020 19:46:31 +0800	[thread overview]
Message-ID: <20200410114639.32844-3-gengdongjiu@huawei.com> (raw)
In-Reply-To: <20200410114639.32844-1-gengdongjiu@huawei.com>

RAS Virtualization feature is not supported now, so
add a RAS machine option and disable it by default.

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Dongjiu Geng <gengdongjiu@huawei.com>
Signed-off-by: Xiang Zheng <zhengxiang9@huawei.com>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
---
 hw/arm/virt.c         | 23 +++++++++++++++++++++++
 include/hw/arm/virt.h |  1 +
 2 files changed, 24 insertions(+)

diff --git a/hw/arm/virt.c b/hw/arm/virt.c
index 7dc96ab..20409b9 100644
--- a/hw/arm/virt.c
+++ b/hw/arm/virt.c
@@ -1960,6 +1960,20 @@ static void virt_set_acpi(Object *obj, Visitor *v, const char *name,
     visit_type_OnOffAuto(v, name, &vms->acpi, errp);
 }
 
+static bool virt_get_ras(Object *obj, Error **errp)
+{
+    VirtMachineState *vms = VIRT_MACHINE(obj);
+
+    return vms->ras;
+}
+
+static void virt_set_ras(Object *obj, bool value, Error **errp)
+{
+    VirtMachineState *vms = VIRT_MACHINE(obj);
+
+    vms->ras = value;
+}
+
 static char *virt_get_gic_version(Object *obj, Error **errp)
 {
     VirtMachineState *vms = VIRT_MACHINE(obj);
@@ -2284,6 +2298,15 @@ static void virt_instance_init(Object *obj)
                                     "Valid values are none and smmuv3",
                                     NULL);
 
+    /* Default disallows RAS instantiation */
+    vms->ras = false;
+    object_property_add_bool(obj, "ras", virt_get_ras,
+                             virt_set_ras, NULL);
+    object_property_set_description(obj, "ras",
+                                    "Set on/off to enable/disable reporting host memory errors "
+                                    "to a KVM guest using ACPI and guest external abort exceptions",
+                                    NULL);
+
     vms->irqmap = a15irqmap;
 
     virt_flash_create(vms);
diff --git a/include/hw/arm/virt.h b/include/hw/arm/virt.h
index 60b2f52..6401662 100644
--- a/include/hw/arm/virt.h
+++ b/include/hw/arm/virt.h
@@ -131,6 +131,7 @@ typedef struct {
     bool highmem_ecam;
     bool its;
     bool virt;
+    bool ras;
     OnOffAuto acpi;
     VirtGICType gic_version;
     VirtIOMMUType iommu;
-- 
1.8.3.1



  parent reply	other threads:[~2020-04-10 11:47 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-10 11:46 [PATCH v25 00/10] Add ARMv8 RAS virtualization support in QEMU Dongjiu Geng
2020-04-10 11:46 ` [PATCH v25 01/10] acpi: nvdimm: change NVDIMM_UUID_LE to a common macro Dongjiu Geng
2020-04-17 13:15   ` Peter Maydell
2020-04-10 11:46 ` Dongjiu Geng [this message]
2020-05-05 10:23   ` [PATCH v25 02/10] hw/arm/virt: Introduce a RAS machine option Igor Mammedov
2020-04-10 11:46 ` [PATCH v25 03/10] docs: APEI GHES generation and CPER record description Dongjiu Geng
2020-04-10 11:46 ` [PATCH v25 04/10] ACPI: Build related register address fields via hardware error fw_cfg blob Dongjiu Geng
2020-05-06 20:22   ` Michael S. Tsirkin
2020-04-10 11:46 ` [PATCH v25 05/10] ACPI: Build Hardware Error Source Table Dongjiu Geng
2020-05-05 10:29   ` Igor Mammedov
2020-05-06 20:22   ` Michael S. Tsirkin
2020-04-10 11:46 ` [PATCH v25 06/10] ACPI: Record the Generic Error Status Block address Dongjiu Geng
2020-05-05 10:31   ` Igor Mammedov
2020-05-06 20:23   ` Michael S. Tsirkin
2020-04-10 11:46 ` [PATCH v25 07/10] KVM: Move hwpoison page related functions into kvm-all.c Dongjiu Geng
2020-04-10 11:46 ` [PATCH v25 08/10] ACPI: Record Generic Error Status Block(GESB) table Dongjiu Geng
2020-05-05 10:44   ` Igor Mammedov
2020-05-06 11:20     ` gengdongjiu
2020-05-06 20:23   ` Michael S. Tsirkin
2020-04-10 11:46 ` [PATCH v25 09/10] target-arm: kvm64: handle SIGBUS signal from kernel or KVM Dongjiu Geng
2020-05-05 11:23   ` Igor Mammedov
2020-04-10 11:46 ` [PATCH v25 10/10] MAINTAINERS: Add ACPI/HEST/GHES entries Dongjiu Geng
2020-04-16 13:53 ` [PATCH v25 00/10] Add ARMv8 RAS virtualization support in QEMU gengdongjiu
     [not found] ` <5e9863af.1c69fb81.dbe22.5caaSMTPIN_ADDED_BROKEN@mx.google.com>
2020-04-16 14:02   ` Peter Maydell
2020-04-17 13:32 ` Peter Maydell
2020-04-17 13:37   ` gengdongjiu
2020-04-18  2:40   ` gengdongjiu
2020-04-30  3:56   ` gengdongjiu
2020-04-30 12:00     ` Igor Mammedov
2020-05-06 11:42   ` gengdongjiu
2020-05-06 20:25     ` Michael S. Tsirkin
2020-05-07  4:30       ` gengdongjiu
2020-05-07 13:46       ` gengdongjiu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200410114639.32844-3-gengdongjiu@huawei.com \
    --to=gengdongjiu@huawei.com \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=ehabkost@redhat.com \
    --cc=fam@euphon.net \
    --cc=imammedo@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=mst@redhat.com \
    --cc=mtosatti@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=shannon.zhaosl@gmail.com \
    --cc=xiaoguangrong.eric@gmail.com \
    --cc=zhengxiang9@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).