From: Yan Zhao <yan.y.zhao@intel.com>
To: pbonzini@redhat.com, alex.williamson@redhat.com
Cc: Yan Zhao <yan.y.zhao@intel.com>,
xin.zeng@intel.com, philmd@redhat.com, qemu-devel@nongnu.org
Subject: [PATCH v6 1/3] memory: drop guest writes to read-only ram device regions
Date: Thu, 30 Apr 2020 04:09:46 -0400 [thread overview]
Message-ID: <20200430080946.31286-1-yan.y.zhao@intel.com> (raw)
In-Reply-To: <20200430080744.31232-1-yan.y.zhao@intel.com>
for ram device regions, drop guest writes if the region is read-only.
Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Yan Zhao <yan.y.zhao@intel.com>
Signed-off-by: Xin Zeng <xin.zeng@intel.com>
---
memory.c | 15 ++++++++++++---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/memory.c b/memory.c
index 601b749906..a1bba985b9 100644
--- a/memory.c
+++ b/memory.c
@@ -34,6 +34,7 @@
#include "sysemu/accel.h"
#include "hw/boards.h"
#include "migration/vmstate.h"
+#include "qemu/log.h"
//#define DEBUG_UNASSIGNED
@@ -1307,12 +1308,19 @@ static uint64_t memory_region_ram_device_read(void *opaque,
return data;
}
-static void memory_region_ram_device_write(void *opaque, hwaddr addr,
- uint64_t data, unsigned size)
+static MemTxResult memory_region_ram_device_write(void *opaque, hwaddr addr,
+ uint64_t data, unsigned size,
+ MemTxAttrs attrs)
{
MemoryRegion *mr = opaque;
trace_memory_region_ram_device_write(get_cpu_index(), mr, addr, data, size);
+ if (mr->readonly) {
+ qemu_log_mask(LOG_GUEST_ERROR,
+ "Invalid write to read-only ram device region addr 0x%"
+ HWADDR_PRIx" size %u\n", addr, size);
+ return MEMTX_ERROR;
+ }
switch (size) {
case 1:
@@ -1328,11 +1336,12 @@ static void memory_region_ram_device_write(void *opaque, hwaddr addr,
*(uint64_t *)(mr->ram_block->host + addr) = data;
break;
}
+ return MEMTX_OK;
}
static const MemoryRegionOps ram_device_mem_ops = {
.read = memory_region_ram_device_read,
- .write = memory_region_ram_device_write,
+ .write_with_attrs = memory_region_ram_device_write,
.endianness = DEVICE_HOST_ENDIAN,
.valid = {
.min_access_size = 1,
--
2.17.1
next prev parent reply other threads:[~2020-04-30 8:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-30 8:07 [PATCH v6 0/3] drop writes to read-only ram device & vfio regions Yan Zhao
2020-04-30 8:09 ` Yan Zhao [this message]
2020-04-30 9:40 ` [PATCH v6 1/3] memory: drop guest writes to read-only ram device regions Peter Maydell
2020-04-30 10:11 ` Yan Zhao
2020-05-21 14:38 ` Paolo Bonzini
2020-05-25 1:18 ` Yan Zhao
2020-05-25 10:20 ` Paolo Bonzini
2020-05-25 10:54 ` Philippe Mathieu-Daudé
2020-05-25 11:04 ` Paolo Bonzini
2020-05-26 2:11 ` Yan Zhao
2020-05-26 9:14 ` Peter Maydell
2020-05-26 9:26 ` Peter Maydell
2020-05-28 4:35 ` Yan Zhao
2020-05-28 5:10 ` Paolo Bonzini
2020-05-28 6:15 ` Yan Zhao
2020-04-30 8:13 ` [PATCH v6 2/3] hw/vfio: drop guest writes to ro regions Yan Zhao
2020-04-30 8:13 ` [PATCH v6 3/3] hw/vfio: let read-only flag take effect for mmap'd regions Yan Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200430080946.31286-1-yan.y.zhao@intel.com \
--to=yan.y.zhao@intel.com \
--cc=alex.williamson@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=xin.zeng@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).