From: Paolo Bonzini <pbonzini@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Yan Zhao" <yan.y.zhao@intel.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Alex Williamson <alex.williamson@redhat.com>,
xin.zeng@intel.com, QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [PATCH v6 1/3] memory: drop guest writes to read-only ram device regions
Date: Mon, 25 May 2020 13:04:56 +0200 [thread overview]
Message-ID: <f1c43064-7a47-3fb5-8114-ff223ad9f0d3@redhat.com> (raw)
In-Reply-To: <229ec974-1939-31d8-3516-12e7b8fee27f@redhat.com>
On 25/05/20 12:54, Philippe Mathieu-Daudé wrote:
>> Not all of them, only those that need to return MEMTX_ERROR. I would
>> like some guidance from Peter as to whether (or when) reads from ROMs
>> should return MEMTX_ERROR. This way, we can use that information to
>> device what the read-only ram-device regions should do.
> Is it only device-specific or might it be partly arch/machine-specific
> (depending on the bus it is mapped)?
Good point, I think that could be handled by propagating the error up in
the memory region hierarchy (i.e. the cached AddressSpaceDispatch radix
tree is used in the common case, but when you have a failure you
percolate it up through the whole hierarchy since that's not a fast path).
Paolo
next prev parent reply other threads:[~2020-05-25 11:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-30 8:07 [PATCH v6 0/3] drop writes to read-only ram device & vfio regions Yan Zhao
2020-04-30 8:09 ` [PATCH v6 1/3] memory: drop guest writes to read-only ram device regions Yan Zhao
2020-04-30 9:40 ` Peter Maydell
2020-04-30 10:11 ` Yan Zhao
2020-05-21 14:38 ` Paolo Bonzini
2020-05-25 1:18 ` Yan Zhao
2020-05-25 10:20 ` Paolo Bonzini
2020-05-25 10:54 ` Philippe Mathieu-Daudé
2020-05-25 11:04 ` Paolo Bonzini [this message]
2020-05-26 2:11 ` Yan Zhao
2020-05-26 9:14 ` Peter Maydell
2020-05-26 9:26 ` Peter Maydell
2020-05-28 4:35 ` Yan Zhao
2020-05-28 5:10 ` Paolo Bonzini
2020-05-28 6:15 ` Yan Zhao
2020-04-30 8:13 ` [PATCH v6 2/3] hw/vfio: drop guest writes to ro regions Yan Zhao
2020-04-30 8:13 ` [PATCH v6 3/3] hw/vfio: let read-only flag take effect for mmap'd regions Yan Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1c43064-7a47-3fb5-8114-ff223ad9f0d3@redhat.com \
--to=pbonzini@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=xin.zeng@intel.com \
--cc=yan.y.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).