From: Peter Maydell <peter.maydell@linaro.org>
To: Yan Zhao <yan.y.zhao@intel.com>
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Alex Williamson" <alex.williamson@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
xin.zeng@intel.com, "QEMU Developers" <qemu-devel@nongnu.org>
Subject: Re: [PATCH v6 1/3] memory: drop guest writes to read-only ram device regions
Date: Tue, 26 May 2020 10:14:03 +0100 [thread overview]
Message-ID: <CAFEAcA_i7mfuwObvP5HBbvNyRhC0-mbbfJyr7sN14wJXhAZUbw@mail.gmail.com> (raw)
In-Reply-To: <20200526021145.GB698@joy-OptiPlex-7040>
On Tue, 26 May 2020 at 03:21, Yan Zhao <yan.y.zhao@intel.com> wrote:
> so which regions should keep ops->write and which regions should not?
Devices which never need to return a transaction failure
and which never care about transaction attributes can
continue to use ops->write (this is most devices).
It's only if you actually need to be able to say "that
transaction failed" or you need to look at the attributes
that you have to implement write_with_attrs -- there
are a lot fewer of these.
(You could argue for a refactoring where we drop the
old ->read and ->write methods on devices and then
rename read_with_attrs and write_with_attrs to read
and write, but unless we can manage to do it entirely
automatedly it seems like too much effort to me.)
thanks
-- PMM
next prev parent reply other threads:[~2020-05-26 9:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-30 8:07 [PATCH v6 0/3] drop writes to read-only ram device & vfio regions Yan Zhao
2020-04-30 8:09 ` [PATCH v6 1/3] memory: drop guest writes to read-only ram device regions Yan Zhao
2020-04-30 9:40 ` Peter Maydell
2020-04-30 10:11 ` Yan Zhao
2020-05-21 14:38 ` Paolo Bonzini
2020-05-25 1:18 ` Yan Zhao
2020-05-25 10:20 ` Paolo Bonzini
2020-05-25 10:54 ` Philippe Mathieu-Daudé
2020-05-25 11:04 ` Paolo Bonzini
2020-05-26 2:11 ` Yan Zhao
2020-05-26 9:14 ` Peter Maydell [this message]
2020-05-26 9:26 ` Peter Maydell
2020-05-28 4:35 ` Yan Zhao
2020-05-28 5:10 ` Paolo Bonzini
2020-05-28 6:15 ` Yan Zhao
2020-04-30 8:13 ` [PATCH v6 2/3] hw/vfio: drop guest writes to ro regions Yan Zhao
2020-04-30 8:13 ` [PATCH v6 3/3] hw/vfio: let read-only flag take effect for mmap'd regions Yan Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA_i7mfuwObvP5HBbvNyRhC0-mbbfJyr7sN14wJXhAZUbw@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=alex.williamson@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=xin.zeng@intel.com \
--cc=yan.y.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).