From: Cornelia Huck <cohuck@redhat.com>
To: Janosch Frank <frankja@linux.ibm.com>
Cc: Thomas Huth <thuth@redhat.com>,
borntraeger@de.ibm.com, qemu-s390x@nongnu.org,
qemu-devel@nongnu.org, david@redhat.com
Subject: Re: [PATCH v2 0/9] pc-bios: s390x: Cleanup part 1
Date: Wed, 20 May 2020 13:52:10 +0200 [thread overview]
Message-ID: <20200520135210.1b8f0d22.cohuck@redhat.com> (raw)
In-Reply-To: <20200514123729.156283-1-frankja@linux.ibm.com>
On Thu, 14 May 2020 08:37:20 -0400
Janosch Frank <frankja@linux.ibm.com> wrote:
> The bios is in dire need for a cleanup as there are still a lot of
> magic constants being used throughout as well as duplicated code.
>
> In the first part of this series we consolidate constants and
> functions, as well as doing some minor cleanups and fixes.
>
> The patches are available here:
> https://github.com/frankjaa/qemu/pull/new/cleanup_bios
>
> v2:
> * Included cio fixup to get rid of compile errors...
> * Minor cosmetic fixes found by review
>
> Janosch Frank (9):
> pc-bios: s390x: cio.c cleanup and compile fix
> pc-bios: s390x: Consolidate timing functions into time.h
> pc-bios: s390x: Get rid of magic offsets into the lowcore
> pc-bios: s390x: Rename and use PSW_MASK_ZMODE constant
> pc-bios: s390x: Use PSW masks where possible
> pc-bios: s390x: Move panic() into header and add infinite loop
> pc-bios: s390x: Use ebcdic2ascii table
> pc-bios: s390x: Replace 0x00 with 0x0 or 0
> pc-bios: s390x: Make u32 ptr check explicit
>
> pc-bios/s390-ccw/bootmap.c | 4 +---
> pc-bios/s390-ccw/cio.c | 36 +++++++++++++++----------------
> pc-bios/s390-ccw/cio.h | 17 +++++++++------
> pc-bios/s390-ccw/dasd-ipl.c | 17 +++++++--------
> pc-bios/s390-ccw/helper.h | 2 +-
> pc-bios/s390-ccw/jump2ipl.c | 10 ++++-----
> pc-bios/s390-ccw/main.c | 15 +++----------
> pc-bios/s390-ccw/menu.c | 1 +
> pc-bios/s390-ccw/netmain.c | 23 +++-----------------
> pc-bios/s390-ccw/s390-arch.h | 4 +++-
> pc-bios/s390-ccw/s390-ccw.h | 27 ++++++-----------------
> pc-bios/s390-ccw/start.S | 5 +++--
> pc-bios/s390-ccw/time.h | 39 ++++++++++++++++++++++++++++++++++
> pc-bios/s390-ccw/virtio-net.c | 1 +
> pc-bios/s390-ccw/virtio-scsi.c | 1 +
> pc-bios/s390-ccw/virtio.c | 18 +++-------------
> 16 files changed, 107 insertions(+), 113 deletions(-)
> create mode 100644 pc-bios/s390-ccw/time.h
>
I assume Christian/Thomas will pick that one up once the last wrinkles
have been ironed out?
prev parent reply other threads:[~2020-05-20 11:53 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-14 12:37 [PATCH v2 0/9] pc-bios: s390x: Cleanup part 1 Janosch Frank
2020-05-14 12:37 ` [PATCH v2 1/9] pc-bios: s390x: cio.c cleanup and compile fix Janosch Frank
2020-05-18 11:52 ` David Hildenbrand
2020-05-18 12:02 ` Janosch Frank
2020-05-20 19:37 ` Thomas Huth
2020-05-14 12:37 ` [PATCH v2 2/9] pc-bios: s390x: Consolidate timing functions into time.h Janosch Frank
2020-05-18 12:01 ` David Hildenbrand
2020-05-18 12:09 ` Janosch Frank
2020-05-18 12:45 ` David Hildenbrand
2020-05-20 19:53 ` Thomas Huth
2020-05-25 12:20 ` Janosch Frank
2020-05-14 12:37 ` [PATCH v2 3/9] pc-bios: s390x: Get rid of magic offsets into the lowcore Janosch Frank
2020-05-18 12:46 ` David Hildenbrand
2020-05-20 19:57 ` Thomas Huth
2020-05-14 12:37 ` [PATCH v2 4/9] pc-bios: s390x: Rename and use PSW_MASK_ZMODE constant Janosch Frank
2020-05-21 5:44 ` Thomas Huth
2020-05-21 5:47 ` Thomas Huth
2020-05-25 12:03 ` Janosch Frank
2020-05-14 12:37 ` [PATCH v2 5/9] pc-bios: s390x: Use PSW masks where possible Janosch Frank
2020-05-21 5:50 ` Thomas Huth
2020-05-25 12:08 ` Janosch Frank
2020-05-14 12:37 ` [PATCH v2 6/9] pc-bios: s390x: Move panic() into header and add infinite loop Janosch Frank
2020-05-21 5:53 ` Thomas Huth
2020-05-14 12:37 ` [PATCH v2 7/9] pc-bios: s390x: Use ebcdic2ascii table Janosch Frank
2020-05-21 5:56 ` Thomas Huth
2020-05-14 12:37 ` [PATCH v2 8/9] pc-bios: s390x: Replace 0x00 with 0x0 or 0 Janosch Frank
2020-05-18 12:47 ` David Hildenbrand
2020-05-21 6:01 ` Thomas Huth
2020-05-14 12:37 ` [PATCH v2 9/9] pc-bios: s390x: Make u32 ptr check explicit Janosch Frank
2020-05-21 6:03 ` Thomas Huth
2020-05-14 18:43 ` [PATCH v2 0/9] pc-bios: s390x: Cleanup part 1 no-reply
2020-05-20 11:52 ` Cornelia Huck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200520135210.1b8f0d22.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).