From: Thomas Huth <thuth@redhat.com>
To: Janosch Frank <frankja@linux.ibm.com>, qemu-devel@nongnu.org
Cc: "Jason J . Herne" <jjherne@linux.ibm.com>,
borntraeger@de.ibm.com, qemu-s390x@nongnu.org, cohuck@redhat.com,
david@redhat.com
Subject: Re: [PATCH v2 8/9] pc-bios: s390x: Replace 0x00 with 0x0 or 0
Date: Thu, 21 May 2020 08:01:42 +0200 [thread overview]
Message-ID: <f8732927-1f5c-b985-d89a-5014556f3eef@redhat.com> (raw)
In-Reply-To: <20200514123729.156283-9-frankja@linux.ibm.com>
On 14/05/2020 14.37, Janosch Frank wrote:
> 0x00 looks odd, time to replace it with 0 or 0x0 (for pointers).
>
> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
> ---
> pc-bios/s390-ccw/dasd-ipl.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/pc-bios/s390-ccw/dasd-ipl.c b/pc-bios/s390-ccw/dasd-ipl.c
> index b932531e6f..764ee89e92 100644
> --- a/pc-bios/s390-ccw/dasd-ipl.c
> +++ b/pc-bios/s390-ccw/dasd-ipl.c
> @@ -98,18 +98,18 @@ static int run_dynamic_ccw_program(SubChannelId schid, uint16_t cutype,
>
> static void make_readipl(void)
> {
> - Ccw0 *ccwIplRead = (Ccw0 *)0x00;
> + Ccw0 *ccwIplRead = (Ccw0 *)0x0;
>
> /* Create Read IPL ccw at address 0 */
> ccwIplRead->cmd_code = CCW_CMD_READ_IPL;
> - ccwIplRead->cda = 0x00; /* Read into address 0x00 in main memory */
> + ccwIplRead->cda = 0x0; /* Read into address 0x00 in main memory */
> ccwIplRead->chain = 0; /* Chain flag */
> ccwIplRead->count = 0x18; /* Read 0x18 bytes of data */
> }
>
> static void run_readipl(SubChannelId schid, uint16_t cutype)
> {
> - if (do_cio(schid, cutype, 0x00, CCW_FMT0)) {
> + if (do_cio(schid, cutype, 0x0, CCW_FMT0)) {
> panic("dasd-ipl: Failed to run Read IPL channel program\n");
> }
> }
> @@ -133,10 +133,10 @@ static void check_ipl2(uint32_t ipl2_addr)
> {
> Ccw0 *ccw = u32toptr(ipl2_addr);
>
> - if (ipl2_addr == 0x00) {
> + if (ipl2_addr == 0) {
> panic("IPL2 address invalid. Is this disk really bootable?\n");
> }
> - if (ccw->cmd_code == 0x00) {
> + if (ccw->cmd_code == 0) {
> panic("IPL2 ccw data invalid. Is this disk really bootable?\n");
> }
> }
> @@ -161,7 +161,7 @@ static void ipl1_fixup(void)
> memcpy(ccwRead, (void *)0x08, 16);
>
> /* Disable chaining so we don't TIC to IPL2 channel program */
> - ccwRead->chain = 0x00;
> + ccwRead->chain = 0;
>
> ccwSeek->cmd_code = CCW_CMD_DASD_SEEK;
> ccwSeek->cda = ptr2u32(seekData);
> @@ -206,7 +206,7 @@ static void run_ipl2(SubChannelId schid, uint16_t cutype, uint32_t addr)
> */
> void dasd_ipl(SubChannelId schid, uint16_t cutype)
> {
> - PSWLegacy *pswl = (PSWLegacy *) 0x00;
> + PSWLegacy *pswl = (PSWLegacy *) 0x0;
> uint32_t ipl2_addr;
>
> /* Construct Read IPL CCW and run it to read IPL1 from boot disk */
>
Not sure whether this is really worth the churn ... but in case you insist:
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2020-05-21 6:02 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-14 12:37 [PATCH v2 0/9] pc-bios: s390x: Cleanup part 1 Janosch Frank
2020-05-14 12:37 ` [PATCH v2 1/9] pc-bios: s390x: cio.c cleanup and compile fix Janosch Frank
2020-05-18 11:52 ` David Hildenbrand
2020-05-18 12:02 ` Janosch Frank
2020-05-20 19:37 ` Thomas Huth
2020-05-14 12:37 ` [PATCH v2 2/9] pc-bios: s390x: Consolidate timing functions into time.h Janosch Frank
2020-05-18 12:01 ` David Hildenbrand
2020-05-18 12:09 ` Janosch Frank
2020-05-18 12:45 ` David Hildenbrand
2020-05-20 19:53 ` Thomas Huth
2020-05-25 12:20 ` Janosch Frank
2020-05-14 12:37 ` [PATCH v2 3/9] pc-bios: s390x: Get rid of magic offsets into the lowcore Janosch Frank
2020-05-18 12:46 ` David Hildenbrand
2020-05-20 19:57 ` Thomas Huth
2020-05-14 12:37 ` [PATCH v2 4/9] pc-bios: s390x: Rename and use PSW_MASK_ZMODE constant Janosch Frank
2020-05-21 5:44 ` Thomas Huth
2020-05-21 5:47 ` Thomas Huth
2020-05-25 12:03 ` Janosch Frank
2020-05-14 12:37 ` [PATCH v2 5/9] pc-bios: s390x: Use PSW masks where possible Janosch Frank
2020-05-21 5:50 ` Thomas Huth
2020-05-25 12:08 ` Janosch Frank
2020-05-14 12:37 ` [PATCH v2 6/9] pc-bios: s390x: Move panic() into header and add infinite loop Janosch Frank
2020-05-21 5:53 ` Thomas Huth
2020-05-14 12:37 ` [PATCH v2 7/9] pc-bios: s390x: Use ebcdic2ascii table Janosch Frank
2020-05-21 5:56 ` Thomas Huth
2020-05-14 12:37 ` [PATCH v2 8/9] pc-bios: s390x: Replace 0x00 with 0x0 or 0 Janosch Frank
2020-05-18 12:47 ` David Hildenbrand
2020-05-21 6:01 ` Thomas Huth [this message]
2020-05-14 12:37 ` [PATCH v2 9/9] pc-bios: s390x: Make u32 ptr check explicit Janosch Frank
2020-05-21 6:03 ` Thomas Huth
2020-05-14 18:43 ` [PATCH v2 0/9] pc-bios: s390x: Cleanup part 1 no-reply
2020-05-20 11:52 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8732927-1f5c-b985-d89a-5014556f3eef@redhat.com \
--to=thuth@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=jjherne@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).