From: Cornelia Huck <cohuck@redhat.com>
To: Claudio Fontana <cfontana@suse.de>
Cc: "Laurent Vivier" <lvivier@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Thomas Huth" <thuth@redhat.com>,
"Jason J. Herne" <jjherne@linux.ibm.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Marcelo Tosatti" <mtosatti@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
qemu-devel@nongnu.org, "Roman Bolshakov" <r.bolshakov@yadro.com>,
"Wenchao Wang" <wenchao.wang@intel.com>,
haxm-team@intel.com, "Colin Xu" <colin.xu@intel.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Sunil Muthuswamy" <sunilmut@microsoft.com>,
"Richard Henderson" <rth@twiddle.net>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Eduardo Habkost" <ehabkost@redhat.com>
Subject: Re: [PATCH 3/3] cpu-timers, icount: new modules
Date: Mon, 13 Jul 2020 12:46:04 +0200 [thread overview]
Message-ID: <20200713124604.5fcc8282.cohuck@redhat.com> (raw)
In-Reply-To: <eb8e29c7-4cb5-8273-1c94-e62ea9e06485@suse.de>
On Fri, 10 Jul 2020 21:20:08 +0200
Claudio Fontana <cfontana@suse.de> wrote:
> >>> In short this goes away if I again set icount to enabled for qtest,
> >>> basically ensuring that --enable-tcg is there and then reenabling icount.
> >>>
> >>> qtest was forcing icount and shift=0 by creating qemu options, in order to misuse its counter feature,
> >>> instead of using a separate counter.
> >>>
> >>> Removing that ugliness we end up with different behavior of save/load, because vmstate will now suddenly not contain icount-related values anymore.
> >>> What I do not understand is why this causes a problem because save should just not store the icount state and load should just not load the icount state,
> >>> and why we die on the load of s390 keys state (it works just fine for other architectures).
> >
> > Yes, I don't really see why skeys is so special. No endianness stuff, I
> > assume?
>
>
> No, does not seem to be the issue.
Hm, had been worth a thought.
>
> I discovered a way simpler way to "fix" it:
>
> static bool icount_state_needed(void *opaque)
> {
> return 1;
> }
>
> Ie, making sure that the state is always saved/restored, even when unused.
>
> Really weird.
>
> I logged/debugged the vmstate code, and I can see that things seem symmetric between save and load when it comes to timers.
>
> something puts 0s into the key somehow...
Maybe writing one 0 to many?
next prev parent reply other threads:[~2020-07-13 10:47 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-29 9:35 [PATCH 0/3] QEMU cpus.c refactoring part1 Claudio Fontana
2020-06-29 9:35 ` [PATCH 1/3] softmmu: move softmmu only files from root Claudio Fontana
2020-07-03 17:21 ` Paolo Bonzini
2020-06-29 9:35 ` [PATCH 2/3] cpu-throttle: new module, extracted from cpus.c Claudio Fontana
2020-06-29 9:35 ` [PATCH 3/3] cpu-timers, icount: new modules Claudio Fontana
2020-07-08 14:34 ` Paolo Bonzini
2020-07-08 15:00 ` Claudio Fontana
2020-07-08 15:05 ` Paolo Bonzini
2020-07-08 15:07 ` Thomas Huth
2020-07-08 15:12 ` Paolo Bonzini
2020-07-08 15:15 ` Claudio Fontana
2020-07-08 15:15 ` Thomas Huth
2020-07-08 15:17 ` Claudio Fontana
2020-07-08 15:23 ` Paolo Bonzini
2020-07-08 15:30 ` Claudio Fontana
2020-07-09 18:38 ` Claudio Fontana
2020-07-09 18:46 ` Claudio Fontana
2020-07-10 6:33 ` Cornelia Huck
2020-07-10 19:20 ` Claudio Fontana
2020-07-13 10:46 ` Cornelia Huck [this message]
2020-07-11 11:40 ` Claudio Fontana
2020-07-13 10:51 ` Cornelia Huck
2020-07-13 11:27 ` Claudio Fontana
2020-07-10 4:36 ` Thomas Huth
2020-07-10 22:45 ` Paolo Bonzini
2020-07-11 9:14 ` Claudio Fontana
2020-07-11 9:39 ` Paolo Bonzini
2020-07-11 11:49 ` Claudio Fontana
2020-07-11 12:19 ` Paolo Bonzini
2020-07-11 12:48 ` Claudio Fontana
2020-07-29 8:48 ` Claudio Fontana
2020-07-29 10:01 ` Paolo Bonzini
2020-07-30 16:33 ` Claudio Fontana
2020-07-30 22:09 ` Paolo Bonzini
2020-07-31 10:59 ` Claudio Fontana
2020-07-02 6:27 ` [PATCH 0/3] QEMU cpus.c refactoring part1 Claudio Fontana
2020-07-03 17:21 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200713124604.5fcc8282.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=armbru@redhat.com \
--cc=cfontana@suse.de \
--cc=colin.xu@intel.com \
--cc=ehabkost@redhat.com \
--cc=haxm-team@intel.com \
--cc=jjherne@linux.ibm.com \
--cc=lvivier@redhat.com \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=r.bolshakov@yadro.com \
--cc=rth@twiddle.net \
--cc=sunilmut@microsoft.com \
--cc=thuth@redhat.com \
--cc=wenchao.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).