[PATCH for-5.1] hw: Only compile the usb-dwc2 controller if it is really needed

[PATCH for-5.1] hw: Only compile the usb-dwc2 controller if it is really needed

[Thomas Huth]

The USB_DWC2 switch is currently "default y", so it is included in all
qemu-system-* builds, even if it is not needed. Even worse, it does a
"select USB", so USB devices are now showing up as available on targets
that do not support USB at all. This sysbus device should only be
included by the boards that need it, i.e. by the Raspi machines.

Fixes: 153ef1662c ("dwc-hsotg (dwc2) USB host controller emulation")
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 hw/arm/Kconfig | 1 +
 hw/usb/Kconfig | 1 -
 2 files changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig
index 4a224a6351..bc3a423940 100644
--- a/hw/arm/Kconfig
+++ b/hw/arm/Kconfig
@@ -315,6 +315,7 @@ config RASPI
     select FRAMEBUFFER
     select PL011 # UART
     select SDHCI
+    select USB_DWC2
 
 config STM32F205_SOC
     bool
diff --git a/hw/usb/Kconfig b/hw/usb/Kconfig
index d4d8c37c28..5e63dc75f8 100644
--- a/hw/usb/Kconfig
+++ b/hw/usb/Kconfig
@@ -48,7 +48,6 @@ config USB_MUSB
 
 config USB_DWC2
     bool
-    default y
     select USB
 
 config TUSB6010
-- 
2.18.1

Re: [PATCH for-5.1] hw: Only compile the usb-dwc2 controller if it is really needed

[Philippe Mathieu-Daudé]

On 7/22/20 5:47 PM, Thomas Huth wrote:
> The USB_DWC2 switch is currently "default y", so it is included in all
> qemu-system-* builds, even if it is not needed. Even worse, it does a
> "select USB", so USB devices are now showing up as available on targets
> that do not support USB at all. This sysbus device should only be
> included by the boards that need it, i.e. by the Raspi machines.

Paul already sent that patch (your description is better although):
https://www.mail-archive.com/qemu-devel@nongnu.org/msg723681.html

> 
> Fixes: 153ef1662c ("dwc-hsotg (dwc2) USB host controller emulation")
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  hw/arm/Kconfig | 1 +
>  hw/usb/Kconfig | 1 -
>  2 files changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig
> index 4a224a6351..bc3a423940 100644
> --- a/hw/arm/Kconfig
> +++ b/hw/arm/Kconfig
> @@ -315,6 +315,7 @@ config RASPI
>      select FRAMEBUFFER
>      select PL011 # UART
>      select SDHCI
> +    select USB_DWC2
>  
>  config STM32F205_SOC
>      bool
> diff --git a/hw/usb/Kconfig b/hw/usb/Kconfig
> index d4d8c37c28..5e63dc75f8 100644
> --- a/hw/usb/Kconfig
> +++ b/hw/usb/Kconfig
> @@ -48,7 +48,6 @@ config USB_MUSB
>  
>  config USB_DWC2
>      bool
> -    default y
>      select USB
>  
>  config TUSB6010
> 

Re: [PATCH for-5.1] hw: Only compile the usb-dwc2 controller if it is really needed

[Thomas Huth]

On 22/07/2020 19.23, Philippe Mathieu-Daudé wrote:
> On 7/22/20 5:47 PM, Thomas Huth wrote:
>> The USB_DWC2 switch is currently "default y", so it is included in all
>> qemu-system-* builds, even if it is not needed. Even worse, it does a
>> "select USB", so USB devices are now showing up as available on targets
>> that do not support USB at all. This sysbus device should only be
>> included by the boards that need it, i.e. by the Raspi machines.
> 
> Paul already sent that patch (your description is better although):
> https://www.mail-archive.com/qemu-devel@nongnu.org/msg723681.html

Oh, thanks for the pointer, I should have checked my qemu-devel folder
first... Please disregard my patch!

 Thomas

Re: [PATCH for-5.1] hw: Only compile the usb-dwc2 controller if it is really needed

[Paul Zimmerman]

[-- Attachment #1: Type: text/plain, Size: 1003 bytes --]

Gerd, it's OK by me if you take Thomas's patch instead, I agree the
changelog is better. It also has a fixes tag.

Reviewed-by: Paul Zimmerman <pauldzim@gmail.com>


On Wed, Jul 22, 2020 at 9:29 PM Thomas Huth <thuth@redhat.com> wrote:

> On 22/07/2020 19.23, Philippe Mathieu-Daudé wrote:
> > On 7/22/20 5:47 PM, Thomas Huth wrote:
> >> The USB_DWC2 switch is currently "default y", so it is included in all
> >> qemu-system-* builds, even if it is not needed. Even worse, it does a
> >> "select USB", so USB devices are now showing up as available on targets
> >> that do not support USB at all. This sysbus device should only be
> >> included by the boards that need it, i.e. by the Raspi machines.
> >
> > Paul already sent that patch (your description is better although):
> > https://www.mail-archive.com/qemu-devel@nongnu.org/msg723681.html
>
> Oh, thanks for the pointer, I should have checked my qemu-devel folder
> first... Please disregard my patch!
>
>  Thomas
>
>

[-- Attachment #2: Type: text/html, Size: 1853 bytes --]

Re: [PATCH for-5.1] hw: Only compile the usb-dwc2 controller if it is really needed

[Gerd Hoffmann]

On Wed, Jul 22, 2020 at 09:36:27PM -0700, Paul Zimmerman wrote:
> Gerd, it's OK by me if you take Thomas's patch instead, I agree the
> changelog is better. It also has a fixes tag.
> 
> Reviewed-by: Paul Zimmerman <pauldzim@gmail.com>

Queued.  Thanks,
  Gerd