From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: qemu-devel@nongnu.org
Cc: "Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: [PATCH 4/6] hw/pci-host/sabre: Report unimplemented accesses via UNIMP log_mask
Date: Mon, 12 Oct 2020 19:09:48 +0200 [thread overview]
Message-ID: <20201012170950.3491912-5-f4bug@amsat.org> (raw)
In-Reply-To: <20201012170950.3491912-1-f4bug@amsat.org>
Report unimplemented register accesses using qemu_log_mask(UNIMP).
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
hw/pci-host/sabre.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/hw/pci-host/sabre.c b/hw/pci-host/sabre.c
index 3645bc962cb..4412e23131c 100644
--- a/hw/pci-host/sabre.c
+++ b/hw/pci-host/sabre.c
@@ -121,8 +121,10 @@ static void sabre_config_write(void *opaque, hwaddr addr,
trace_sabre_config_write(addr, val);
switch (addr) {
- case 0x30 ... 0x4f: /* DMA error registers */
- /* XXX: not implemented yet */
+ case 0x30 ... 0x4f: /* DMA error registers */
+ qemu_log_mask(LOG_UNIMP,
+ "%s: Register 0x%02" HWADDR_PRIX " not implemented\n",
+ __func__, addr);
break;
case 0xc00 ... 0xc3f: /* PCI interrupt control */
if (addr & 4) {
@@ -198,8 +200,10 @@ static uint64_t sabre_config_read(void *opaque,
uint32_t val = 0;
switch (addr) {
- case 0x30 ... 0x4f: /* DMA error registers */
- /* XXX: not implemented yet */
+ case 0x30 ... 0x4f: /* DMA error registers */
+ qemu_log_mask(LOG_UNIMP,
+ "%s: Register 0x%02" HWADDR_PRIX " not implemented\n",
+ __func__, addr);
break;
case 0xc00 ... 0xc3f: /* PCI interrupt control */
if (addr & 4) {
--
2.26.2
next prev parent reply other threads:[~2020-10-12 17:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-12 17:09 [PATCH 0/6] hw/pci-host/sabre: Report UNIMP/GUEST_ERROR accesses Philippe Mathieu-Daudé
2020-10-12 17:09 ` [PATCH 1/6] hw/pci-host/sabre: Update documentation link Philippe Mathieu-Daudé
2020-10-19 19:01 ` Mark Cave-Ayland
2020-10-12 17:09 ` [PATCH 2/6] hw/pci-host/sabre: Remove superfluous address range check Philippe Mathieu-Daudé
2020-10-19 19:02 ` Mark Cave-Ayland
2020-10-12 17:09 ` [PATCH 3/6] hw/pci-host/sabre: Simplify code initializing variable once Philippe Mathieu-Daudé
2020-10-19 19:06 ` Mark Cave-Ayland
2020-10-12 17:09 ` Philippe Mathieu-Daudé [this message]
2020-10-19 21:52 ` [PATCH 4/6] hw/pci-host/sabre: Report unimplemented accesses via UNIMP log_mask Mark Cave-Ayland
2020-10-12 17:09 ` [PATCH 5/6] hw/pci-host/sabre: Report IOMMU address range as unimplemented Philippe Mathieu-Daudé
2020-10-19 21:57 ` Mark Cave-Ayland
2020-10-12 17:09 ` [PATCH 6/6] hw/pci-host/sabre: Log reserved address accesses as GUEST_ERROR Philippe Mathieu-Daudé
2020-10-19 21:58 ` Mark Cave-Ayland
2020-10-19 22:01 ` [PATCH 0/6] hw/pci-host/sabre: Report UNIMP/GUEST_ERROR accesses Mark Cave-Ayland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201012170950.3491912-5-f4bug@amsat.org \
--to=f4bug@amsat.org \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).