From: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, qemu-devel@nongnu.org
Subject: Re: [PATCH 6/6] hw/pci-host/sabre: Log reserved address accesses as GUEST_ERROR
Date: Mon, 19 Oct 2020 22:58:57 +0100 [thread overview]
Message-ID: <e2216f5f-f7b2-e2d8-876d-d94c5668cc45@ilande.co.uk> (raw)
In-Reply-To: <20201012170950.3491912-7-f4bug@amsat.org>
On 12/10/2020 18:09, Philippe Mathieu-Daudé wrote:
> Report accesses to reserved registers using qemu_log_mask(GUEST_ERROR).
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> hw/pci-host/sabre.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/hw/pci-host/sabre.c b/hw/pci-host/sabre.c
> index 67699ac9058..cc97c266a57 100644
> --- a/hw/pci-host/sabre.c
> +++ b/hw/pci-host/sabre.c
> @@ -189,7 +189,11 @@ static void sabre_config_write(void *opaque, hwaddr addr,
> case 0xa800 ... 0xa80f: /* Interrupt diagnostics */
> case 0xf000 ... 0xf01f: /* FFB config, memory control */
> /* we don't care */
> + break;
> default:
> + qemu_log_mask(LOG_GUEST_ERROR,
> + "%s: Register 0x%04" HWADDR_PRIX " is reserved\n",
> + __func__, addr);
> break;
> }
> }
> @@ -235,7 +239,11 @@ static uint64_t sabre_config_read(void *opaque,
> case 0xa800 ... 0xa80f: /* Interrupt diagnostics */
> case 0xf000 ... 0xf01f: /* FFB config, memory control */
> /* we don't care */
> + break;
> default:
> + qemu_log_mask(LOG_GUEST_ERROR,
> + "%s: Register 0x%04" HWADDR_PRIX " is reserved\n",
> + __func__, addr);
> break;
> }
> trace_sabre_config_read(addr, val);
As per my comment on patch 4, I think these should be logged at LOG_UNIMP and the
message changed to "is unimplemented". Other than that:
Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
ATB,
Mark.
next prev parent reply other threads:[~2020-10-19 22:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-12 17:09 [PATCH 0/6] hw/pci-host/sabre: Report UNIMP/GUEST_ERROR accesses Philippe Mathieu-Daudé
2020-10-12 17:09 ` [PATCH 1/6] hw/pci-host/sabre: Update documentation link Philippe Mathieu-Daudé
2020-10-19 19:01 ` Mark Cave-Ayland
2020-10-12 17:09 ` [PATCH 2/6] hw/pci-host/sabre: Remove superfluous address range check Philippe Mathieu-Daudé
2020-10-19 19:02 ` Mark Cave-Ayland
2020-10-12 17:09 ` [PATCH 3/6] hw/pci-host/sabre: Simplify code initializing variable once Philippe Mathieu-Daudé
2020-10-19 19:06 ` Mark Cave-Ayland
2020-10-12 17:09 ` [PATCH 4/6] hw/pci-host/sabre: Report unimplemented accesses via UNIMP log_mask Philippe Mathieu-Daudé
2020-10-19 21:52 ` Mark Cave-Ayland
2020-10-12 17:09 ` [PATCH 5/6] hw/pci-host/sabre: Report IOMMU address range as unimplemented Philippe Mathieu-Daudé
2020-10-19 21:57 ` Mark Cave-Ayland
2020-10-12 17:09 ` [PATCH 6/6] hw/pci-host/sabre: Log reserved address accesses as GUEST_ERROR Philippe Mathieu-Daudé
2020-10-19 21:58 ` Mark Cave-Ayland [this message]
2020-10-19 22:01 ` [PATCH 0/6] hw/pci-host/sabre: Report UNIMP/GUEST_ERROR accesses Mark Cave-Ayland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2216f5f-f7b2-e2d8-876d-d94c5668cc45@ilande.co.uk \
--to=mark.cave-ayland@ilande.co.uk \
--cc=f4bug@amsat.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).