From: Keith Busch <kbusch@kernel.org>
To: Klaus Jensen <its@irrelevant.dk>
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"Niklas Cassel" <Niklas.Cassel@wdc.com>,
qemu-block@nongnu.org, "Klaus Jensen" <k.jensen@samsung.com>,
qemu-devel@nongnu.org,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: Re: [PATCH 0/9] nvme qemu cleanups and fixes
Date: Tue, 13 Oct 2020 10:48:26 -0700 [thread overview]
Message-ID: <20201013174826.GA1049145@dhcp-10-100-145-180.wdl.wdc.com> (raw)
In-Reply-To: <20201013090401.GC168093@apples.localdomain>
On Tue, Oct 13, 2020 at 11:04:01AM +0200, Klaus Jensen wrote:
> On Sep 30 15:04, Keith Busch wrote:
> > After going through the zns enabling, I notice the controller enabling
> > is not correct. Then I just continued maked more stuff. The series, I
> > think, contains some of the less controversial patches from the two
> > conflicting zns series, preceeded by some cleanups and fixes from me.
> >
> > If this is all fine, I took the liberty of porting the zns enabling to
> > it and made a public branch for consideration here:
> >
> > http://git.infradead.org/qemu-nvme.git/shortlog/refs/heads/kb-zns
> >
> > Dmitry Fomichev (1):
> > hw/block/nvme: report actual LBA data shift in LBAF
> >
> > Keith Busch (5):
> > hw/block/nvme: remove pointless rw indirection
> > hw/block/nvme: fix log page offset check
> > hw/block/nvme: support per-namespace smart log
> > hw/block/nvme: validate command set selected
> > hw/block/nvme: support for admin-only command set
> >
> > Klaus Jensen (3):
> > hw/block/nvme: reject io commands if only admin command set selected
> > hw/block/nvme: add nsid to get/setfeat trace events
> > hw/block/nvme: add trace event for requests with non-zero status code
> >
> > hw/block/nvme-ns.c | 5 ++
> > hw/block/nvme.c | 194 ++++++++++++++++++++----------------------
> > hw/block/trace-events | 6 +-
> > include/block/nvme.h | 11 +++
> > 4 files changed, 114 insertions(+), 102 deletions(-)
> >
> > --
> > 2.24.1
> >
> >
>
> These fixes all look good to me apart from the odd fixes that has been
> mentioned in the reviews. Since soft freeze is only two weeks away (Oct
> 27th), it would be nice to get this staged on nvme-next so we can get a
> pull sent off to Peter.
I've fixed up the comments mentioned and added the received reviews.
Since it was pretty trivial fixups and passes my basic santify tests, I
went ahead and pushed to nvme-next.
next prev parent reply other threads:[~2020-10-13 17:49 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 22:04 [PATCH 0/9] nvme qemu cleanups and fixes Keith Busch
2020-09-30 22:04 ` [PATCH 1/9] hw/block/nvme: remove pointless rw indirection Keith Busch
2020-10-01 4:05 ` Klaus Jensen
2020-10-01 8:48 ` Klaus Jensen
2020-10-01 15:24 ` Keith Busch
2020-10-01 18:34 ` Klaus Jensen
2020-10-06 1:49 ` Dmitry Fomichev
2020-09-30 22:04 ` [PATCH 2/9] hw/block/nvme: fix log page offset check Keith Busch
2020-09-30 23:18 ` Dmitry Fomichev
2020-10-01 4:05 ` Klaus Jensen
2020-10-01 10:11 ` Philippe Mathieu-Daudé
2020-09-30 22:04 ` [PATCH 3/9] hw/block/nvme: support per-namespace smart log Keith Busch
2020-10-01 4:10 ` Klaus Jensen
2020-10-01 15:20 ` Keith Busch
2020-10-01 17:18 ` Klaus Jensen
2020-10-01 17:30 ` Keith Busch
2020-10-01 17:34 ` Klaus Jensen
2020-10-02 8:48 ` Klaus Jensen
2020-10-06 1:57 ` Dmitry Fomichev
2020-09-30 22:04 ` [PATCH 4/9] hw/block/nvme: validate command set selected Keith Busch
2020-10-01 4:14 ` Klaus Jensen
2020-09-30 22:04 ` [PATCH 5/9] hw/block/nvme: support for admin-only command set Keith Busch
2020-10-01 0:11 ` Dmitry Fomichev
2020-10-01 4:17 ` Klaus Jensen
2020-09-30 22:04 ` [PATCH 6/9] hw/block/nvme: reject io commands if only admin command set selected Keith Busch
2020-09-30 23:11 ` Dmitry Fomichev
2020-09-30 22:04 ` [PATCH 7/9] hw/block/nvme: add nsid to get/setfeat trace events Keith Busch
2020-09-30 22:04 ` [PATCH 8/9] hw/block/nvme: add trace event for requests with non-zero status code Keith Busch
2020-09-30 23:21 ` Dmitry Fomichev
2020-10-01 15:25 ` Philippe Mathieu-Daudé
2020-09-30 22:04 ` [PATCH 9/9] hw/block/nvme: report actual LBA data shift in LBAF Keith Busch
2020-10-01 9:48 ` Klaus Jensen
2020-10-01 18:46 ` [PATCH 0/9] nvme qemu cleanups and fixes Klaus Jensen
2020-10-13 9:04 ` Klaus Jensen
2020-10-13 17:48 ` Keith Busch [this message]
2020-10-13 18:36 ` Klaus Jensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201013174826.GA1049145@dhcp-10-100-145-180.wdl.wdc.com \
--to=kbusch@kernel.org \
--cc=Niklas.Cassel@wdc.com \
--cc=its@irrelevant.dk \
--cc=k.jensen@samsung.com \
--cc=kwolf@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).