* [PATCH] virtiofsd: passthrough_ll: set FUSE_LOG_INFO as default log_level
@ 2020-10-08 11:01 Misono Tomohiro
2020-10-08 15:09 ` [Virtio-fs] " Stefan Hajnoczi
2020-10-26 17:13 ` Dr. David Alan Gilbert
0 siblings, 2 replies; 3+ messages in thread
From: Misono Tomohiro @ 2020-10-08 11:01 UTC (permalink / raw)
To: qemu-devel, virtio-fs
Just noticed that although help message says default log level is INFO,
it is actually 0 (EMRGE) and no mesage will be shown when error occurs.
It's better to follow help message.
Signed-off-by: Misono Tomohiro <misono.tomohiro@jp.fujitsu.com>
---
tools/virtiofsd/passthrough_ll.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/tools/virtiofsd/passthrough_ll.c b/tools/virtiofsd/passthrough_ll.c
index 0b229ebd57..4ff9f1b688 100644
--- a/tools/virtiofsd/passthrough_ll.c
+++ b/tools/virtiofsd/passthrough_ll.c
@@ -2888,12 +2888,11 @@ int main(int argc, char *argv[])
goto err_out1;
}
- /*
- * log_level is 0 if not configured via cmd options (0 is LOG_EMERG,
- * and we don't use this log level).
- */
if (opts.log_level != 0) {
current_log_level = opts.log_level;
+ } else {
+ /* default log level is INFO */
+ current_log_level = FUSE_LOG_INFO;
}
lo.debug = opts.debug;
if (lo.debug) {
--
2.25.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Virtio-fs] [PATCH] virtiofsd: passthrough_ll: set FUSE_LOG_INFO as default log_level
2020-10-08 11:01 [PATCH] virtiofsd: passthrough_ll: set FUSE_LOG_INFO as default log_level Misono Tomohiro
@ 2020-10-08 15:09 ` Stefan Hajnoczi
2020-10-26 17:13 ` Dr. David Alan Gilbert
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Hajnoczi @ 2020-10-08 15:09 UTC (permalink / raw)
To: Misono Tomohiro; +Cc: virtio-fs, qemu-devel
[-- Attachment #1: Type: text/plain, Size: 649 bytes --]
On Thu, Oct 08, 2020 at 08:01:48PM +0900, Misono Tomohiro wrote:
> Just noticed that although help message says default log level is INFO,
> it is actually 0 (EMRGE) and no mesage will be shown when error occurs.
> It's better to follow help message.
>
> Signed-off-by: Misono Tomohiro <misono.tomohiro@jp.fujitsu.com>
> ---
> tools/virtiofsd/passthrough_ll.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
I checked that FUSE_LOG_INFO isn't used in the main request code path.
Therefore this change shouldn't cause a lot of new log output or affect
performance:
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] virtiofsd: passthrough_ll: set FUSE_LOG_INFO as default log_level
2020-10-08 11:01 [PATCH] virtiofsd: passthrough_ll: set FUSE_LOG_INFO as default log_level Misono Tomohiro
2020-10-08 15:09 ` [Virtio-fs] " Stefan Hajnoczi
@ 2020-10-26 17:13 ` Dr. David Alan Gilbert
1 sibling, 0 replies; 3+ messages in thread
From: Dr. David Alan Gilbert @ 2020-10-26 17:13 UTC (permalink / raw)
To: Misono Tomohiro; +Cc: virtio-fs, qemu-devel
* Misono Tomohiro (misono.tomohiro@jp.fujitsu.com) wrote:
> Just noticed that although help message says default log level is INFO,
> it is actually 0 (EMRGE) and no mesage will be shown when error occurs.
> It's better to follow help message.
>
> Signed-off-by: Misono Tomohiro <misono.tomohiro@jp.fujitsu.com>
Queued
> ---
> tools/virtiofsd/passthrough_ll.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/tools/virtiofsd/passthrough_ll.c b/tools/virtiofsd/passthrough_ll.c
> index 0b229ebd57..4ff9f1b688 100644
> --- a/tools/virtiofsd/passthrough_ll.c
> +++ b/tools/virtiofsd/passthrough_ll.c
> @@ -2888,12 +2888,11 @@ int main(int argc, char *argv[])
> goto err_out1;
> }
>
> - /*
> - * log_level is 0 if not configured via cmd options (0 is LOG_EMERG,
> - * and we don't use this log level).
> - */
> if (opts.log_level != 0) {
> current_log_level = opts.log_level;
> + } else {
> + /* default log level is INFO */
> + current_log_level = FUSE_LOG_INFO;
> }
> lo.debug = opts.debug;
> if (lo.debug) {
> --
> 2.25.4
>
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-26 17:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-08 11:01 [PATCH] virtiofsd: passthrough_ll: set FUSE_LOG_INFO as default log_level Misono Tomohiro
2020-10-08 15:09 ` [Virtio-fs] " Stefan Hajnoczi
2020-10-26 17:13 ` Dr. David Alan Gilbert
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).