* [PATCH] ui/cocoa: Use kCGColorSpaceSRGB
@ 2021-02-19 8:45 Akihiko Odaki
2021-02-19 10:25 ` Peter Maydell
0 siblings, 1 reply; 7+ messages in thread
From: Akihiko Odaki @ 2021-02-19 8:45 UTC (permalink / raw)
Cc: Peter Maydell, qemu-devel, Akihiko Odaki, Gerd Hoffmann
kCGColorSpaceGenericRGB | Apple Developer Documentation
https://developer.apple.com/documentation/coregraphics/kcgcolorspacegenericrgb
> Deprecated
> Use kCGColorSpaceSRGB instead.
Signed-off-by: Akihiko Odaki <akihiko.odaki@gmail.com>
---
ui/cocoa.m | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ui/cocoa.m b/ui/cocoa.m
index 13fba8103e1..686fbb1b457 100644
--- a/ui/cocoa.m
+++ b/ui/cocoa.m
@@ -437,7 +437,7 @@ - (void) drawRect:(NSRect) rect
screen.bitsPerPixel, //bitsPerPixel
(screen.width * (screen.bitsPerComponent/2)), //bytesPerRow
#ifdef __LITTLE_ENDIAN__
- CGColorSpaceCreateWithName(kCGColorSpaceGenericRGB), //colorspace for OS X >= 10.4
+ CGColorSpaceCreateWithName(kCGColorSpaceSRGB), //colorspace for OS X >= 10.5
kCGBitmapByteOrder32Little | kCGImageAlphaNoneSkipFirst,
#else
CGColorSpaceCreateDeviceRGB(), //colorspace for OS X < 10.4 (actually ppc)
--
2.24.3 (Apple Git-128)
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] ui/cocoa: Use kCGColorSpaceSRGB
2021-02-19 8:45 [PATCH] ui/cocoa: Use kCGColorSpaceSRGB Akihiko Odaki
@ 2021-02-19 10:25 ` Peter Maydell
2021-02-19 11:28 ` [PATCH v2] " Akihiko Odaki
0 siblings, 1 reply; 7+ messages in thread
From: Peter Maydell @ 2021-02-19 10:25 UTC (permalink / raw)
To: Akihiko Odaki; +Cc: QEMU Developers, Gerd Hoffmann
On Fri, 19 Feb 2021 at 08:45, Akihiko Odaki <akihiko.odaki@gmail.com> wrote:
>
> kCGColorSpaceGenericRGB | Apple Developer Documentation
> https://developer.apple.com/documentation/coregraphics/kcgcolorspacegenericrgb
> > Deprecated
> > Use kCGColorSpaceSRGB instead.
>
> Signed-off-by: Akihiko Odaki <akihiko.odaki@gmail.com>
> ---
> ui/cocoa.m | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ui/cocoa.m b/ui/cocoa.m
> index 13fba8103e1..686fbb1b457 100644
> --- a/ui/cocoa.m
> +++ b/ui/cocoa.m
> @@ -437,7 +437,7 @@ - (void) drawRect:(NSRect) rect
> screen.bitsPerPixel, //bitsPerPixel
> (screen.width * (screen.bitsPerComponent/2)), //bytesPerRow
> #ifdef __LITTLE_ENDIAN__
> - CGColorSpaceCreateWithName(kCGColorSpaceGenericRGB), //colorspace for OS X >= 10.4
> + CGColorSpaceCreateWithName(kCGColorSpaceSRGB), //colorspace for OS X >= 10.5
> kCGBitmapByteOrder32Little | kCGImageAlphaNoneSkipFirst,
> #else
> CGColorSpaceCreateDeviceRGB(), //colorspace for OS X < 10.4 (actually ppc)
> --
The comment change here looks a little odd, because previously
it was a matched pair with the one in the other half of the #ifdef:
one side is "for OS X >= 10.4" and the other "for < 10.4". After
this change we have a mismatch. In fact it doesn't matter because
we don't support any OSX version that old any more anyway.
I think we should delete the whole #ifdef...#else...#endif block
here, and replace it with just the
CGColorSpaceCreateWithName(kCGColorSpaceSRGB),
kCGBitmapByteOrder32Little | kCGImageAlphaNoneSkipFirst,
lines, because we dropped PPC support a long long time ago.
(And we don't need any comment about OSX version if we do that.)
thanks
-- PMM
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2] ui/cocoa: Use kCGColorSpaceSRGB
2021-02-19 10:25 ` Peter Maydell
@ 2021-02-19 11:28 ` Akihiko Odaki
2021-02-19 11:41 ` Peter Maydell
2021-02-19 14:11 ` Gerd Hoffmann
0 siblings, 2 replies; 7+ messages in thread
From: Akihiko Odaki @ 2021-02-19 11:28 UTC (permalink / raw)
Cc: Peter Maydell, qemu-devel, Akihiko Odaki, Gerd Hoffmann
kCGColorSpaceGenericRGB | Apple Developer Documentation
https://developer.apple.com/documentation/coregraphics/kcgcolorspacegenericrgb
> Deprecated
> Use kCGColorSpaceSRGB instead.
This change also removes the legacy color space specification for
PowerPC.
Signed-off-by: Akihiko Odaki <akihiko.odaki@gmail.com>
---
ui/cocoa.m | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/ui/cocoa.m b/ui/cocoa.m
index 13fba8103e1..7710835c4c1 100644
--- a/ui/cocoa.m
+++ b/ui/cocoa.m
@@ -436,13 +436,8 @@ - (void) drawRect:(NSRect) rect
screen.bitsPerComponent, //bitsPerComponent
screen.bitsPerPixel, //bitsPerPixel
(screen.width * (screen.bitsPerComponent/2)), //bytesPerRow
-#ifdef __LITTLE_ENDIAN__
- CGColorSpaceCreateWithName(kCGColorSpaceGenericRGB), //colorspace for OS X >= 10.4
- kCGBitmapByteOrder32Little | kCGImageAlphaNoneSkipFirst,
-#else
- CGColorSpaceCreateDeviceRGB(), //colorspace for OS X < 10.4 (actually ppc)
- kCGImageAlphaNoneSkipFirst, //bitmapInfo
-#endif
+ CGColorSpaceCreateWithName(kCGColorSpaceSRGB), //colorspace
+ kCGBitmapByteOrder32Little | kCGImageAlphaNoneSkipFirst, //bitmapInfo
dataProviderRef, //provider
NULL, //decode
0, //interpolate
--
2.24.3 (Apple Git-128)
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v2] ui/cocoa: Use kCGColorSpaceSRGB
2021-02-19 11:28 ` [PATCH v2] " Akihiko Odaki
@ 2021-02-19 11:41 ` Peter Maydell
2021-02-19 14:11 ` Gerd Hoffmann
1 sibling, 0 replies; 7+ messages in thread
From: Peter Maydell @ 2021-02-19 11:41 UTC (permalink / raw)
To: Akihiko Odaki; +Cc: QEMU Developers, Gerd Hoffmann
On Fri, 19 Feb 2021 at 11:28, Akihiko Odaki <akihiko.odaki@gmail.com> wrote:
>
> kCGColorSpaceGenericRGB | Apple Developer Documentation
> https://developer.apple.com/documentation/coregraphics/kcgcolorspacegenericrgb
> > Deprecated
> > Use kCGColorSpaceSRGB instead.
>
> This change also removes the legacy color space specification for
> PowerPC.
>
> Signed-off-by: Akihiko Odaki <akihiko.odaki@gmail.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] ui/cocoa: Use kCGColorSpaceSRGB
2021-02-19 11:28 ` [PATCH v2] " Akihiko Odaki
2021-02-19 11:41 ` Peter Maydell
@ 2021-02-19 14:11 ` Gerd Hoffmann
2021-02-20 4:29 ` [PATCH v3] " Akihiko Odaki
1 sibling, 1 reply; 7+ messages in thread
From: Gerd Hoffmann @ 2021-02-19 14:11 UTC (permalink / raw)
To: Akihiko Odaki; +Cc: Peter Maydell, qemu-devel
On Fri, Feb 19, 2021 at 08:28:41PM +0900, Akihiko Odaki wrote:
> kCGColorSpaceGenericRGB | Apple Developer Documentation
> https://developer.apple.com/documentation/coregraphics/kcgcolorspacegenericrgb
> > Deprecated
> > Use kCGColorSpaceSRGB instead.
>
> This change also removes the legacy color space specification for
> PowerPC.
>
> Signed-off-by: Akihiko Odaki <akihiko.odaki@gmail.com>
Doesn't apply cleanly against git master branch, please rebase & resend.
take care,
Gerd
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v3] ui/cocoa: Use kCGColorSpaceSRGB
2021-02-19 14:11 ` Gerd Hoffmann
@ 2021-02-20 4:29 ` Akihiko Odaki
2021-02-22 10:36 ` Gerd Hoffmann
0 siblings, 1 reply; 7+ messages in thread
From: Akihiko Odaki @ 2021-02-20 4:29 UTC (permalink / raw)
Cc: Peter Maydell, qemu-devel, Akihiko Odaki, Gerd Hoffmann
kCGColorSpaceGenericRGB | Apple Developer Documentation
https://developer.apple.com/documentation/coregraphics/kcgcolorspacegenericrgb
> Deprecated
> Use kCGColorSpaceSRGB instead.
This change also removes the legacy color space specification for
PowerPC.
Signed-off-by: Akihiko Odaki <akihiko.odaki@gmail.com>
---
ui/cocoa.m | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/ui/cocoa.m b/ui/cocoa.m
index 13fba8103e1..7710835c4c1 100644
--- a/ui/cocoa.m
+++ b/ui/cocoa.m
@@ -436,13 +436,8 @@ - (void) drawRect:(NSRect) rect
screen.bitsPerComponent, //bitsPerComponent
screen.bitsPerPixel, //bitsPerPixel
(screen.width * (screen.bitsPerComponent/2)), //bytesPerRow
-#ifdef __LITTLE_ENDIAN__
- CGColorSpaceCreateWithName(kCGColorSpaceGenericRGB), //colorspace for OS X >= 10.4
- kCGBitmapByteOrder32Little | kCGImageAlphaNoneSkipFirst,
-#else
- CGColorSpaceCreateDeviceRGB(), //colorspace for OS X < 10.4 (actually ppc)
- kCGImageAlphaNoneSkipFirst, //bitmapInfo
-#endif
+ CGColorSpaceCreateWithName(kCGColorSpaceSRGB), //colorspace
+ kCGBitmapByteOrder32Little | kCGImageAlphaNoneSkipFirst, //bitmapInfo
dataProviderRef, //provider
NULL, //decode
0, //interpolate
--
2.24.3 (Apple Git-128)
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v3] ui/cocoa: Use kCGColorSpaceSRGB
2021-02-20 4:29 ` [PATCH v3] " Akihiko Odaki
@ 2021-02-22 10:36 ` Gerd Hoffmann
0 siblings, 0 replies; 7+ messages in thread
From: Gerd Hoffmann @ 2021-02-22 10:36 UTC (permalink / raw)
To: Akihiko Odaki; +Cc: Peter Maydell, qemu-devel
On Sat, Feb 20, 2021 at 01:29:29PM +0900, Akihiko Odaki wrote:
> kCGColorSpaceGenericRGB | Apple Developer Documentation
> https://developer.apple.com/documentation/coregraphics/kcgcolorspacegenericrgb
> > Deprecated
> > Use kCGColorSpaceSRGB instead.
>
> This change also removes the legacy color space specification for
> PowerPC.
Still doesn't apply, looks like a conflict with one of your other
(meanwhile merger) patches. Those kind of changes are best submitted
as patch series.
take care,
Gerd
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-02-22 10:38 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-19 8:45 [PATCH] ui/cocoa: Use kCGColorSpaceSRGB Akihiko Odaki
2021-02-19 10:25 ` Peter Maydell
2021-02-19 11:28 ` [PATCH v2] " Akihiko Odaki
2021-02-19 11:41 ` Peter Maydell
2021-02-19 14:11 ` Gerd Hoffmann
2021-02-20 4:29 ` [PATCH v3] " Akihiko Odaki
2021-02-22 10:36 ` Gerd Hoffmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).