qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Vivek Goyal <vgoyal@redhat.com>
To: Connor Kuehl <ckuehl@redhat.com>
Cc: virtio-fs@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Virtio-fs] [PATCH 0/7] virtiofsd: Few cleanups in virtio_send_data_iov()
Date: Mon, 17 May 2021 09:08:50 -0400	[thread overview]
Message-ID: <20210517130850.GD546943@horse.lan> (raw)
In-Reply-To: <34daab90-0e71-20c1-139d-ac0e084f8ed0@redhat.com>

On Thu, May 13, 2021 at 03:50:33PM -0500, Connor Kuehl wrote:
> On 5/11/21 4:37 PM, Vivek Goyal wrote:
> > Hi,
> > 
> > Code in virtio_send_data_iov() little twisted and complicated. This
> > patch series just tries to simplify it a bit to make it little easier
> > to read this piece of code.
> > 
> > Thanks
> > Vivek
> > 
> > Vivek Goyal (7):
> >   virtiofsd: Check for EINTR in preadv() and retry
> >   virtiofsd: Get rid of unreachable code in read
> >   virtiofsd: Use iov_discard_front() to skip bytes
> >   virtiofsd: get rid of in_sg_left variable
> >   virtiofsd: Simplify skip byte logic
> >   virtiofsd: Check EOF before short read
> >   virtiofsd: Set req->reply_sent right after sending reply
> > 
> >  tools/virtiofsd/fuse_virtio.c | 67 +++++++++++------------------------
> >  1 file changed, 21 insertions(+), 46 deletions(-)
> > 
> 
> With the codestyle fix to appease the bot:
> 
> Reviewed-by: Connor Kuehl <ckuehl@redhat.com>
> 
> (For the series)

Thanks. I will fix the coding style issue and repost the patch series.

Vivek



      reply	other threads:[~2021-05-17 13:09 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-11 21:37 [PATCH 0/7] virtiofsd: Few cleanups in virtio_send_data_iov() Vivek Goyal
2021-05-11 21:37 ` [PATCH 1/7] virtiofsd: Check for EINTR in preadv() and retry Vivek Goyal
2021-05-18 11:59   ` Dr. David Alan Gilbert
2021-05-11 21:37 ` [PATCH 2/7] virtiofsd: Get rid of unreachable code in read Vivek Goyal
2021-05-18 12:01   ` Dr. David Alan Gilbert
2021-05-11 21:37 ` [PATCH 3/7] virtiofsd: Use iov_discard_front() to skip bytes Vivek Goyal
2021-05-18 12:10   ` Dr. David Alan Gilbert
2021-05-11 21:37 ` [PATCH 4/7] virtiofsd: get rid of in_sg_left variable Vivek Goyal
2021-05-18 12:19   ` Dr. David Alan Gilbert
2021-05-11 21:37 ` [PATCH 5/7] virtiofsd: Simplify skip byte logic Vivek Goyal
2021-05-18 12:26   ` Dr. David Alan Gilbert
2021-05-11 21:37 ` [PATCH 6/7] virtiofsd: Check EOF before short read Vivek Goyal
2021-05-18 12:31   ` Dr. David Alan Gilbert
2021-05-11 21:37 ` [PATCH 7/7] virtiofsd: Set req->reply_sent right after sending reply Vivek Goyal
2021-05-13 20:50   ` [Virtio-fs] " Connor Kuehl
2021-05-17 13:08     ` Vivek Goyal
2021-05-18 12:34       ` Dr. David Alan Gilbert
2021-05-18 12:32   ` Dr. David Alan Gilbert
2021-05-11 21:48 ` [PATCH 0/7] virtiofsd: Few cleanups in virtio_send_data_iov() no-reply
2021-05-13 20:50 ` [Virtio-fs] " Connor Kuehl
2021-05-17 13:08   ` Vivek Goyal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210517130850.GD546943@horse.lan \
    --to=vgoyal@redhat.com \
    --cc=ckuehl@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=virtio-fs@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).