qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jean-Philippe Brucker <jean-philippe@linaro.org>
To: pbonzini@redhat.com
Cc: Jean-Philippe Brucker <jean-philippe@linaro.org>,
	armbru@redhat.com, qemu-devel@nongnu.org
Subject: [PATCH 2/2] hw/i386: Rename default_bus_bypass_iommu
Date: Wed, 11 Aug 2021 10:58:44 +0200	[thread overview]
Message-ID: <20210811085842.2511545-2-jean-philippe@linaro.org> (raw)
In-Reply-To: <20210811085842.2511545-1-jean-philippe@linaro.org>

Since commit d8fb7d0969d5 ("vl: switch -M parsing to keyval"), machine
parameter definitions cannot use underscores, because keyval_dashify()
transforms them to dashes and the parser doesn't find the parameter.

This affects option default_bus_bypass_iommu which was introduced in the
same release:

$ qemu-system-x86_64 -M q35,default_bus_bypass_iommu=on
qemu-system-x86_64: Property 'pc-q35-6.1-machine.default-bus-bypass-iommu' not found

Rename the parameter to "default-bus-bypass-iommu". Passing
"default_bus_bypass_iommu" is still valid since the underscore are
transformed automatically.

Fixes: c9e96b04fc19 ("hw/i386: Add a default_bus_bypass_iommu pc machine option")
Signed-off-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
---
 hw/i386/pc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index fb24f000e7..ce4756ad59 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -1779,7 +1779,7 @@ static void pc_machine_class_init(ObjectClass *oc, void *data)
     object_class_property_add_bool(oc, "hpet",
         pc_machine_get_hpet, pc_machine_set_hpet);
 
-    object_class_property_add_bool(oc, "default_bus_bypass_iommu",
+    object_class_property_add_bool(oc, "default-bus-bypass-iommu",
         pc_machine_get_default_bus_bypass_iommu,
         pc_machine_set_default_bus_bypass_iommu);
 
-- 
2.32.0



  reply	other threads:[~2021-08-11  9:01 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-11  8:58 [PATCH 1/2] hw/arm/virt: Rename default_bus_bypass_iommu Jean-Philippe Brucker
2021-08-11  8:58 ` Jean-Philippe Brucker [this message]
2021-10-05 17:08   ` [PATCH 2/2] hw/i386: " Eric Auger
2021-11-25  7:12   ` Markus Armbruster
2021-11-25  7:19     ` Michael S. Tsirkin
2021-11-25  8:56       ` Markus Armbruster
2021-08-24  7:53 ` [PATCH 1/2] hw/arm/virt: " Markus Armbruster
2021-08-25  7:34   ` Markus Armbruster
2021-09-07 18:05     ` Jean-Philippe Brucker
2021-10-02  5:30     ` Markus Armbruster
2021-10-05 17:37       ` Eric Auger
2021-10-05 17:28 ` Eric Auger
2021-11-25  7:11 ` Markus Armbruster
2021-11-25  7:39   ` Jean-Philippe Brucker
2021-11-25  8:53     ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210811085842.2511545-2-jean-philippe@linaro.org \
    --to=jean-philippe@linaro.org \
    --cc=armbru@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).