From: Markus Armbruster <armbru@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org
Subject: Re: [PATCH 2/2] hw/i386: Rename default_bus_bypass_iommu
Date: Thu, 25 Nov 2021 09:56:42 +0100 [thread overview]
Message-ID: <871r34pq9h.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20211125021619-mutt-send-email-mst@kernel.org> (Michael S. Tsirkin's message of "Thu, 25 Nov 2021 02:19:21 -0500")
"Michael S. Tsirkin" <mst@redhat.com> writes:
> On Thu, Nov 25, 2021 at 08:12:25AM +0100, Markus Armbruster wrote:
>> Michael & Marcel, this patch fixes a bug that became a regression when
>> the fix missed 6.1. It's been stuck on the list since August. Please
>> have a look, and if it's good, get it merged.
>
>
> Thanks for the reminder. Jean-Philippe, Cc maintainers
> will help patches get merged in a timely manner in the future.
>
>> I just asked the arm/virt
>> maintainer to do the same for PATCH 1.
>
> Some questions below.
>
>> Jean-Philippe Brucker <jean-philippe@linaro.org> writes:
>>
>> > Since commit d8fb7d0969d5 ("vl: switch -M parsing to keyval"), machine
>> > parameter definitions cannot use underscores, because keyval_dashify()
>> > transforms them to dashes and the parser doesn't find the parameter.
>> >
>> > This affects option default_bus_bypass_iommu which was introduced in the
>> > same release:
>> >
>> > $ qemu-system-x86_64 -M q35,default_bus_bypass_iommu=on
>> > qemu-system-x86_64: Property 'pc-q35-6.1-machine.default-bus-bypass-iommu' not found
>
> I don't see this behaviour. What did I miss?
I looked at the source and somehow missed that the fix is already there
(commit 739b38630c45). Sorry for the noise!
[...]
next prev parent reply other threads:[~2021-11-25 8:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-11 8:58 [PATCH 1/2] hw/arm/virt: Rename default_bus_bypass_iommu Jean-Philippe Brucker
2021-08-11 8:58 ` [PATCH 2/2] hw/i386: " Jean-Philippe Brucker
2021-10-05 17:08 ` Eric Auger
2021-11-25 7:12 ` Markus Armbruster
2021-11-25 7:19 ` Michael S. Tsirkin
2021-11-25 8:56 ` Markus Armbruster [this message]
2021-08-24 7:53 ` [PATCH 1/2] hw/arm/virt: " Markus Armbruster
2021-08-25 7:34 ` Markus Armbruster
2021-09-07 18:05 ` Jean-Philippe Brucker
2021-10-02 5:30 ` Markus Armbruster
2021-10-05 17:37 ` Eric Auger
2021-10-05 17:28 ` Eric Auger
2021-11-25 7:11 ` Markus Armbruster
2021-11-25 7:39 ` Jean-Philippe Brucker
2021-11-25 8:53 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871r34pq9h.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).