From: Eric Auger <eauger@redhat.com>
To: Markus Armbruster <armbru@redhat.com>,
pbonzini@redhat.com, Peter Maydell <peter.maydell@linaro.org>
Cc: Jean-Philippe Brucker <jean-philippe@linaro.org>, qemu-devel@nongnu.org
Subject: Re: [PATCH 1/2] hw/arm/virt: Rename default_bus_bypass_iommu
Date: Tue, 5 Oct 2021 19:37:53 +0200 [thread overview]
Message-ID: <630cb326-dd99-7f11-b6f3-292747467af8@redhat.com> (raw)
In-Reply-To: <87ee94q9hr.fsf@dusky.pond.sub.org>
Hi Paolo, Peter,
On 10/2/21 7:30 AM, Markus Armbruster wrote:
> Markus Armbruster <armbru@redhat.com> writes:
>
>> Markus Armbruster <armbru@redhat.com> writes:
>>
>>> Did this series fall through the cracks for 6.1?
>>
>> Missed 6.1. What now?
>
> If I understand this correctly, it's a regression in 6.1. Paolo, please
> advise on what should be done.
Can we get those 2 fixes merged?
Maybe we should also add
Cc: qemu-stable@nongnu.org
If so is there a chance the fix gets backported to 6.1?
Thanks
Eric
>
>>> Jean-Philippe Brucker <jean-philippe@linaro.org> writes:
>>>
>>>> Since commit d8fb7d0969d5 ("vl: switch -M parsing to keyval"), machine
>>>> parameter definitions cannot use underscores, because keyval_dashify()
>>>> transforms them to dashes and the parser doesn't find the parameter.
>>>>
>>>> This affects option default_bus_bypass_iommu which was introduced in the
>>>> same release:
>>>>
>>>> $ qemu-system-aarch64 -M virt,default_bus_bypass_iommu=on
>>>> qemu-system-aarch64: Property 'virt-6.1-machine.default-bus-bypass-iommu' not found
>>>>
>>>> Rename the parameter to "default-bus-bypass-iommu". Passing
>>>> "default_bus_bypass_iommu" is still valid since the underscore are
>>>> transformed automatically.
>>>>
>>>> Fixes: 6d7a85483a06 ("hw/arm/virt: Add default_bus_bypass_iommu machine option")
>>>> Signed-off-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
>>>> ---
>>>> hw/arm/virt.c | 4 ++--
>>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/hw/arm/virt.c b/hw/arm/virt.c
>>>> index b4598d3fe6..7075cdc15e 100644
>>>> --- a/hw/arm/virt.c
>>>> +++ b/hw/arm/virt.c
>>>> @@ -2671,10 +2671,10 @@ static void virt_machine_class_init(ObjectClass *oc, void *data)
>>>> "Set the IOMMU type. "
>>>> "Valid values are none and smmuv3");
>>>>
>>>> - object_class_property_add_bool(oc, "default_bus_bypass_iommu",
>>>> + object_class_property_add_bool(oc, "default-bus-bypass-iommu",
>>>> virt_get_default_bus_bypass_iommu,
>>>> virt_set_default_bus_bypass_iommu);
>>>> - object_class_property_set_description(oc, "default_bus_bypass_iommu",
>>>> + object_class_property_set_description(oc, "default-bus-bypass-iommu",
>>>> "Set on/off to enable/disable "
>>>> "bypass_iommu for default root bus");
>
>
next prev parent reply other threads:[~2021-10-05 18:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-11 8:58 [PATCH 1/2] hw/arm/virt: Rename default_bus_bypass_iommu Jean-Philippe Brucker
2021-08-11 8:58 ` [PATCH 2/2] hw/i386: " Jean-Philippe Brucker
2021-10-05 17:08 ` Eric Auger
2021-11-25 7:12 ` Markus Armbruster
2021-11-25 7:19 ` Michael S. Tsirkin
2021-11-25 8:56 ` Markus Armbruster
2021-08-24 7:53 ` [PATCH 1/2] hw/arm/virt: " Markus Armbruster
2021-08-25 7:34 ` Markus Armbruster
2021-09-07 18:05 ` Jean-Philippe Brucker
2021-10-02 5:30 ` Markus Armbruster
2021-10-05 17:37 ` Eric Auger [this message]
2021-10-05 17:28 ` Eric Auger
2021-11-25 7:11 ` Markus Armbruster
2021-11-25 7:39 ` Jean-Philippe Brucker
2021-11-25 8:53 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=630cb326-dd99-7f11-b6f3-292747467af8@redhat.com \
--to=eauger@redhat.com \
--cc=armbru@redhat.com \
--cc=jean-philippe@linaro.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).