[PULL 0/1] QGA warning fix

[PULL 0/1] QGA warning fix

[Konstantin Kostiuk]

From: Kostiantyn Kostiuk <kostyanf14@live.com>


The following changes since commit 9832009d9dd2386664c15cc70f6e6bfe062be8bd:

  Merge tag 'pull-riscv-to-apply-20230306' of https://gitlab.com/palmer-dabbelt/qemu into staging (2023-03-07 12:53:00 +0000)

are available in the Git repository at:

  git@github.com:kostyanf14/qemu.git tags/qga-pull-2023-03-22

for you to fetch changes up to 0fcd574b025fccdf14d5140687cafe2bc30b634f:

  qga/vss-win32: fix warning for clang++-15 (2023-03-22 21:02:09 +0200)

----------------------------------------------------------------
qga-pull-2023-03-22

----------------------------------------------------------------
Pierrick Bouvier (1):
      qga/vss-win32: fix warning for clang++-15

 qga/vss-win32/install.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


--
2.25.1

[PULL 1/1] qga/vss-win32: fix warning for clang++-15

[Konstantin Kostiuk]

From: Pierrick Bouvier <pierrick.bouvier@linaro.org>

Reported when compiling with clang-windows-arm64.

../qga/vss-win32/install.cpp:537:9: error: variable 'hr' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]
    if (!(ControlService(service, SERVICE_CONTROL_STOP, NULL))) {
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../qga/vss-win32/install.cpp:545:12: note: uninitialized use occurs here
    return hr;
           ^~

Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Fixes: 917ebcb170 ("qga-win: Fix QGA VSS Provider service stop failure")
Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Kostiantyn Kostiuk <kostyanf14@live.com>
---
 qga/vss-win32/install.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/qga/vss-win32/install.cpp b/qga/vss-win32/install.cpp
index b57508fbe0..b8087e5baa 100644
--- a/qga/vss-win32/install.cpp
+++ b/qga/vss-win32/install.cpp
@@ -518,7 +518,7 @@ namespace _com_util
 /* Stop QGA VSS provider service using Winsvc API  */
 STDAPI StopService(void)
 {
-    HRESULT hr;
+    HRESULT hr = S_OK;
     SC_HANDLE manager = OpenSCManager(NULL, NULL, SC_MANAGER_ALL_ACCESS);
     SC_HANDLE service = NULL;
 
-- 
2.25.1

Re: [PULL 0/1] QGA warning fix

[Peter Maydell]

On Wed, 22 Mar 2023 at 19:22, Konstantin Kostiuk <kkostiuk@redhat.com> wrote:
>
> From: Kostiantyn Kostiuk <kostyanf14@live.com>
>
>
> The following changes since commit 9832009d9dd2386664c15cc70f6e6bfe062be8bd:
>
>   Merge tag 'pull-riscv-to-apply-20230306' of https://gitlab.com/palmer-dabbelt/qemu into staging (2023-03-07 12:53:00 +0000)
>
> are available in the Git repository at:
>
>   git@github.com:kostyanf14/qemu.git tags/qga-pull-2023-03-22
>
> for you to fetch changes up to 0fcd574b025fccdf14d5140687cafe2bc30b634f:
>
>   qga/vss-win32: fix warning for clang++-15 (2023-03-22 21:02:09 +0200)
>
> ----------------------------------------------------------------
> qga-pull-2023-03-22
>
> ----------------------------------------------------------------


Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/8.0
for any user-visible changes.

-- PMM