From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, qemu-devel@nongnu.org
Cc: "Daniel P . Berrangé" <berrange@redhat.com>,
"Erik Skultety" <eskultet@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Willian Rampazzo" <willianr@redhat.com>,
"Cleber Rosa" <crosa@redhat.com>,
"Miroslav Rezanina" <mrezanin@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: Re: [PATCH 04/15] gitlab-ci: Replace YAML anchors by extends (acceptance_test_job)
Date: Mon, 3 May 2021 11:22:16 +0200 [thread overview]
Message-ID: <4ade3b15-5f39-d319-0c3e-27f3c3cd39d5@redhat.com> (raw)
In-Reply-To: <20210418233448.1267991-5-f4bug@amsat.org>
On 19/04/2021 01.34, Philippe Mathieu-Daudé wrote:
> From: Philippe Mathieu-Daudé <philmd@redhat.com>
>
> 'extends' is an alternative to using YAML anchors
> and is a little more flexible and readable. See:
> https://docs.gitlab.com/ee/ci/yaml/#extends
>
> Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> .gitlab-ci.yml | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index 11bda3abf33..07e5e737685 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -48,7 +48,7 @@ include:
> # Avoid recompiling by hiding ninja with NINJA=":"
> - make NINJA=":" $MAKE_CHECK_ARGS
>
> -.acceptance_template: &acceptance_definition
> +.acceptance_test_job_template:
> cache:
> key: "${CI_JOB_NAME}-cache"
> paths:
> @@ -111,7 +111,7 @@ acceptance-system-alpine:
> variables:
> IMAGE: alpine
> MAKE_CHECK_ARGS: check-acceptance
> - <<: *acceptance_definition
> + extends: .acceptance_test_job_template
FYI, I'm getting "YAML invalid" errors when adding this patch to my staging
branch. I guess you cannot use extends twice in a job and you should extend
the .acceptance_test_job_template from ..native_build_job_template instead.
Thomas
next prev parent reply other threads:[~2021-05-03 9:25 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-18 23:34 [RFC PATCH 00/15] gitlab-ci: Allow forks to use different pipelines than mainstream Philippe Mathieu-Daudé
2021-04-18 23:34 ` [PATCH 01/15] gitlab-ci: Replace YAML anchors by extends (container_job) Philippe Mathieu-Daudé
2021-04-18 23:34 ` [PATCH 02/15] gitlab-ci: Replace YAML anchors by extends (native_build_job) Philippe Mathieu-Daudé
2021-04-18 23:34 ` [PATCH 03/15] gitlab-ci: Replace YAML anchors by extends (native_test_job) Philippe Mathieu-Daudé
2021-04-18 23:34 ` [PATCH 04/15] gitlab-ci: Replace YAML anchors by extends (acceptance_test_job) Philippe Mathieu-Daudé
2021-05-03 9:22 ` Thomas Huth [this message]
2021-05-03 9:45 ` Philippe Mathieu-Daudé
2021-04-18 23:34 ` [PATCH 05/15] gitlab-ci: Rename acceptance_test_job -> integration_test_job Philippe Mathieu-Daudé
2021-04-19 5:19 ` Thomas Huth
2021-04-23 17:18 ` Willian Rampazzo
2021-04-18 23:34 ` [PATCH 06/15] gitlab-ci: Extract container job template to container-template.yml Philippe Mathieu-Daudé
2021-04-18 23:34 ` [PATCH 07/15] gitlab-ci: Extract crossbuild job templates to crossbuild-template.yml Philippe Mathieu-Daudé
2021-04-18 23:34 ` [PATCH 08/15] gitlab-ci: Extract DCO/style check jobs to checks.yml Philippe Mathieu-Daudé
2021-04-19 5:26 ` Thomas Huth
2021-04-19 13:44 ` Wainer dos Santos Moschetta
2021-04-18 23:34 ` [PATCH 09/15] gitlab-ci: Extract build stages to stages.yml Philippe Mathieu-Daudé
2021-04-18 23:34 ` [PATCH 10/15] gitlab-ci: Extract all default build/test jobs to buildtest.yml Philippe Mathieu-Daudé
2021-04-19 5:39 ` Thomas Huth
2021-04-19 15:11 ` Alex Bennée
2021-05-11 7:19 ` Philippe Mathieu-Daudé
2021-04-18 23:34 ` [PATCH 11/15] gitlab-ci: Extract core container jobs to container-core.yml Philippe Mathieu-Daudé
2021-04-19 5:42 ` Thomas Huth
2021-04-18 23:34 ` [PATCH 12/15] gitlab-ci: Move current job set to qemu-project.yml Philippe Mathieu-Daudé
2021-04-18 23:34 ` [RFC PATCH 13/15] gitlab-ci: Switch to dynamically generated pipelines Philippe Mathieu-Daudé
2021-04-18 23:34 ` [RFC PATCH 14/15] gitlab-ci: Allow forks to use different set of jobs Philippe Mathieu-Daudé
2021-04-19 5:48 ` Thomas Huth
2021-04-19 9:40 ` Daniel P. Berrangé
2021-04-19 10:09 ` Philippe Mathieu-Daudé
2021-04-19 10:10 ` Erik Skultety
2021-04-19 10:20 ` Thomas Huth
2021-04-19 10:36 ` Daniel P. Berrangé
2021-04-19 10:48 ` Thomas Huth
2021-04-19 10:51 ` Daniel P. Berrangé
2021-04-19 10:59 ` Thomas Huth
2021-05-11 6:48 ` Philippe Mathieu-Daudé
2021-05-11 13:55 ` Stefan Hajnoczi
2021-05-11 14:00 ` Alex Bennée
2021-05-11 14:21 ` Daniel P. Berrangé
2021-05-13 19:01 ` Philippe Mathieu-Daudé
2021-04-19 10:47 ` Daniel P. Berrangé
2021-04-19 10:44 ` Philippe Mathieu-Daudé
2021-04-19 15:57 ` Alex Bennée
2021-04-19 16:22 ` Daniel P. Berrangé
2021-04-19 16:46 ` Philippe Mathieu-Daudé
2021-04-19 16:58 ` Daniel P. Berrangé
2021-04-19 16:39 ` Philippe Mathieu-Daudé
2021-04-18 23:34 ` [NOTFORMERGE PATCH 15/15] gitlab-ci: Use my own set of jobs for CI pipeline Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ade3b15-5f39-d319-0c3e-27f3c3cd39d5@redhat.com \
--to=thuth@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=crosa@redhat.com \
--cc=eskultet@redhat.com \
--cc=f4bug@amsat.org \
--cc=mrezanin@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=wainersm@redhat.com \
--cc=willianr@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).