From: Willian Rampazzo <wrampazz@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: "Daniel P . Berrangé" <berrange@redhat.com>,
"Erik Skultety" <eskultet@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>,
"Cleber Rosa" <crosa@redhat.com>,
"Miroslav Rezanina" <mrezanin@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH 05/15] gitlab-ci: Rename acceptance_test_job -> integration_test_job
Date: Fri, 23 Apr 2021 14:18:20 -0300 [thread overview]
Message-ID: <CAKJDGDZzo7SJC3sYvzRbvdjTR1b6VOmLJXW8d5esAp1=XUuTqg@mail.gmail.com> (raw)
In-Reply-To: <461d2524-b7a3-9a77-7dbf-64eadd8ba494@redhat.com>
On Mon, Apr 19, 2021 at 2:19 AM Thomas Huth <thuth@redhat.com> wrote:
>
> On 19/04/2021 01.34, Philippe Mathieu-Daudé wrote:
> > From: Philippe Mathieu-Daudé <philmd@redhat.com>
> >
> > The acceptance tests aren't accepting anything,
> > rename them as integration tests.
> >
> > Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
> > Reviewed-by: Willian Rampazzo <willianr@redhat.com>
> > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> > ---
> > .gitlab-ci.yml | 20 ++++++++++----------
> > 1 file changed, 10 insertions(+), 10 deletions(-)
>
> Acked-by: Thomas Huth <thuth@redhat.com>
>
> FWIW, I'm in favour of renaming the tests/acceptance directory to
> tests/integration , too.
>
For the sake of consistency, +1 here.
next prev parent reply other threads:[~2021-04-23 17:19 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-18 23:34 [RFC PATCH 00/15] gitlab-ci: Allow forks to use different pipelines than mainstream Philippe Mathieu-Daudé
2021-04-18 23:34 ` [PATCH 01/15] gitlab-ci: Replace YAML anchors by extends (container_job) Philippe Mathieu-Daudé
2021-04-18 23:34 ` [PATCH 02/15] gitlab-ci: Replace YAML anchors by extends (native_build_job) Philippe Mathieu-Daudé
2021-04-18 23:34 ` [PATCH 03/15] gitlab-ci: Replace YAML anchors by extends (native_test_job) Philippe Mathieu-Daudé
2021-04-18 23:34 ` [PATCH 04/15] gitlab-ci: Replace YAML anchors by extends (acceptance_test_job) Philippe Mathieu-Daudé
2021-05-03 9:22 ` Thomas Huth
2021-05-03 9:45 ` Philippe Mathieu-Daudé
2021-04-18 23:34 ` [PATCH 05/15] gitlab-ci: Rename acceptance_test_job -> integration_test_job Philippe Mathieu-Daudé
2021-04-19 5:19 ` Thomas Huth
2021-04-23 17:18 ` Willian Rampazzo [this message]
2021-04-18 23:34 ` [PATCH 06/15] gitlab-ci: Extract container job template to container-template.yml Philippe Mathieu-Daudé
2021-04-18 23:34 ` [PATCH 07/15] gitlab-ci: Extract crossbuild job templates to crossbuild-template.yml Philippe Mathieu-Daudé
2021-04-18 23:34 ` [PATCH 08/15] gitlab-ci: Extract DCO/style check jobs to checks.yml Philippe Mathieu-Daudé
2021-04-19 5:26 ` Thomas Huth
2021-04-19 13:44 ` Wainer dos Santos Moschetta
2021-04-18 23:34 ` [PATCH 09/15] gitlab-ci: Extract build stages to stages.yml Philippe Mathieu-Daudé
2021-04-18 23:34 ` [PATCH 10/15] gitlab-ci: Extract all default build/test jobs to buildtest.yml Philippe Mathieu-Daudé
2021-04-19 5:39 ` Thomas Huth
2021-04-19 15:11 ` Alex Bennée
2021-05-11 7:19 ` Philippe Mathieu-Daudé
2021-04-18 23:34 ` [PATCH 11/15] gitlab-ci: Extract core container jobs to container-core.yml Philippe Mathieu-Daudé
2021-04-19 5:42 ` Thomas Huth
2021-04-18 23:34 ` [PATCH 12/15] gitlab-ci: Move current job set to qemu-project.yml Philippe Mathieu-Daudé
2021-04-18 23:34 ` [RFC PATCH 13/15] gitlab-ci: Switch to dynamically generated pipelines Philippe Mathieu-Daudé
2021-04-18 23:34 ` [RFC PATCH 14/15] gitlab-ci: Allow forks to use different set of jobs Philippe Mathieu-Daudé
2021-04-19 5:48 ` Thomas Huth
2021-04-19 9:40 ` Daniel P. Berrangé
2021-04-19 10:09 ` Philippe Mathieu-Daudé
2021-04-19 10:10 ` Erik Skultety
2021-04-19 10:20 ` Thomas Huth
2021-04-19 10:36 ` Daniel P. Berrangé
2021-04-19 10:48 ` Thomas Huth
2021-04-19 10:51 ` Daniel P. Berrangé
2021-04-19 10:59 ` Thomas Huth
2021-05-11 6:48 ` Philippe Mathieu-Daudé
2021-05-11 13:55 ` Stefan Hajnoczi
2021-05-11 14:00 ` Alex Bennée
2021-05-11 14:21 ` Daniel P. Berrangé
2021-05-13 19:01 ` Philippe Mathieu-Daudé
2021-04-19 10:47 ` Daniel P. Berrangé
2021-04-19 10:44 ` Philippe Mathieu-Daudé
2021-04-19 15:57 ` Alex Bennée
2021-04-19 16:22 ` Daniel P. Berrangé
2021-04-19 16:46 ` Philippe Mathieu-Daudé
2021-04-19 16:58 ` Daniel P. Berrangé
2021-04-19 16:39 ` Philippe Mathieu-Daudé
2021-04-18 23:34 ` [NOTFORMERGE PATCH 15/15] gitlab-ci: Use my own set of jobs for CI pipeline Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKJDGDZzo7SJC3sYvzRbvdjTR1b6VOmLJXW8d5esAp1=XUuTqg@mail.gmail.com' \
--to=wrampazz@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=crosa@redhat.com \
--cc=eskultet@redhat.com \
--cc=f4bug@amsat.org \
--cc=mrezanin@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).