qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jerome Forissier <jerome.forissier@linaro.org>
To: "Cédric Le Goater" <clg@kaod.org>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: Bin Meng <bin.meng@windriver.com>,
	Vincent Palatin <vpalatin@chromium.org>,
	qemu-devel@nongnu.org, qemu-block@nongnu.org,
	Joel Stanley <joel@jms.id.au>
Subject: Re: [RFC PATCH 11/17] hw/sd: Add eMMC support
Date: Mon, 28 Mar 2022 14:10:58 +0200	[thread overview]
Message-ID: <4c2faa25-d7b3-1a69-587f-f93183327f91@linaro.org> (raw)
In-Reply-To: <20220318132824.1134400-12-clg@kaod.org>

Hi Cédric,

On 3/18/22 14:28, Cédric Le Goater wrote:
> The initial eMMC support from Vincent Palatin was largely reworked to
> match the current SD framework. The parameters mimick a real 4GB eMMC,
> but it can be set to various sizes.
> 
> This adds a new QOM object class for EMMC devices.

That is interesting. Is RPMB emulation implemented? I doesn't look like
so, although...


> +    sd->ext_csd[EXT_CSD_RPMB_MULT] = 0x1; /* RPMB size */

...this indicates that the device has one block (128 KB) of RPMB if I'm
not mistaken.


I would be quite interested in testing and possibly helping out
implement RPMB, although I must admit don't know much about QEMU
internals. I have written some quick & dirty emulation code for RPMB at
the Linux ioctl() level, see [1]. This code is useful for CI testing of
the OP-TEE OS project [2], but having a lower level emulation in QEMU
would be much better since the Linux kernel would "see" the device and
report it in sysfs etc.

[1] https://github.com/OP-TEE/optee_client/blob/3.16.0/tee-supplicant/src/rpmb.c#L494-L571
[2] https://github.com/OP-TEE/optee_os/

Thanks,
-- 
Jerome


  reply	other threads:[~2022-03-28 12:13 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-18 13:28 [RFC PATCH 00/17] hw/sd: Rework models for eMMC support Cédric Le Goater
2022-03-18 13:28 ` [RFC PATCH 01/17] hw/sd: When card is in wrong state, log which state it is Cédric Le Goater
2022-03-18 13:28 ` [RFC PATCH 02/17] hw/sd: Move proto_name to SDProto structure Cédric Le Goater
2022-03-18 13:28 ` [RFC PATCH 03/17] hw/sd: Introduce sd_cmd_handler type Cédric Le Goater
2022-03-18 13:28 ` [RFC PATCH 04/17] hw/sd: Add sd_cmd_illegal() handler Cédric Le Goater
2022-03-18 13:28 ` [RFC PATCH 05/17] hw/sd: Add sd_cmd_unimplemented() handler Cédric Le Goater
2022-03-18 13:28 ` [RFC PATCH 06/17] hw/sd: Add sd_cmd_GO_IDLE_STATE() handler Cédric Le Goater
2022-03-18 13:28 ` [RFC PATCH 07/17] hw/sd: Add sd_cmd_SEND_OP_CMD() handler Cédric Le Goater
2022-05-09 21:12   ` Philippe Mathieu-Daudé via
2022-05-10  6:57     ` Cédric Le Goater
2022-05-30 17:25       ` Philippe Mathieu-Daudé via
2022-03-18 13:28 ` [RFC PATCH 08/17] hw/sd: Add sd_cmd_ALL_SEND_CID() handler Cédric Le Goater
2022-03-18 13:28 ` [RFC PATCH 09/17] hw/sd: Add sd_cmd_SEND_RELATIVE_ADDR() handler Cédric Le Goater
2022-03-18 13:28 ` [RFC PATCH 10/17] hw/sd: Add sd_cmd_SEND_TUNING_BLOCK() handler Cédric Le Goater
2022-05-09 21:05   ` Philippe Mathieu-Daudé via
2022-05-10  6:57     ` Cédric Le Goater
2022-03-18 13:28 ` [RFC PATCH 11/17] hw/sd: Add eMMC support Cédric Le Goater
2022-03-28 12:10   ` Jerome Forissier [this message]
2022-03-28 14:13     ` Cédric Le Goater
2022-05-09 21:17   ` Philippe Mathieu-Daudé via
2022-05-10  7:15     ` Cédric Le Goater
2022-05-10 13:53       ` Cédric Le Goater
2022-05-30 17:02   ` Philippe Mathieu-Daudé via
2022-05-31  5:49     ` Cédric Le Goater
2022-05-30 17:40   ` Philippe Mathieu-Daudé via
2022-05-31  5:58     ` Cédric Le Goater
2022-05-31  8:03       ` Philippe Mathieu-Daudé via
2022-05-31  8:18         ` Cédric Le Goater
2022-05-30 18:29   ` Philippe Mathieu-Daudé via
2022-05-31  6:01     ` Cédric Le Goater
2022-03-18 13:28 ` [RFC PATCH 12/17] hw/sd: Fix SET_BLOCK_COUNT command argument Cédric Le Goater
2022-03-18 13:28 ` [RFC PATCH 13/17] hw/sd: Update CMD1 definition for MMC Cédric Le Goater
2022-03-18 13:28 ` [RFC PATCH 14/17] hw/sd: Add CMD21 tuning sequence Cédric Le Goater
2022-03-18 13:28 ` [RFC PATCH 15/17] hw/sd: Add mmc switch function support Cédric Le Goater
2022-03-18 13:28 ` [RFC PATCH 16/17] hw/sd: Support boot area in emmc image Cédric Le Goater
2022-03-18 13:28 ` [RFC PATCH 17/17] hw/sd: Subtract bootarea size from blk Cédric Le Goater
2022-05-09 21:22   ` Philippe Mathieu-Daudé via
2022-04-21  6:48 ` [RFC PATCH 00/17] hw/sd: Rework models for eMMC support Cédric Le Goater

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4c2faa25-d7b3-1a69-587f-f93183327f91@linaro.org \
    --to=jerome.forissier@linaro.org \
    --cc=bin.meng@windriver.com \
    --cc=clg@kaod.org \
    --cc=joel@jms.id.au \
    --cc=philmd@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=vpalatin@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).