qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Cédric Le Goater" <clg@kaod.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: Vincent Palatin <vpalatin@chromium.org>, <qemu-block@nongnu.org>,
	Bin Meng <bin.meng@windriver.com>, <qemu-devel@nongnu.org>,
	Joel Stanley <joel@jms.id.au>
Subject: Re: [RFC PATCH 11/17] hw/sd: Add eMMC support
Date: Tue, 10 May 2022 09:15:48 +0200	[thread overview]
Message-ID: <cae0e46b-af2c-88ff-fa45-8362abc25886@kaod.org> (raw)
In-Reply-To: <ce8fcf3f-c56b-ed68-bd5a-7e599b951aa6@amsat.org>

[ ... ]


> Do you mind splitting as:
> 
> - Add TYPE_EMMC, emmc_class_init and sd_proto_emmc[] with
>    already existing handlers (1 patch)
> 
> - Add new handlers, from smaller to sd_emmc_set_csd(),
>    and finally mmc_set_ext_csd() with the EXT_CSD definitions
>    (various patches).

Sure, I will reorganize the patchset. It will ease the review.

> Otherwise LGTM!
> 
> What is your test suite?

Not simple.

Get the latest FW images for the rainier platform from :

   https://jenkins.openbmc.org/view/latest/job/latest-master/label=docker-builder,target=p10bmc/lastSuccessfulBuild/artifact/openbmc/build/tmp/deploy/images/p10bmc/

and build a bootable eMMC with such a sequence :

   dd of=$mmc if=/dev/zero bs=1M count=128
   dd of=$mmc if=${fw_dir}/u-boot-spl.bin conv=notrunc
   dd of=$mmc if=${fw_dir}/u-boot.bin conv=notrunc bs=1K seek=64
   dd of=$mmc if=${fw_dir}/u-boot-env.bin conv=notrunc bs=1K seek=$((896 + 64))
     
   xzdec $wicxz | dd status=progress of=$mmc conv=notrunc bs=1M seek=2
   truncate --size 16G $mmc

We could have a smaller image with a buildroot rootfs.

Then, boot with:

   qemu-system-arm -M rainier-bmc -net nic,netdev=net0 -netdev user \
	-drive file=$mmc.qcow2,format=qcow2,if=sd,id=sd0,index=2

The Aspeed machines (AST2600) can boot from flash or eMMC and the above
command line does the trick. It is not optimal.


Thanks,

C.


  reply	other threads:[~2022-05-10  7:18 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-18 13:28 [RFC PATCH 00/17] hw/sd: Rework models for eMMC support Cédric Le Goater
2022-03-18 13:28 ` [RFC PATCH 01/17] hw/sd: When card is in wrong state, log which state it is Cédric Le Goater
2022-03-18 13:28 ` [RFC PATCH 02/17] hw/sd: Move proto_name to SDProto structure Cédric Le Goater
2022-03-18 13:28 ` [RFC PATCH 03/17] hw/sd: Introduce sd_cmd_handler type Cédric Le Goater
2022-03-18 13:28 ` [RFC PATCH 04/17] hw/sd: Add sd_cmd_illegal() handler Cédric Le Goater
2022-03-18 13:28 ` [RFC PATCH 05/17] hw/sd: Add sd_cmd_unimplemented() handler Cédric Le Goater
2022-03-18 13:28 ` [RFC PATCH 06/17] hw/sd: Add sd_cmd_GO_IDLE_STATE() handler Cédric Le Goater
2022-03-18 13:28 ` [RFC PATCH 07/17] hw/sd: Add sd_cmd_SEND_OP_CMD() handler Cédric Le Goater
2022-05-09 21:12   ` Philippe Mathieu-Daudé via
2022-05-10  6:57     ` Cédric Le Goater
2022-05-30 17:25       ` Philippe Mathieu-Daudé via
2022-03-18 13:28 ` [RFC PATCH 08/17] hw/sd: Add sd_cmd_ALL_SEND_CID() handler Cédric Le Goater
2022-03-18 13:28 ` [RFC PATCH 09/17] hw/sd: Add sd_cmd_SEND_RELATIVE_ADDR() handler Cédric Le Goater
2022-03-18 13:28 ` [RFC PATCH 10/17] hw/sd: Add sd_cmd_SEND_TUNING_BLOCK() handler Cédric Le Goater
2022-05-09 21:05   ` Philippe Mathieu-Daudé via
2022-05-10  6:57     ` Cédric Le Goater
2022-03-18 13:28 ` [RFC PATCH 11/17] hw/sd: Add eMMC support Cédric Le Goater
2022-03-28 12:10   ` Jerome Forissier
2022-03-28 14:13     ` Cédric Le Goater
2022-05-09 21:17   ` Philippe Mathieu-Daudé via
2022-05-10  7:15     ` Cédric Le Goater [this message]
2022-05-10 13:53       ` Cédric Le Goater
2022-05-30 17:02   ` Philippe Mathieu-Daudé via
2022-05-31  5:49     ` Cédric Le Goater
2022-05-30 17:40   ` Philippe Mathieu-Daudé via
2022-05-31  5:58     ` Cédric Le Goater
2022-05-31  8:03       ` Philippe Mathieu-Daudé via
2022-05-31  8:18         ` Cédric Le Goater
2022-05-30 18:29   ` Philippe Mathieu-Daudé via
2022-05-31  6:01     ` Cédric Le Goater
2022-03-18 13:28 ` [RFC PATCH 12/17] hw/sd: Fix SET_BLOCK_COUNT command argument Cédric Le Goater
2022-03-18 13:28 ` [RFC PATCH 13/17] hw/sd: Update CMD1 definition for MMC Cédric Le Goater
2022-03-18 13:28 ` [RFC PATCH 14/17] hw/sd: Add CMD21 tuning sequence Cédric Le Goater
2022-03-18 13:28 ` [RFC PATCH 15/17] hw/sd: Add mmc switch function support Cédric Le Goater
2022-03-18 13:28 ` [RFC PATCH 16/17] hw/sd: Support boot area in emmc image Cédric Le Goater
2022-03-18 13:28 ` [RFC PATCH 17/17] hw/sd: Subtract bootarea size from blk Cédric Le Goater
2022-05-09 21:22   ` Philippe Mathieu-Daudé via
2022-04-21  6:48 ` [RFC PATCH 00/17] hw/sd: Rework models for eMMC support Cédric Le Goater

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cae0e46b-af2c-88ff-fa45-8362abc25886@kaod.org \
    --to=clg@kaod.org \
    --cc=bin.meng@windriver.com \
    --cc=f4bug@amsat.org \
    --cc=joel@jms.id.au \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=vpalatin@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).