* [PATCH] fuzz: Avoid deprecated misuse of -drive if=sd
@ 2021-03-19 13:20 Markus Armbruster
2021-03-19 14:08 ` Philippe Mathieu-Daudé
2021-03-19 14:40 ` Alexander Bulekov
0 siblings, 2 replies; 4+ messages in thread
From: Markus Armbruster @ 2021-03-19 13:20 UTC (permalink / raw)
To: qemu-devel; +Cc: lvivier, thuth, alxndr, bsd, stefanha, pbonzini
qemu-fuzz-i386-target-generic-fuzz-sdhci-v3 uses -drive=sd where it
should use -drive if=none instead. This prints a deprecation warning:
$ ./build-oss-fuzz/DEST_DIR/qemu-fuzz-i386-target-generic-fuzz-sdhci-v3 -runs=1 -seed=1
[ASan warnings snipped...]
--> i386: -drive if=sd,index=0,file=null-co://,format=raw,id=mydrive: warning: bogus if=sd is deprecated, use if=none
INFO: Seed: 1
[More normal output snipped...]
Support for this usage will be gone soon. Adjust the test.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
tests/qtest/fuzz/generic_fuzz_configs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qtest/fuzz/generic_fuzz_configs.h b/tests/qtest/fuzz/generic_fuzz_configs.h
index 8b8c7ac553..004c701915 100644
--- a/tests/qtest/fuzz/generic_fuzz_configs.h
+++ b/tests/qtest/fuzz/generic_fuzz_configs.h
@@ -182,7 +182,7 @@ const generic_fuzz_config predefined_configs[] = {
.name = "sdhci-v3",
.args = "-nodefaults -device sdhci-pci,sd-spec-version=3 "
"-device sd-card,drive=mydrive "
- "-drive if=sd,index=0,file=null-co://,format=raw,id=mydrive -nographic",
+ "-drive if=none,index=0,file=null-co://,format=raw,id=mydrive -nographic",
.objects = "sd*"
},{
.name = "ehci",
--
2.26.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] fuzz: Avoid deprecated misuse of -drive if=sd
2021-03-19 13:20 [PATCH] fuzz: Avoid deprecated misuse of -drive if=sd Markus Armbruster
@ 2021-03-19 14:08 ` Philippe Mathieu-Daudé
2021-03-19 14:40 ` Alexander Bulekov
1 sibling, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-03-19 14:08 UTC (permalink / raw)
To: Markus Armbruster, qemu-devel
Cc: lvivier, thuth, alxndr, bsd, stefanha, pbonzini
On 3/19/21 2:20 PM, Markus Armbruster wrote:
> qemu-fuzz-i386-target-generic-fuzz-sdhci-v3 uses -drive=sd where it
> should use -drive if=none instead. This prints a deprecation warning:
>
> $ ./build-oss-fuzz/DEST_DIR/qemu-fuzz-i386-target-generic-fuzz-sdhci-v3 -runs=1 -seed=1
> [ASan warnings snipped...]
> --> i386: -drive if=sd,index=0,file=null-co://,format=raw,id=mydrive: warning: bogus if=sd is deprecated, use if=none
> INFO: Seed: 1
> [More normal output snipped...]
>
> Support for this usage will be gone soon. Adjust the test.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> tests/qtest/fuzz/generic_fuzz_configs.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] fuzz: Avoid deprecated misuse of -drive if=sd
2021-03-19 13:20 [PATCH] fuzz: Avoid deprecated misuse of -drive if=sd Markus Armbruster
2021-03-19 14:08 ` Philippe Mathieu-Daudé
@ 2021-03-19 14:40 ` Alexander Bulekov
2021-03-22 14:20 ` Philippe Mathieu-Daudé
1 sibling, 1 reply; 4+ messages in thread
From: Alexander Bulekov @ 2021-03-19 14:40 UTC (permalink / raw)
To: Markus Armbruster; +Cc: lvivier, thuth, qemu-devel, bsd, stefanha, pbonzini
On 210319 1420, Markus Armbruster wrote:
> qemu-fuzz-i386-target-generic-fuzz-sdhci-v3 uses -drive=sd where it
> should use -drive if=none instead. This prints a deprecation warning:
>
> $ ./build-oss-fuzz/DEST_DIR/qemu-fuzz-i386-target-generic-fuzz-sdhci-v3 -runs=1 -seed=1
> [ASan warnings snipped...]
> --> i386: -drive if=sd,index=0,file=null-co://,format=raw,id=mydrive: warning: bogus if=sd is deprecated, use if=none
> INFO: Seed: 1
> [More normal output snipped...]
>
> Support for this usage will be gone soon. Adjust the test.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> tests/qtest/fuzz/generic_fuzz_configs.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Alexander Bulekov <alxndr@bu.edu>
Thanks
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] fuzz: Avoid deprecated misuse of -drive if=sd
2021-03-19 14:40 ` Alexander Bulekov
@ 2021-03-22 14:20 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-03-22 14:20 UTC (permalink / raw)
To: Alexander Bulekov, Markus Armbruster, pbonzini
Cc: lvivier, thuth, bsd, qemu-devel, stefanha
On 3/19/21 3:40 PM, Alexander Bulekov wrote:
> On 210319 1420, Markus Armbruster wrote:
>> qemu-fuzz-i386-target-generic-fuzz-sdhci-v3 uses -drive=sd where it
>> should use -drive if=none instead. This prints a deprecation warning:
>>
>> $ ./build-oss-fuzz/DEST_DIR/qemu-fuzz-i386-target-generic-fuzz-sdhci-v3 -runs=1 -seed=1
>> [ASan warnings snipped...]
>> --> i386: -drive if=sd,index=0,file=null-co://,format=raw,id=mydrive: warning: bogus if=sd is deprecated, use if=none
>> INFO: Seed: 1
>> [More normal output snipped...]
>>
>> Support for this usage will be gone soon. Adjust the test.
>>
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> ---
>> tests/qtest/fuzz/generic_fuzz_configs.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>
> Reviewed-by: Alexander Bulekov <alxndr@bu.edu>
This patch doesn't apply:
$ git am -s 20210319_armbru_fuzz_avoid_deprecated_misuse_of_drive_if_sd.mbx
Applying: fuzz: Avoid deprecated misuse of -drive if=sd
error: patch failed: tests/qtest/fuzz/generic_fuzz_configs.h:182
error: tests/qtest/fuzz/generic_fuzz_configs.h: patch does not apply
Patch failed at 0001 fuzz: Avoid deprecated misuse of -drive if=sd
hint: Use 'git am --show-current-patch=diff' to see the failed patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Which makes sense because it is already in the tree as commit
9585376ab5e.
To ease maintainer/reviewers email based workflow, does it make
sense to configure patchew to reply "this patch/series has been
merged as sha1..range" or or "this patch/series has been superseded
by this one: [link of v(N+1)]"?
Thanks,
Phil.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-03-22 15:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-19 13:20 [PATCH] fuzz: Avoid deprecated misuse of -drive if=sd Markus Armbruster
2021-03-19 14:08 ` Philippe Mathieu-Daudé
2021-03-19 14:40 ` Alexander Bulekov
2021-03-22 14:20 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).