From: "Wu, Fei" <fei2.wu@intel.com>
To: Daniel Henrique Barboza <dbarboza@ventanamicro.com>,
Richard Henderson <richard.henderson@linaro.org>,
<qemu-devel@nongnu.org>
Cc: <qemu-riscv@nongnu.org>, <alistair.francis@wdc.com>,
<palmer@dabbelt.com>, <zhiwei_liu@linux.alibaba.com>
Subject: Re: [PATCH v6 00/25] target/riscv: MSTATUS_SUM + cleanups
Date: Tue, 28 Mar 2023 09:22:01 +0800 [thread overview]
Message-ID: <74eaedfd-73ca-002c-f6bd-6b74628ef5ba@intel.com> (raw)
In-Reply-To: <e36dba97-c182-c427-e051-2a8d1cfe96a8@ventanamicro.com>
On 3/28/2023 12:43 AM, Daniel Henrique Barboza wrote:
>
>
> On 3/25/23 07:54, Richard Henderson wrote:
>> This builds on Fei and Zhiwei's SUM and TB_FLAGS changes.
>>
>> * Reclaim 5 TB_FLAGS bits, since we nearly ran out.
>>
>> * Using cpu_mmu_index(env, true) is insufficient to implement
>> HLVX properly. While that chooses the correct mmu_idx, it
>> does not perform the read with execute permission.
>> I add a new tcg interface to perform a read-for-execute with
>> an arbitrary mmu_idx. This is still not 100% compliant, but
>> it's closer.
>>
>> * Handle mstatus.MPV in cpu_mmu_index.
>> * Use vsstatus.SUM when required for MMUIdx_S_SUM.
>> * Cleanups for get_physical_address.
>>
>> While this passes check-avocado, I'm sure that's insufficient.
>> Please have a close look.
>
> Tested fine in my end with some buildroot tests and 'stress-ng' in a 'virt'
> machine with Ubuntu.
>
> Tested-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
>
Great. I suppose class 'os' in stress-ng should see performance boost too.
btw, Is there any public URL for us to check QEMU regressions and
performance data?
Thanks,
Fei.
>>
>>
>> r~
>>
>>
>> Fei Wu (2):
>> target/riscv: Separate priv from mmu_idx
>> target/riscv: Reduce overhead of MSTATUS_SUM change
>>
>> LIU Zhiwei (4):
>> target/riscv: Extract virt enabled state from tb flags
>> target/riscv: Add a general status enum for extensions
>> target/riscv: Encode the FS and VS on a normal way for tb flags
>> target/riscv: Add a tb flags field for vstart
>>
>> Richard Henderson (19):
>> target/riscv: Remove mstatus_hs_{fs,vs} from tb_flags
>> accel/tcg: Add cpu_ld*_code_mmu
>> target/riscv: Use cpu_ld*_code_mmu for HLVX
>> target/riscv: Handle HLV, HSV via helpers
>> target/riscv: Rename MMU_HYP_ACCESS_BIT to MMU_2STAGE_BIT
>> target/riscv: Introduce mmuidx_sum
>> target/riscv: Introduce mmuidx_priv
>> target/riscv: Introduce mmuidx_2stage
>> target/riscv: Move hstatus.spvp check to check_access_hlsv
>> target/riscv: Set MMU_2STAGE_BIT in riscv_cpu_mmu_index
>> target/riscv: Check SUM in the correct register
>> target/riscv: Hoist second stage mode change to callers
>> target/riscv: Hoist pbmte and hade out of the level loop
>> target/riscv: Move leaf pte processing out of level loop
>> target/riscv: Suppress pte update with is_debug
>> target/riscv: Don't modify SUM with is_debug
>> target/riscv: Merge checks for reserved pte flags
>> target/riscv: Reorg access check in get_physical_address
>> target/riscv: Reorg sum check in get_physical_address
>>
>> include/exec/cpu_ldst.h | 9 +
>> target/riscv/cpu.h | 47 ++-
>> target/riscv/cpu_bits.h | 12 +-
>> target/riscv/helper.h | 12 +-
>> target/riscv/internals.h | 35 ++
>> accel/tcg/cputlb.c | 48 +++
>> accel/tcg/user-exec.c | 58 +++
>> target/riscv/cpu.c | 2 +-
>> target/riscv/cpu_helper.c | 393 +++++++++---------
>> target/riscv/csr.c | 21 +-
>> target/riscv/op_helper.c | 113 ++++-
>> target/riscv/translate.c | 72 ++--
>> .../riscv/insn_trans/trans_privileged.c.inc | 2 +-
>> target/riscv/insn_trans/trans_rvf.c.inc | 2 +-
>> target/riscv/insn_trans/trans_rvh.c.inc | 135 +++---
>> target/riscv/insn_trans/trans_rvv.c.inc | 22 +-
>> target/riscv/insn_trans/trans_xthead.c.inc | 7 +-
>> 17 files changed, 595 insertions(+), 395 deletions(-)
>>
next prev parent reply other threads:[~2023-03-28 1:23 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-25 10:54 [PATCH v6 00/25] target/riscv: MSTATUS_SUM + cleanups Richard Henderson
2023-03-25 10:54 ` [PATCH v6 01/25] target/riscv: Extract virt enabled state from tb flags Richard Henderson
2023-04-06 2:35 ` Alistair Francis
2023-03-25 10:54 ` [PATCH v6 02/25] target/riscv: Add a general status enum for extensions Richard Henderson
2023-03-26 12:54 ` liweiwei
2023-04-11 2:05 ` Alistair Francis
2023-03-25 10:54 ` [PATCH v6 03/25] target/riscv: Encode the FS and VS on a normal way for tb flags Richard Henderson
2023-04-11 1:59 ` Alistair Francis
2023-03-25 10:54 ` [PATCH v6 04/25] target/riscv: Remove mstatus_hs_{fs, vs} from tb_flags Richard Henderson
2023-03-27 1:34 ` liweiwei
2023-03-27 16:22 ` Richard Henderson
2023-03-28 2:34 ` [PATCH v6 04/25] target/riscv: Remove mstatus_hs_{fs,vs} " LIU Zhiwei
2023-04-11 2:02 ` [PATCH v6 04/25] target/riscv: Remove mstatus_hs_{fs, vs} " Alistair Francis
2023-03-25 10:54 ` [PATCH v6 05/25] target/riscv: Add a tb flags field for vstart Richard Henderson
2023-04-11 2:07 ` Alistair Francis
2023-03-25 10:54 ` [PATCH v6 06/25] target/riscv: Separate priv from mmu_idx Richard Henderson
2023-03-28 2:39 ` LIU Zhiwei
2023-04-11 2:08 ` Alistair Francis
2023-03-25 10:54 ` [PATCH v6 07/25] target/riscv: Reduce overhead of MSTATUS_SUM change Richard Henderson
2023-03-28 2:41 ` LIU Zhiwei
2023-04-11 2:11 ` Alistair Francis
2023-03-25 10:54 ` [PATCH v6 08/25] accel/tcg: Add cpu_ld*_code_mmu Richard Henderson
2023-04-11 3:10 ` Alistair Francis
2023-03-25 10:54 ` [PATCH v6 09/25] target/riscv: Use cpu_ld*_code_mmu for HLVX Richard Henderson
2023-04-11 3:12 ` Alistair Francis
2023-03-25 10:54 ` [PATCH v6 10/25] target/riscv: Handle HLV, HSV via helpers Richard Henderson
2023-04-11 3:34 ` Alistair Francis
2023-03-25 10:54 ` [PATCH v6 11/25] target/riscv: Rename MMU_HYP_ACCESS_BIT to MMU_2STAGE_BIT Richard Henderson
2023-04-11 3:36 ` Alistair Francis
2023-03-25 10:54 ` [PATCH v6 12/25] target/riscv: Introduce mmuidx_sum Richard Henderson
2023-04-11 3:39 ` Alistair Francis
2023-03-25 10:54 ` [PATCH v6 13/25] target/riscv: Introduce mmuidx_priv Richard Henderson
2023-03-27 2:07 ` LIU Zhiwei
2023-03-27 16:29 ` Richard Henderson
2023-03-28 1:33 ` LIU Zhiwei
2023-03-28 1:54 ` LIU Zhiwei
2023-03-28 14:27 ` Richard Henderson
2023-04-11 3:53 ` Alistair Francis
2023-03-25 10:54 ` [PATCH v6 14/25] target/riscv: Introduce mmuidx_2stage Richard Henderson
2023-04-11 3:55 ` Alistair Francis
2023-03-25 10:54 ` [PATCH v6 15/25] target/riscv: Move hstatus.spvp check to check_access_hlsv Richard Henderson
2023-04-11 3:56 ` Alistair Francis
2023-03-25 10:54 ` [PATCH v6 16/25] target/riscv: Set MMU_2STAGE_BIT in riscv_cpu_mmu_index Richard Henderson
2023-04-11 4:02 ` Alistair Francis
2023-03-25 10:54 ` [PATCH v6 17/25] target/riscv: Check SUM in the correct register Richard Henderson
2023-04-11 4:25 ` Alistair Francis
2023-03-25 10:54 ` [PATCH v6 18/25] target/riscv: Hoist second stage mode change to callers Richard Henderson
2023-04-11 4:25 ` Alistair Francis
2023-03-25 10:54 ` [PATCH v6 19/25] target/riscv: Hoist pbmte and hade out of the level loop Richard Henderson
2023-04-11 4:26 ` Alistair Francis
2023-03-25 10:54 ` [PATCH v6 20/25] target/riscv: Move leaf pte processing out of " Richard Henderson
2023-04-11 4:30 ` Alistair Francis
2023-03-25 10:54 ` [PATCH v6 21/25] target/riscv: Suppress pte update with is_debug Richard Henderson
2023-04-11 4:30 ` Alistair Francis
2023-03-25 10:54 ` [PATCH v6 22/25] target/riscv: Don't modify SUM " Richard Henderson
2023-04-11 4:31 ` Alistair Francis
2023-03-25 10:54 ` [PATCH v6 23/25] target/riscv: Merge checks for reserved pte flags Richard Henderson
2023-04-11 4:32 ` Alistair Francis
2023-03-25 10:54 ` [PATCH v6 24/25] target/riscv: Reorg access check in get_physical_address Richard Henderson
2023-04-11 4:55 ` Alistair Francis
2023-03-25 10:54 ` [PATCH v6 25/25] target/riscv: Reorg sum " Richard Henderson
2023-04-11 5:36 ` Alistair Francis
2023-03-26 5:17 ` [PATCH v6 00/25] target/riscv: MSTATUS_SUM + cleanups Richard Henderson
2023-03-26 14:18 ` liweiwei
2023-03-27 16:43 ` Daniel Henrique Barboza
2023-03-28 1:22 ` Wu, Fei [this message]
2023-04-04 6:42 ` Wu, Fei
2023-04-04 7:11 ` LIU Zhiwei
2023-04-04 7:23 ` Wu, Fei
2023-04-11 5:38 ` Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74eaedfd-73ca-002c-f6bd-6b74628ef5ba@intel.com \
--to=fei2.wu@intel.com \
--cc=alistair.francis@wdc.com \
--cc=dbarboza@ventanamicro.com \
--cc=palmer@dabbelt.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=zhiwei_liu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).