* [PATCH] Constify bitmask_transtbl fcntl/mmap flags_tlb[]
@ 2021-05-11 10:35 Philippe Mathieu-Daudé
2021-05-11 16:53 ` Richard Henderson
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-05-11 10:35 UTC (permalink / raw)
To: qemu-devel; +Cc: Laurent Vivier, Philippe Mathieu-Daudé
Keep bitmask_transtbl in .rodata by marking the arrays const.
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
linux-user/syscall.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 95d79ddc437..64f486743a9 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -365,7 +365,7 @@ _syscall5(int, sys_statx, int, dirfd, const char *, pathname, int, flags,
_syscall2(int, membarrier, int, cmd, int, flags)
#endif
-static bitmask_transtbl fcntl_flags_tbl[] = {
+static const bitmask_transtbl fcntl_flags_tbl[] = {
{ TARGET_O_ACCMODE, TARGET_O_WRONLY, O_ACCMODE, O_WRONLY, },
{ TARGET_O_ACCMODE, TARGET_O_RDWR, O_ACCMODE, O_RDWR, },
{ TARGET_O_CREAT, TARGET_O_CREAT, O_CREAT, O_CREAT, },
@@ -6062,7 +6062,7 @@ static const StructEntry struct_termios_def = {
.print = print_termios,
};
-static bitmask_transtbl mmap_flags_tbl[] = {
+static const bitmask_transtbl mmap_flags_tbl[] = {
{ TARGET_MAP_SHARED, TARGET_MAP_SHARED, MAP_SHARED, MAP_SHARED },
{ TARGET_MAP_PRIVATE, TARGET_MAP_PRIVATE, MAP_PRIVATE, MAP_PRIVATE },
{ TARGET_MAP_FIXED, TARGET_MAP_FIXED, MAP_FIXED, MAP_FIXED },
--
2.26.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Constify bitmask_transtbl fcntl/mmap flags_tlb[]
2021-05-11 10:35 [PATCH] Constify bitmask_transtbl fcntl/mmap flags_tlb[] Philippe Mathieu-Daudé
@ 2021-05-11 16:53 ` Richard Henderson
2021-05-12 11:16 ` Laurent Vivier
2021-05-17 2:14 ` Bin Meng
2 siblings, 0 replies; 4+ messages in thread
From: Richard Henderson @ 2021-05-11 16:53 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel; +Cc: Laurent Vivier
On 5/11/21 5:35 AM, Philippe Mathieu-Daudé wrote:
> Keep bitmask_transtbl in .rodata by marking the arrays const.
>
> Signed-off-by: Philippe Mathieu-Daudé<f4bug@amsat.org>
> ---
> linux-user/syscall.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Constify bitmask_transtbl fcntl/mmap flags_tlb[]
2021-05-11 10:35 [PATCH] Constify bitmask_transtbl fcntl/mmap flags_tlb[] Philippe Mathieu-Daudé
2021-05-11 16:53 ` Richard Henderson
@ 2021-05-12 11:16 ` Laurent Vivier
2021-05-17 2:14 ` Bin Meng
2 siblings, 0 replies; 4+ messages in thread
From: Laurent Vivier @ 2021-05-12 11:16 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Le 11/05/2021 à 12:35, Philippe Mathieu-Daudé a écrit :
> Keep bitmask_transtbl in .rodata by marking the arrays const.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> linux-user/syscall.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index 95d79ddc437..64f486743a9 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -365,7 +365,7 @@ _syscall5(int, sys_statx, int, dirfd, const char *, pathname, int, flags,
> _syscall2(int, membarrier, int, cmd, int, flags)
> #endif
>
> -static bitmask_transtbl fcntl_flags_tbl[] = {
> +static const bitmask_transtbl fcntl_flags_tbl[] = {
> { TARGET_O_ACCMODE, TARGET_O_WRONLY, O_ACCMODE, O_WRONLY, },
> { TARGET_O_ACCMODE, TARGET_O_RDWR, O_ACCMODE, O_RDWR, },
> { TARGET_O_CREAT, TARGET_O_CREAT, O_CREAT, O_CREAT, },
> @@ -6062,7 +6062,7 @@ static const StructEntry struct_termios_def = {
> .print = print_termios,
> };
>
> -static bitmask_transtbl mmap_flags_tbl[] = {
> +static const bitmask_transtbl mmap_flags_tbl[] = {
> { TARGET_MAP_SHARED, TARGET_MAP_SHARED, MAP_SHARED, MAP_SHARED },
> { TARGET_MAP_PRIVATE, TARGET_MAP_PRIVATE, MAP_PRIVATE, MAP_PRIVATE },
> { TARGET_MAP_FIXED, TARGET_MAP_FIXED, MAP_FIXED, MAP_FIXED },
>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Constify bitmask_transtbl fcntl/mmap flags_tlb[]
2021-05-11 10:35 [PATCH] Constify bitmask_transtbl fcntl/mmap flags_tlb[] Philippe Mathieu-Daudé
2021-05-11 16:53 ` Richard Henderson
2021-05-12 11:16 ` Laurent Vivier
@ 2021-05-17 2:14 ` Bin Meng
2 siblings, 0 replies; 4+ messages in thread
From: Bin Meng @ 2021-05-17 2:14 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: qemu-devel@nongnu.org Developers, Laurent Vivier
On Tue, May 11, 2021 at 6:51 PM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> Keep bitmask_transtbl in .rodata by marking the arrays const.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> linux-user/syscall.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-05-17 2:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-11 10:35 [PATCH] Constify bitmask_transtbl fcntl/mmap flags_tlb[] Philippe Mathieu-Daudé
2021-05-11 16:53 ` Richard Henderson
2021-05-12 11:16 ` Laurent Vivier
2021-05-17 2:14 ` Bin Meng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).