* [PATCH] qcow2: use external virtual timers
@ 2021-03-23 11:08 Pavel Dovgalyuk
2021-03-23 12:44 ` Paolo Bonzini
0 siblings, 1 reply; 5+ messages in thread
From: Pavel Dovgalyuk @ 2021-03-23 11:08 UTC (permalink / raw)
To: qemu-devel; +Cc: kwolf, pbonzini, pavel.dovgalyuk, mreitz
Regular virtual timers are used to emulate timings
related to vCPU and peripheral states. QCOW2 uses timers
to clean the cache. These timers should have external
flag. In the opposite case they affect the execution
and it can't be recorded and replayed.
This patch adds external flag to the timer for qcow2
cache clean.
Signed-off-by: Pavel Dovgalyuk <Pavel.Dovgalyuk@ispras.ru>
---
block/qcow2.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/block/qcow2.c b/block/qcow2.c
index 0db1227ac9..2fb43c6f7e 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -840,9 +840,10 @@ static void cache_clean_timer_init(BlockDriverState *bs, AioContext *context)
{
BDRVQcow2State *s = bs->opaque;
if (s->cache_clean_interval > 0) {
- s->cache_clean_timer = aio_timer_new(context, QEMU_CLOCK_VIRTUAL,
- SCALE_MS, cache_clean_timer_cb,
- bs);
+ s->cache_clean_timer =
+ aio_timer_new_with_attrs(context, QEMU_CLOCK_VIRTUAL,
+ SCALE_MS, QEMU_TIMER_ATTR_EXTERNAL,
+ cache_clean_timer_cb, bs);
timer_mod(s->cache_clean_timer, qemu_clock_get_ms(QEMU_CLOCK_VIRTUAL) +
(int64_t) s->cache_clean_interval * 1000);
}
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] qcow2: use external virtual timers
2021-03-23 11:08 [PATCH] qcow2: use external virtual timers Pavel Dovgalyuk
@ 2021-03-23 12:44 ` Paolo Bonzini
0 siblings, 0 replies; 5+ messages in thread
From: Paolo Bonzini @ 2021-03-23 12:44 UTC (permalink / raw)
To: Pavel Dovgalyuk, qemu-devel; +Cc: kwolf, mreitz
On 23/03/21 12:08, Pavel Dovgalyuk wrote:
> Regular virtual timers are used to emulate timings
> related to vCPU and peripheral states. QCOW2 uses timers
> to clean the cache. These timers should have external
> flag. In the opposite case they affect the execution
> and it can't be recorded and replayed.
> This patch adds external flag to the timer for qcow2
> cache clean.
>
> Signed-off-by: Pavel Dovgalyuk <Pavel.Dovgalyuk@ispras.ru>
> ---
> block/qcow2.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/block/qcow2.c b/block/qcow2.c
> index 0db1227ac9..2fb43c6f7e 100644
> --- a/block/qcow2.c
> +++ b/block/qcow2.c
> @@ -840,9 +840,10 @@ static void cache_clean_timer_init(BlockDriverState *bs, AioContext *context)
> {
> BDRVQcow2State *s = bs->opaque;
> if (s->cache_clean_interval > 0) {
> - s->cache_clean_timer = aio_timer_new(context, QEMU_CLOCK_VIRTUAL,
> - SCALE_MS, cache_clean_timer_cb,
> - bs);
> + s->cache_clean_timer =
> + aio_timer_new_with_attrs(context, QEMU_CLOCK_VIRTUAL,
> + SCALE_MS, QEMU_TIMER_ATTR_EXTERNAL,
> + cache_clean_timer_cb, bs);
> timer_mod(s->cache_clean_timer, qemu_clock_get_ms(QEMU_CLOCK_VIRTUAL) +
> (int64_t) s->cache_clean_interval * 1000);
> }
>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] qcow2: use external virtual timers
@ 2021-03-29 8:06 Pavel Dovgalyuk
2021-03-29 9:42 ` Paolo Bonzini
2021-03-29 16:04 ` Max Reitz
0 siblings, 2 replies; 5+ messages in thread
From: Pavel Dovgalyuk @ 2021-03-29 8:06 UTC (permalink / raw)
To: qemu-devel; +Cc: kwolf, pbonzini, pavel.dovgalyuk, mreitz
Regular virtual timers are used to emulate timings
related to vCPU and peripheral states. QCOW2 uses timers
to clean the cache. These timers should have external
flag. In the opposite case they affect the execution
and it can't be recorded and replayed.
This patch adds external flag to the timer for qcow2
cache clean.
Signed-off-by: Pavel Dovgalyuk <Pavel.Dovgalyuk@ispras.ru>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
---
block/qcow2.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/block/qcow2.c b/block/qcow2.c
index 0db1227ac9..2fb43c6f7e 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -840,9 +840,10 @@ static void cache_clean_timer_init(BlockDriverState *bs, AioContext *context)
{
BDRVQcow2State *s = bs->opaque;
if (s->cache_clean_interval > 0) {
- s->cache_clean_timer = aio_timer_new(context, QEMU_CLOCK_VIRTUAL,
- SCALE_MS, cache_clean_timer_cb,
- bs);
+ s->cache_clean_timer =
+ aio_timer_new_with_attrs(context, QEMU_CLOCK_VIRTUAL,
+ SCALE_MS, QEMU_TIMER_ATTR_EXTERNAL,
+ cache_clean_timer_cb, bs);
timer_mod(s->cache_clean_timer, qemu_clock_get_ms(QEMU_CLOCK_VIRTUAL) +
(int64_t) s->cache_clean_interval * 1000);
}
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] qcow2: use external virtual timers
2021-03-29 8:06 Pavel Dovgalyuk
@ 2021-03-29 9:42 ` Paolo Bonzini
2021-03-29 16:04 ` Max Reitz
1 sibling, 0 replies; 5+ messages in thread
From: Paolo Bonzini @ 2021-03-29 9:42 UTC (permalink / raw)
To: Pavel Dovgalyuk, qemu-devel; +Cc: kwolf, qemu block, mreitz
On 29/03/21 10:06, Pavel Dovgalyuk wrote:
> Regular virtual timers are used to emulate timings
> related to vCPU and peripheral states. QCOW2 uses timers
> to clean the cache. These timers should have external
> flag. In the opposite case they affect the execution
> and it can't be recorded and replayed.
> This patch adds external flag to the timer for qcow2
> cache clean.
>
> Signed-off-by: Pavel Dovgalyuk <Pavel.Dovgalyuk@ispras.ru>
> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> block/qcow2.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/block/qcow2.c b/block/qcow2.c
> index 0db1227ac9..2fb43c6f7e 100644
> --- a/block/qcow2.c
> +++ b/block/qcow2.c
> @@ -840,9 +840,10 @@ static void cache_clean_timer_init(BlockDriverState *bs, AioContext *context)
> {
> BDRVQcow2State *s = bs->opaque;
> if (s->cache_clean_interval > 0) {
> - s->cache_clean_timer = aio_timer_new(context, QEMU_CLOCK_VIRTUAL,
> - SCALE_MS, cache_clean_timer_cb,
> - bs);
> + s->cache_clean_timer =
> + aio_timer_new_with_attrs(context, QEMU_CLOCK_VIRTUAL,
> + SCALE_MS, QEMU_TIMER_ATTR_EXTERNAL,
> + cache_clean_timer_cb, bs);
> timer_mod(s->cache_clean_timer, qemu_clock_get_ms(QEMU_CLOCK_VIRTUAL) +
> (int64_t) s->cache_clean_interval * 1000);
> }
>
Cc: qemu-block@nongnu.org
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] qcow2: use external virtual timers
2021-03-29 8:06 Pavel Dovgalyuk
2021-03-29 9:42 ` Paolo Bonzini
@ 2021-03-29 16:04 ` Max Reitz
1 sibling, 0 replies; 5+ messages in thread
From: Max Reitz @ 2021-03-29 16:04 UTC (permalink / raw)
To: Pavel Dovgalyuk, qemu-devel; +Cc: kwolf, pbonzini
On 29.03.21 10:06, Pavel Dovgalyuk wrote:
> Regular virtual timers are used to emulate timings
> related to vCPU and peripheral states. QCOW2 uses timers
> to clean the cache. These timers should have external
> flag. In the opposite case they affect the execution
> and it can't be recorded and replayed.
> This patch adds external flag to the timer for qcow2
> cache clean.
>
> Signed-off-by: Pavel Dovgalyuk <Pavel.Dovgalyuk@ispras.ru>
> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> block/qcow2.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
Thanks, applied to my block branch:
https://git.xanclic.moe/XanClic/qemu/commits/branch/block
Max
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-03-29 16:08 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-23 11:08 [PATCH] qcow2: use external virtual timers Pavel Dovgalyuk
2021-03-23 12:44 ` Paolo Bonzini
2021-03-29 8:06 Pavel Dovgalyuk
2021-03-29 9:42 ` Paolo Bonzini
2021-03-29 16:04 ` Max Reitz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).