qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] linux-user/strace.list: fix epoll_create{,1} -strace output
@ 2020-04-16 17:59 Sergei Trofimovich
  2020-04-30 22:59 ` Sergei Trofimovich
  2020-05-27 14:39 ` Laurent Vivier
  0 siblings, 2 replies; 4+ messages in thread
From: Sergei Trofimovich @ 2020-04-16 17:59 UTC (permalink / raw)
  To: qemu-devel; +Cc: Riku Voipio, Laurent Vivier, Sergei Trofimovich

Fix syscall name and parameters priinter.

Before the change:

```
$ alpha-linux-user/qemu-alpha -strace -L /usr/alpha-unknown-linux-gnu/ /tmp/a
...
1274697 %s(%d)(2097152,274903156744,274903156760,274905840712,274877908880,274903235616) = 3
1274697 exit_group(0)
```

After the change:

```
$ alpha-linux-user/qemu-alpha -strace -L /usr/alpha-unknown-linux-gnu/ /tmp/a
...
1273719 epoll_create1(2097152) = 3
1273719 exit_group(0)
```

Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
CC: Riku Voipio <riku.voipio@iki.fi>
CC: Laurent Vivier <laurent@vivier.eu>
---
 linux-user/strace.list | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/linux-user/strace.list b/linux-user/strace.list
index d49a1e92a8..9281c0a758 100644
--- a/linux-user/strace.list
+++ b/linux-user/strace.list
@@ -125,10 +125,10 @@
 { TARGET_NR_dup3, "dup3" , "%s(%d,%d,%d)", NULL, NULL },
 #endif
 #ifdef TARGET_NR_epoll_create
-{ TARGET_NR_epoll_create, "%s(%d)", NULL, NULL, NULL },
+{ TARGET_NR_epoll_create, "epoll_create", "%s(%d)", NULL, NULL },
 #endif
 #ifdef TARGET_NR_epoll_create1
-{ TARGET_NR_epoll_create1, "%s(%d)", NULL, NULL, NULL },
+{ TARGET_NR_epoll_create1, "epoll_create1", "%s(%d)", NULL, NULL },
 #endif
 #ifdef TARGET_NR_epoll_ctl
 { TARGET_NR_epoll_ctl, "epoll_ctl" , NULL, NULL, NULL },
-- 
2.26.1



^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] linux-user/strace.list: fix epoll_create{,1} -strace output
  2020-04-16 17:59 [PATCH] linux-user/strace.list: fix epoll_create{,1} -strace output Sergei Trofimovich
@ 2020-04-30 22:59 ` Sergei Trofimovich
  2020-05-01 15:06   ` Philippe Mathieu-Daudé
  2020-05-27 14:39 ` Laurent Vivier
  1 sibling, 1 reply; 4+ messages in thread
From: Sergei Trofimovich @ 2020-04-30 22:59 UTC (permalink / raw)
  To: qemu-devel; +Cc: Riku Voipio, Laurent Vivier

On Thu, 16 Apr 2020 18:59:57 +0100
Sergei Trofimovich <slyfox@gentoo.org> wrote:

> Fix syscall name and parameters priinter.
> 
> Before the change:
> 
> ```
> $ alpha-linux-user/qemu-alpha -strace -L /usr/alpha-unknown-linux-gnu/ /tmp/a
> ...
> 1274697 %s(%d)(2097152,274903156744,274903156760,274905840712,274877908880,274903235616) = 3
> 1274697 exit_group(0)
> ```
> 
> After the change:
> 
> ```
> $ alpha-linux-user/qemu-alpha -strace -L /usr/alpha-unknown-linux-gnu/ /tmp/a
> ...
> 1273719 epoll_create1(2097152) = 3
> 1273719 exit_group(0)
> ```
> 
> Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
> CC: Riku Voipio <riku.voipio@iki.fi>
> CC: Laurent Vivier <laurent@vivier.eu>
> ---
>  linux-user/strace.list | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/linux-user/strace.list b/linux-user/strace.list
> index d49a1e92a8..9281c0a758 100644
> --- a/linux-user/strace.list
> +++ b/linux-user/strace.list
> @@ -125,10 +125,10 @@
>  { TARGET_NR_dup3, "dup3" , "%s(%d,%d,%d)", NULL, NULL },
>  #endif
>  #ifdef TARGET_NR_epoll_create
> -{ TARGET_NR_epoll_create, "%s(%d)", NULL, NULL, NULL },
> +{ TARGET_NR_epoll_create, "epoll_create", "%s(%d)", NULL, NULL },
>  #endif
>  #ifdef TARGET_NR_epoll_create1
> -{ TARGET_NR_epoll_create1, "%s(%d)", NULL, NULL, NULL },
> +{ TARGET_NR_epoll_create1, "epoll_create1", "%s(%d)", NULL, NULL },
>  #endif
>  #ifdef TARGET_NR_epoll_ctl
>  { TARGET_NR_epoll_ctl, "epoll_ctl" , NULL, NULL, NULL },
> -- 
> 2.26.1
> 

Should it be handled differently?

-- 

  Sergei


^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] linux-user/strace.list: fix epoll_create{,1} -strace output
  2020-04-30 22:59 ` Sergei Trofimovich
@ 2020-05-01 15:06   ` Philippe Mathieu-Daudé
  0 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-05-01 15:06 UTC (permalink / raw)
  To: Sergei Trofimovich, qemu-devel
  Cc: Helge Deller, Riku Voipio, Laurent Vivier, Aleksandar Markovic

+ Helge & Aleksandar.

On 5/1/20 12:59 AM, Sergei Trofimovich wrote:
> On Thu, 16 Apr 2020 18:59:57 +0100
> Sergei Trofimovich <slyfox@gentoo.org> wrote:
> 
>> Fix syscall name and parameters priinter.
>>
>> Before the change:
>>
>> ```
>> $ alpha-linux-user/qemu-alpha -strace -L /usr/alpha-unknown-linux-gnu/ /tmp/a
>> ...
>> 1274697 %s(%d)(2097152,274903156744,274903156760,274905840712,274877908880,274903235616) = 3

Oops...

>> 1274697 exit_group(0)
>> ```
>>
>> After the change:
>>
>> ```
>> $ alpha-linux-user/qemu-alpha -strace -L /usr/alpha-unknown-linux-gnu/ /tmp/a
>> ...
>> 1273719 epoll_create1(2097152) = 3
>> 1273719 exit_group(0)
>> ```
>>

Cc: qemu-stable@nongnu.org
Fixes: 9cbc0578cb6 ("Improve output of various syscalls")

>> Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
>> CC: Riku Voipio <riku.voipio@iki.fi>
>> CC: Laurent Vivier <laurent@vivier.eu>
>> ---
>>   linux-user/strace.list | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/linux-user/strace.list b/linux-user/strace.list
>> index d49a1e92a8..9281c0a758 100644
>> --- a/linux-user/strace.list
>> +++ b/linux-user/strace.list
>> @@ -125,10 +125,10 @@
>>   { TARGET_NR_dup3, "dup3" , "%s(%d,%d,%d)", NULL, NULL },
>>   #endif
>>   #ifdef TARGET_NR_epoll_create
>> -{ TARGET_NR_epoll_create, "%s(%d)", NULL, NULL, NULL },
>> +{ TARGET_NR_epoll_create, "epoll_create", "%s(%d)", NULL, NULL },
>>   #endif
>>   #ifdef TARGET_NR_epoll_create1
>> -{ TARGET_NR_epoll_create1, "%s(%d)", NULL, NULL, NULL },
>> +{ TARGET_NR_epoll_create1, "epoll_create1", "%s(%d)", NULL, NULL },
>>   #endif
>>   #ifdef TARGET_NR_epoll_ctl
>>   { TARGET_NR_epoll_ctl, "epoll_ctl" , NULL, NULL, NULL },
>> -- 
>> 2.26.1
>>
> 
> Should it be handled differently?

No, you are correct, we missed this when reviewing commit 9cbc0578cb6.

Thanks for your patch!

Too bad it missed the 5.0 release :/

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>


^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] linux-user/strace.list: fix epoll_create{,1} -strace output
  2020-04-16 17:59 [PATCH] linux-user/strace.list: fix epoll_create{,1} -strace output Sergei Trofimovich
  2020-04-30 22:59 ` Sergei Trofimovich
@ 2020-05-27 14:39 ` Laurent Vivier
  1 sibling, 0 replies; 4+ messages in thread
From: Laurent Vivier @ 2020-05-27 14:39 UTC (permalink / raw)
  To: Sergei Trofimovich, qemu-devel; +Cc: Riku Voipio

Le 16/04/2020 à 19:59, Sergei Trofimovich a écrit :
> Fix syscall name and parameters priinter.
> 
> Before the change:
> 
> ```
> $ alpha-linux-user/qemu-alpha -strace -L /usr/alpha-unknown-linux-gnu/ /tmp/a
> ...
> 1274697 %s(%d)(2097152,274903156744,274903156760,274905840712,274877908880,274903235616) = 3
> 1274697 exit_group(0)
> ```
> 
> After the change:
> 
> ```
> $ alpha-linux-user/qemu-alpha -strace -L /usr/alpha-unknown-linux-gnu/ /tmp/a
> ...
> 1273719 epoll_create1(2097152) = 3
> 1273719 exit_group(0)
> ```
> 
> Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
> CC: Riku Voipio <riku.voipio@iki.fi>
> CC: Laurent Vivier <laurent@vivier.eu>
> ---
>  linux-user/strace.list | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/linux-user/strace.list b/linux-user/strace.list
> index d49a1e92a8..9281c0a758 100644
> --- a/linux-user/strace.list
> +++ b/linux-user/strace.list
> @@ -125,10 +125,10 @@
>  { TARGET_NR_dup3, "dup3" , "%s(%d,%d,%d)", NULL, NULL },
>  #endif
>  #ifdef TARGET_NR_epoll_create
> -{ TARGET_NR_epoll_create, "%s(%d)", NULL, NULL, NULL },
> +{ TARGET_NR_epoll_create, "epoll_create", "%s(%d)", NULL, NULL },
>  #endif
>  #ifdef TARGET_NR_epoll_create1
> -{ TARGET_NR_epoll_create1, "%s(%d)", NULL, NULL, NULL },
> +{ TARGET_NR_epoll_create1, "epoll_create1", "%s(%d)", NULL, NULL },
>  #endif
>  #ifdef TARGET_NR_epoll_ctl
>  { TARGET_NR_epoll_ctl, "epoll_ctl" , NULL, NULL, NULL },
> 

Applied to my linux-user branch.

Thanks,
Laurent



^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-05-27 14:41 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-16 17:59 [PATCH] linux-user/strace.list: fix epoll_create{,1} -strace output Sergei Trofimovich
2020-04-30 22:59 ` Sergei Trofimovich
2020-05-01 15:06   ` Philippe Mathieu-Daudé
2020-05-27 14:39 ` Laurent Vivier

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).