From: "Alex Bennée" <alex.bennee@linaro.org>
To: Song Gao <gaosong@loongson.cn>
Cc: peter.maydell@linaro.org, thuth@redhat.com,
qemu-devel@nongnu.org, richard.henderson@linaro.org,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
maobibo@loongson.cn, laurent@vivier.eu, alistair.francis@wdc.com,
pbonzini@redhat.com
Subject: Re: [PATCH 06/20] target/loongarch: Add main translation routines
Date: Tue, 29 Jun 2021 13:26:16 +0100 [thread overview]
Message-ID: <871r8krh4m.fsf@linaro.org> (raw)
In-Reply-To: <88f8eaba-f99a-5865-898f-29a9f4b418f2@loongson.cn>
Song Gao <gaosong@loongson.cn> writes:
> Hi, Philippe,
>
> On 06/29/2021 02:46 AM, Philippe Mathieu-Daudé wrote:
>> On 6/28/21 2:04 PM, Song Gao wrote:
>>> This patch add main translation routines and
>>> basic functions for translation.
>>>
>>> Signed-off-by: Song Gao <gaosong@loongson.cn>
>>> ---
>>> target/loongarch/helper.h | 10 +
>>> target/loongarch/op_helper.c | 28 +++
>>> target/loongarch/translate.c | 537 +++++++++++++++++++++++++++++++++++++++++++
>>> target/loongarch/translate.h | 58 +++++
>>> 4 files changed, 633 insertions(+)
>>> create mode 100644 target/loongarch/helper.h
>>> create mode 100644 target/loongarch/op_helper.c
>>> create mode 100644 target/loongarch/translate.c
>>> create mode 100644 target/loongarch/translate.h
>>
>>> +/* 128 and 256 msa vector instructions are not supported yet */
>>> +static bool decode_lsx(uint32_t opcode)
>>> +{
>>> + uint32_t value = (opcode & 0xff000000);
>>> +
>>> + if ((opcode & 0xf0000000) == 0x70000000) {
>>> + return true;
>>> + } else if ((opcode & 0xfff00000) == 0x38400000) {
>>> + return true;
>>> + } else {
>>> + switch (value) {
>>> + case 0x09000000:
>>> + case 0x0a000000:
>>> + case 0x0e000000:
>>> + case 0x0f000000:
>>> + case 0x2c000000:
>>> + case 0x30000000:
>>> + case 0x31000000:
>>> + case 0x32000000:
>>> + case 0x33000000:
>>> + return true;
>>> + }
>>> + }
>>> + return false;
>>> +}
>>
>> Why not generate that with the decodetree script?
>>
> These instructions are privileged instructions， user mode does not need these instructions.
> I'll delete these codes.
Are you intending to include system emulation in due course?
--
Alex Bennée
next prev parent reply other threads:[~2021-06-29 12:29 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-28 12:04 [PATCH 00/20] Add LoongArch linux-user emulation support Song Gao
2021-06-28 12:04 ` [PATCH 01/20] target/loongarch: Add README Song Gao
2021-06-28 18:40 ` Philippe Mathieu-Daudé
2021-06-29 7:33 ` Song Gao
2021-06-29 11:13 ` Alex Bennée
2021-06-30 1:09 ` Song Gao
2021-06-29 11:52 ` Peter Maydell
2021-06-30 1:22 ` Song Gao
2021-06-28 12:04 ` [PATCH 02/20] target/loongarch: Add CSR registers definition Song Gao
2021-06-28 12:04 ` [PATCH 03/20] target/loongarch: Add core definition Song Gao
2021-06-28 18:44 ` Philippe Mathieu-Daudé
2021-06-29 7:39 ` Song Gao
2021-06-28 12:04 ` [PATCH 04/20] target/loongarch: Add interrupt handling support Song Gao
2021-06-28 12:04 ` [PATCH 05/20] target/loongarch: Add memory management support Song Gao
2021-06-28 12:04 ` [PATCH 06/20] target/loongarch: Add main translation routines Song Gao
2021-06-28 18:46 ` Philippe Mathieu-Daudé
2021-06-29 8:50 ` Song Gao
2021-06-29 12:26 ` Alex Bennée [this message]
2021-06-30 1:04 ` Song Gao
2021-06-28 12:04 ` [PATCH 07/20] target/loongarch: Add fixed point arithmetic instruction translation Song Gao
2021-07-01 20:31 ` Philippe Mathieu-Daudé
2021-07-02 8:15 ` Song Gao
2021-07-02 8:51 ` Philippe Mathieu-Daudé
2021-07-02 9:16 ` Song Gao
2021-07-02 14:46 ` Richard Henderson
2021-07-05 0:45 ` Song Gao
2021-06-28 12:04 ` [PATCH 08/20] target/loongarch: Add fixed point shift " Song Gao
2021-06-28 12:04 ` [PATCH 09/20] target/loongarch: Add fixed point bit " Song Gao
2021-06-28 12:04 ` [PATCH 10/20] target/loongarch: Add fixed point load/store " Song Gao
2021-06-28 12:04 ` [PATCH 11/20] target/loongarch: Add fixed point atomic " Song Gao
2021-06-28 12:04 ` [PATCH 12/20] target/loongarch: Add fixed point extra " Song Gao
2021-06-28 12:04 ` [PATCH 13/20] target/loongarch: Add floating point arithmetic " Song Gao
2021-06-28 12:04 ` [PATCH 14/20] target/loongarch: Add floating point comparison " Song Gao
2021-06-28 12:04 ` [PATCH 15/20] target/loongarch: Add floating point conversion " Song Gao
2021-06-28 12:04 ` [PATCH 16/20] target/loongarch: Add floating point move " Song Gao
2021-06-28 12:04 ` [PATCH 17/20] target/loongarch: Add floating point load/store " Song Gao
2021-06-28 12:04 ` [PATCH 18/20] target/loongarch: Add branch " Song Gao
2021-06-28 12:04 ` [PATCH 19/20] target/loongarch: Add disassembler Song Gao
2021-06-28 12:04 ` [PATCH 20/20] target/loongarch: Add linux-user emulation support Song Gao
2021-06-29 13:42 ` Peter Maydell
2021-06-30 1:41 ` maobibo
2021-06-30 9:36 ` Alex Bennée
2021-07-01 1:07 ` maobibo
2021-07-01 6:47 ` Thomas Huth
2021-07-01 7:08 ` maobibo
2021-07-01 10:35 ` Alex Bennée
2021-07-01 10:53 ` Peter Maydell
2021-07-01 12:05 ` maobibo
2021-06-30 1:59 ` Song Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871r8krh4m.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=alistair.francis@wdc.com \
--cc=f4bug@amsat.org \
--cc=gaosong@loongson.cn \
--cc=laurent@vivier.eu \
--cc=maobibo@loongson.cn \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).