From: "Alex Bennée" <alex.bennee@linaro.org>
To: Pavel Dovgalyuk <Pavel.Dovgaluk@gmail.com>
Cc: wrampazz@redhat.com, qemu-devel@nongnu.org, dovgaluk@ispras.ru,
pavel.dovgaluk@ispras.ru, crosa@redhat.com, pbonzini@redhat.com,
philmd@redhat.com
Subject: Re: [PATCH v2 02/11] tests/acceptance: refactor boot_linux_console test to allow code reuse
Date: Wed, 27 May 2020 15:31:27 +0100 [thread overview]
Message-ID: <871rn578lc.fsf@linaro.org> (raw)
In-Reply-To: <159057544969.16818.6615283542905717210.stgit@pasha-ThinkPad-X280>
Pavel Dovgalyuk <Pavel.Dovgaluk@gmail.com> writes:
> This patch splits code in BootLinuxConsole class into two different
> classes to allow reusing it by record/replay tests.
>
> Signed-off-by: Pavel Dovgalyuk <Pavel.Dovgaluk@ispras.ru>
> ---
> 0 files changed
>
> diff --git a/tests/acceptance/boot_linux_console.py b/tests/acceptance/boot_linux_console.py
> index c6b06a1a13..f23c5833b7 100644
> --- a/tests/acceptance/boot_linux_console.py
> +++ b/tests/acceptance/boot_linux_console.py
> @@ -28,19 +28,13 @@ try:
> except CmdNotFoundError:
> P7ZIP_AVAILABLE = False
>
> -class BootLinuxConsole(Test):
> - """
> - Boots a Linux kernel and checks that the console is operational and the
> - kernel command line is properly passed from QEMU to the kernel
> - """
> -
> - timeout = 90
> -
> +class LinuxKernelUtils(Test):
I'm not super keen on the name given it is being sub-classed. Maybe:
class LinuxKernelTest(Test):
and then:
class BootLinuxConsole(LinuxKernelTest)
?
Otherwise:
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
next prev parent reply other threads:[~2020-05-27 14:33 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 10:30 [PATCH v2 00/11] Record/replay acceptance tests Pavel Dovgalyuk
2020-05-27 10:30 ` [PATCH v2 01/11] tests/acceptance: allow console interaction with specific VMs Pavel Dovgalyuk
2020-05-27 14:20 ` Alex Bennée
2020-05-27 14:42 ` Willian Rampazzo
2020-05-27 10:30 ` [PATCH v2 02/11] tests/acceptance: refactor boot_linux_console test to allow code reuse Pavel Dovgalyuk
2020-05-27 14:31 ` Alex Bennée [this message]
2020-05-27 10:30 ` [PATCH v2 03/11] tests/acceptance: add base class record/replay kernel tests Pavel Dovgalyuk
2020-05-27 14:41 ` Philippe Mathieu-Daudé
2020-05-27 15:20 ` Alex Bennée
2020-05-28 7:19 ` Pavel Dovgalyuk
2020-05-28 8:28 ` Alex Bennée
2020-05-29 5:58 ` Pavel Dovgalyuk
2020-05-27 10:31 ` [PATCH v2 04/11] tests/acceptance: add kernel record/replay test for x86_64 Pavel Dovgalyuk
2020-05-27 14:53 ` Philippe Mathieu-Daudé
2020-05-28 7:12 ` Pavel Dovgalyuk
2020-05-28 8:38 ` Philippe Mathieu-Daudé
2020-05-28 11:07 ` Alex Bennée
2020-05-28 11:32 ` Philippe Mathieu-Daudé
2020-05-27 15:40 ` Alex Bennée
2020-05-27 16:20 ` Alex Bennée
2020-05-28 7:26 ` Pavel Dovgalyuk
2020-05-27 15:41 ` Alex Bennée
2020-05-28 6:12 ` Pavel Dovgalyuk
2020-05-28 13:26 ` Alex Bennée
2020-05-29 5:56 ` Pavel Dovgalyuk
2020-05-29 9:20 ` Alex Bennée
2020-05-27 10:31 ` [PATCH v2 05/11] tests/acceptance: add record/replay test for aarch64 Pavel Dovgalyuk
2020-05-27 14:44 ` Philippe Mathieu-Daudé
2020-05-27 10:31 ` [PATCH v2 06/11] tests/acceptance: add record/replay test for arm Pavel Dovgalyuk
2020-05-27 10:31 ` [PATCH v2 07/11] tests/acceptance: add record/replay test for ppc64 Pavel Dovgalyuk
2020-05-27 10:31 ` [PATCH v2 08/11] tests/acceptance: add record/replay test for m68k Pavel Dovgalyuk
2020-05-27 10:31 ` [PATCH v2 09/11] tests/acceptance: record/replay tests with advcal images Pavel Dovgalyuk
2020-05-27 10:31 ` [PATCH v2 10/11] tests/acceptance: refactor boot_linux to allow code reuse Pavel Dovgalyuk
2020-05-27 10:31 ` [PATCH v2 11/11] tests/acceptance: Linux boot test for record/replay Pavel Dovgalyuk
2020-05-27 16:44 ` Alex Bennée
2020-05-28 6:17 ` Pavel Dovgalyuk
2020-05-27 13:41 ` [PATCH v2 00/11] Record/replay acceptance tests no-reply
2020-05-27 14:53 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871rn578lc.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=Pavel.Dovgaluk@gmail.com \
--cc=crosa@redhat.com \
--cc=dovgaluk@ispras.ru \
--cc=pavel.dovgaluk@ispras.ru \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=wrampazz@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).