From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org, Pavel.Dovgaluk@gmail.com
Cc: wrampazz@redhat.com, dovgaluk@ispras.ru,
pavel.dovgaluk@ispras.ru, crosa@redhat.com, pbonzini@redhat.com,
alex.bennee@linaro.org
Subject: Re: [PATCH v2 00/11] Record/replay acceptance tests
Date: Wed, 27 May 2020 16:53:55 +0200 [thread overview]
Message-ID: <ac997bec-d700-2ee2-8b98-c1e58ab30933@redhat.com> (raw)
In-Reply-To: <159058688028.16318.18277405305142866353@45ef0f9c86ae>
On 5/27/20 3:41 PM, no-reply@patchew.org wrote:
> Patchew URL: https://patchew.org/QEMU/159057543840.16818.14393433996899521784.stgit@pasha-ThinkPad-X280/
>
>
>
> Hi,
>
> This series seems to have some coding style problems. See output below for
> more information:
>
[...]>
> ERROR: line over 90 characters
> #83: FILE: tests/acceptance/replay_linux.py:41:
> + vm.add_args('-drive', 'driver=blkreplay,id=disk%s-rr,if=none,image=disk%s' % (id, id))
>
> WARNING: line over 80 characters
> #84: FILE: tests/acceptance/replay_linux.py:42:
> + vm.add_args('-device', '%s,drive=disk%s-rr%s' % (device, id, bus_string))
Please try to respect the QEMU 80 chars limit (it eases review by blind
developers) and align methods & arguments to QEMU style.
Otherwise I'm glad to see this series.
So far:
Tested-by: Philippe Mathieu-Daude <philmd@redhat.com>
I plan to add R-b on v3 once you addressed Alex's comments.
Good job!
prev parent reply other threads:[~2020-05-27 14:55 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 10:30 [PATCH v2 00/11] Record/replay acceptance tests Pavel Dovgalyuk
2020-05-27 10:30 ` [PATCH v2 01/11] tests/acceptance: allow console interaction with specific VMs Pavel Dovgalyuk
2020-05-27 14:20 ` Alex Bennée
2020-05-27 14:42 ` Willian Rampazzo
2020-05-27 10:30 ` [PATCH v2 02/11] tests/acceptance: refactor boot_linux_console test to allow code reuse Pavel Dovgalyuk
2020-05-27 14:31 ` Alex Bennée
2020-05-27 10:30 ` [PATCH v2 03/11] tests/acceptance: add base class record/replay kernel tests Pavel Dovgalyuk
2020-05-27 14:41 ` Philippe Mathieu-Daudé
2020-05-27 15:20 ` Alex Bennée
2020-05-28 7:19 ` Pavel Dovgalyuk
2020-05-28 8:28 ` Alex Bennée
2020-05-29 5:58 ` Pavel Dovgalyuk
2020-05-27 10:31 ` [PATCH v2 04/11] tests/acceptance: add kernel record/replay test for x86_64 Pavel Dovgalyuk
2020-05-27 14:53 ` Philippe Mathieu-Daudé
2020-05-28 7:12 ` Pavel Dovgalyuk
2020-05-28 8:38 ` Philippe Mathieu-Daudé
2020-05-28 11:07 ` Alex Bennée
2020-05-28 11:32 ` Philippe Mathieu-Daudé
2020-05-27 15:40 ` Alex Bennée
2020-05-27 16:20 ` Alex Bennée
2020-05-28 7:26 ` Pavel Dovgalyuk
2020-05-27 15:41 ` Alex Bennée
2020-05-28 6:12 ` Pavel Dovgalyuk
2020-05-28 13:26 ` Alex Bennée
2020-05-29 5:56 ` Pavel Dovgalyuk
2020-05-29 9:20 ` Alex Bennée
2020-05-27 10:31 ` [PATCH v2 05/11] tests/acceptance: add record/replay test for aarch64 Pavel Dovgalyuk
2020-05-27 14:44 ` Philippe Mathieu-Daudé
2020-05-27 10:31 ` [PATCH v2 06/11] tests/acceptance: add record/replay test for arm Pavel Dovgalyuk
2020-05-27 10:31 ` [PATCH v2 07/11] tests/acceptance: add record/replay test for ppc64 Pavel Dovgalyuk
2020-05-27 10:31 ` [PATCH v2 08/11] tests/acceptance: add record/replay test for m68k Pavel Dovgalyuk
2020-05-27 10:31 ` [PATCH v2 09/11] tests/acceptance: record/replay tests with advcal images Pavel Dovgalyuk
2020-05-27 10:31 ` [PATCH v2 10/11] tests/acceptance: refactor boot_linux to allow code reuse Pavel Dovgalyuk
2020-05-27 10:31 ` [PATCH v2 11/11] tests/acceptance: Linux boot test for record/replay Pavel Dovgalyuk
2020-05-27 16:44 ` Alex Bennée
2020-05-28 6:17 ` Pavel Dovgalyuk
2020-05-27 13:41 ` [PATCH v2 00/11] Record/replay acceptance tests no-reply
2020-05-27 14:53 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac997bec-d700-2ee2-8b98-c1e58ab30933@redhat.com \
--to=philmd@redhat.com \
--cc=Pavel.Dovgaluk@gmail.com \
--cc=alex.bennee@linaro.org \
--cc=crosa@redhat.com \
--cc=dovgaluk@ispras.ru \
--cc=pavel.dovgaluk@ispras.ru \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=wrampazz@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).