From: Markus Armbruster <armbru@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH 0/2] tests: clean includes
Date: Tue, 09 Feb 2016 11:54:00 +0100 [thread overview]
Message-ID: <8737t2nohj.fsf@blackfin.pond.sub.org> (raw)
In-Reply-To: <1454957357-22094-1-git-send-email-peter.maydell@linaro.org> (Peter Maydell's message of "Mon, 8 Feb 2016 18:49:15 +0000")
Peter Maydell <peter.maydell@linaro.org> writes:
> This patchset runs clean-includes on all the .c files in
> tests/, except those in tests/tcg, which I think are all
> intended as standalone test programs for the guest.
>
> The first patch handles i440fx-test.c manually since otherwise
> compilation would fail due to the redefinition of ARRAY_SIZE.
> The second patch is automated; I can split it up if people
> prefer but it seems just about small enough to leave as one patch.
>
> With these patches applied Eric's "qapi: Clean up includes in
> generated files" patch no longer breaks 'make check'.
I applied this series, merged my qapi-next, topped off with Eric's
patch, and got a working build.
I'll send a pull request for qapi-next without Eric's patch, to avoid
dependencies. If Eric's patch is not merged, but this series is, I'll
include it in the next QAPI pull request. Feel free to apply it
directly along with this series.
prev parent reply other threads:[~2016-02-09 10:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-08 18:49 [Qemu-devel] [PATCH 0/2] tests: clean includes Peter Maydell
2016-02-08 18:49 ` [Qemu-devel] [PATCH 1/2] tests/i440fx-test: Don't define ARRAY_SIZE locally Peter Maydell
2016-02-08 20:32 ` Eric Blake
2016-02-08 18:49 ` [Qemu-devel] [PATCH 2/2] tests: Clean up includes Peter Maydell
2016-02-08 20:51 ` Eric Blake
2016-02-08 21:16 ` Peter Maydell
2016-02-09 10:54 ` Markus Armbruster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8737t2nohj.fsf@blackfin.pond.sub.org \
--to=armbru@redhat.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).