From: Eric Blake <eblake@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Markus Armbruster <armbru@redhat.com>, patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH 2/2] tests: Clean up includes
Date: Mon, 8 Feb 2016 13:51:45 -0700 [thread overview]
Message-ID: <56B8FFE1.60206@redhat.com> (raw)
In-Reply-To: <1454957357-22094-3-git-send-email-peter.maydell@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 1214 bytes --]
On 02/08/2016 11:49 AM, Peter Maydell wrote:
> Clean up includes so that osdep.h is included first and headers
> which it implies are not included manually.
>
> This commit was created with scripts/clean-includes.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> This deals with every .c file in tests/ except those
> in tests/tcg which I think are all standalone programs
> targeting the guest.
> ---
> 122 files changed, 122 insertions(+), 202 deletions(-)
You may want to wait for other maintainers to chime in for files they
care about; but I looked through the patch and nothing jumped out at me
as being incorrect. Many of the files already includes libqtest.c or
even osdep.h - for those files, the change is obviously correct.
Reviewed-by: Eric Blake <eblake@redhat.com>
Tested-by: Eric Blake <eblake@redhat.com>
> +++ b/tests/multiboot/libc.c
> @@ -20,6 +20,7 @@
> * THE SOFTWARE.
> */
>
> +#include "qemu/osdep.h"
> #include "libc.h"
>
> void* memcpy(void *dest, const void *src, int n)
Not so sure about this directory.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-02-08 20:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-08 18:49 [Qemu-devel] [PATCH 0/2] tests: clean includes Peter Maydell
2016-02-08 18:49 ` [Qemu-devel] [PATCH 1/2] tests/i440fx-test: Don't define ARRAY_SIZE locally Peter Maydell
2016-02-08 20:32 ` Eric Blake
2016-02-08 18:49 ` [Qemu-devel] [PATCH 2/2] tests: Clean up includes Peter Maydell
2016-02-08 20:51 ` Eric Blake [this message]
2016-02-08 21:16 ` Peter Maydell
2016-02-09 10:54 ` [Qemu-devel] [PATCH 0/2] tests: clean includes Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B8FFE1.60206@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).