From: Cornelia Huck <cohuck@redhat.com>
To: Yanan Wang <wangyanan55@huawei.com>, qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Andrew Jones" <drjones@redhat.com>,
"Daniel P . Berrangé" <berrange@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Pierre Morel" <pmorel@linux.ibm.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Greg Kurz" <groug@kaod.org>, "Halil Pasic" <pasic@linux.ibm.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"Igor Mammedov" <imammedo@redhat.com>,
yuzenghui@huawei.com, wanghaibin.wang@huawei.com,
"Yanan Wang" <wangyanan55@huawei.com>,
"David Gibson" <david@gibson.dropbear.id.au>
Subject: Re: [PATCH for-6.2 v2 00/11] machine: smp parsing fixes and improvement
Date: Mon, 19 Jul 2021 18:57:38 +0200 [thread overview]
Message-ID: <875yx69r7h.fsf@redhat.com> (raw)
In-Reply-To: <20210719032043.25416-1-wangyanan55@huawei.com>
On Mon, Jul 19 2021, Yanan Wang <wangyanan55@huawei.com> wrote:
> Hi,
>
> This is v2 of the series [1] that I have posted to introduce some smp parsing
> fixes and improvement, much more work has been processed compared to RFC v1.
>
> [1] https://lists.gnu.org/archive/html/qemu-devel/2021-07/msg00259.html
>
> The purpose of this series is to improve/fix the parsing logic. Explicitly
> specifying a CPU topology parameter as zero is not allowed any more, and
> maxcpus is now uniformly used to calculate the omitted parameters. It's also
> suggested that we should start to prefer cores over sockets over threads on
> the newer machine types, which will make the computed virtual topology more
> reflective of the real hardware.
>
> In order to reduce code duplication and ease the code maintenance, smp_parse
> in now converted into a parser generic enough for all arches, so that the PC
> specific one can be removed. It's also convenient to introduce more topology
> members (e.g. cluster) to the generic parser in the future.
Cc:ing Pierre, as he also had been looking at the smp parsing code (for
s390x) recently.
Also, please keep me on cc: for patches that touch s390x.
>
> Finally, a QEMU unit test for the parsing of given SMP configuration is added.
> Since all the parsing logic is in generic function smp_parse(), this test
> passes diffenent SMP configurations to the function and compare the parsing
> result with what is expected. In the test, all possible collections of the
> topology parameters and the corressponding expected results are listed,
> including the valid and invalid ones. The preference of sockets over cores
> and the preference of cores over sockets, and the support of multi-dies are
> also taken into consideration.
>
> ---
>
> Changelogs:
>
> v1->v2:
> - disallow "anything=0" in the smp configuration (Andrew)
> - make function smp_parse() a generic helper for all arches
> - improve the error reporting in the parser
> - start to prefer cores over sockets since 6.2 (Daniel)
> - add a unit test for the smp parsing (Daniel)
>
> ---
>
> Yanan Wang (11):
> machine: Disallow specifying topology parameters as zero
> machine: Make smp_parse generic enough for all arches
> machine: Uniformly use maxcpus to calculate the omitted parameters
> machine: Use the computed parameters to calculate omitted cpus
> machine: Improve the error reporting of smp parsing
> hw: Add compat machines for 6.2
> machine: Prefer cores over sockets in smp parsing since 6.2
> machine: Use ms instead of global current_machine in sanity-check
> machine: Tweak the order of topology members in struct CpuTopology
> machine: Split out the smp parsing code
> tests/unit: Add a unit test for smp parsing
>
> MAINTAINERS | 2 +
> hw/arm/virt.c | 10 +-
> hw/core/machine-smp.c | 124 ++++
> hw/core/machine.c | 68 +--
> hw/core/meson.build | 1 +
> hw/i386/pc.c | 66 +--
> hw/i386/pc_piix.c | 15 +-
> hw/i386/pc_q35.c | 14 +-
> hw/ppc/spapr.c | 16 +-
> hw/s390x/s390-virtio-ccw.c | 15 +-
> include/hw/boards.h | 13 +-
> include/hw/i386/pc.h | 3 +
> qapi/machine.json | 6 +-
> qemu-options.hx | 4 +-
> tests/unit/meson.build | 1 +
> tests/unit/test-smp-parse.c | 1117 +++++++++++++++++++++++++++++++++++
> 16 files changed, 1338 insertions(+), 137 deletions(-)
> create mode 100644 hw/core/machine-smp.c
> create mode 100644 tests/unit/test-smp-parse.c
>
> --
> 2.19.1
next prev parent reply other threads:[~2021-07-19 16:58 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-19 3:20 [PATCH for-6.2 v2 00/11] machine: smp parsing fixes and improvement Yanan Wang
2021-07-19 3:20 ` [PATCH for-6.2 v2 01/11] machine: Disallow specifying topology parameters as zero Yanan Wang
2021-07-19 16:11 ` Andrew Jones
2021-07-21 12:34 ` wangyanan (Y)
2021-07-19 16:46 ` Daniel P. Berrangé
2021-07-21 12:35 ` wangyanan (Y)
2021-07-19 3:20 ` [PATCH for-6.2 v2 02/11] machine: Make smp_parse generic enough for all arches Yanan Wang
2021-07-19 16:28 ` Andrew Jones
2021-07-19 16:36 ` Daniel P. Berrangé
2021-07-19 16:48 ` Andrew Jones
2021-07-19 16:50 ` Daniel P. Berrangé
2021-07-19 16:53 ` Daniel P. Berrangé
2021-07-22 7:18 ` wangyanan (Y)
2021-07-20 6:57 ` Cornelia Huck
2021-07-22 7:12 ` wangyanan (Y)
2021-07-19 3:20 ` [PATCH for-6.2 v2 03/11] machine: Uniformly use maxcpus to calculate the omitted parameters Yanan Wang
2021-07-19 16:36 ` Andrew Jones
2021-07-22 3:00 ` wangyanan (Y)
2021-07-19 3:20 ` [PATCH for-6.2 v2 04/11] machine: Use the computed parameters to calculate omitted cpus Yanan Wang
2021-07-19 16:42 ` Andrew Jones
2021-07-22 4:42 ` wangyanan (Y)
2021-07-22 12:27 ` Andrew Jones
2021-07-22 14:59 ` wangyanan (Y)
2021-07-22 15:05 ` Andrew Jones
2021-07-22 15:45 ` wangyanan (Y)
2021-07-19 3:20 ` [PATCH for-6.2 v2 05/11] machine: Improve the error reporting of smp parsing Yanan Wang
2021-07-19 16:53 ` Andrew Jones
2021-07-22 8:10 ` wangyanan (Y)
2021-07-22 12:47 ` Andrew Jones
2021-07-19 3:20 ` [PATCH for-6.2 v2 06/11] hw: Add compat machines for 6.2 Yanan Wang
2021-07-19 3:38 ` David Gibson
2021-07-19 17:00 ` Andrew Jones
2021-07-19 17:03 ` Cornelia Huck
2021-07-19 23:45 ` Pankaj Gupta
2021-07-19 3:20 ` [PATCH for-6.2 v2 07/11] machine: Prefer cores over sockets in smp parsing since 6.2 Yanan Wang
2021-07-19 3:40 ` David Gibson
2021-07-22 5:22 ` wangyanan (Y)
2021-07-19 17:13 ` Andrew Jones
2021-07-22 5:32 ` wangyanan (Y)
2021-07-19 3:20 ` [PATCH for-6.2 v2 08/11] machine: Use ms instead of global current_machine in sanity-check Yanan Wang
2021-07-19 17:14 ` Andrew Jones
2021-07-19 3:20 ` [PATCH for-6.2 v2 09/11] machine: Tweak the order of topology members in struct CpuTopology Yanan Wang
2021-07-19 3:20 ` [PATCH for-6.2 v2 10/11] machine: Split out the smp parsing code Yanan Wang
2021-07-19 17:20 ` Andrew Jones
2021-07-22 6:24 ` wangyanan (Y)
2021-07-22 13:07 ` Andrew Jones
2021-07-22 14:29 ` wangyanan (Y)
2021-07-19 3:20 ` [PATCH for-6.2 v2 11/11] tests/unit: Add a unit test for smp parsing Yanan Wang
2021-07-19 18:57 ` Andrew Jones
2021-07-22 6:15 ` wangyanan (Y)
2021-07-22 13:12 ` Andrew Jones
2021-07-22 14:18 ` wangyanan (Y)
2021-07-19 16:57 ` Cornelia Huck [this message]
2021-07-21 12:38 ` [PATCH for-6.2 v2 00/11] machine: smp parsing fixes and improvement wangyanan (Y)
2021-07-21 13:52 ` Pankaj Gupta
2021-07-22 2:22 ` wangyanan (Y)
2021-07-22 7:51 ` Pierre Morel
2021-07-22 8:32 ` wangyanan (Y)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875yx69r7h.fsf@redhat.com \
--to=cohuck@redhat.com \
--cc=berrange@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=drjones@redhat.com \
--cc=ehabkost@redhat.com \
--cc=groug@kaod.org \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=pmorel@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
--cc=wanghaibin.wang@huawei.com \
--cc=wangyanan55@huawei.com \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).