qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v4 0/2] vhost: Fix last queue index of devices with no cvq
@ 2021-11-04  8:56 Eugenio Pérez
  2021-11-04  8:56 ` [PATCH v4 1/2] vhost: Rename last_index to vq_index_end Eugenio Pérez
  2021-11-04  8:56 ` [PATCH v4 2/2] vhost: Fix last vq queue index of devices with no cvq Eugenio Pérez
  0 siblings, 2 replies; 5+ messages in thread
From: Eugenio Pérez @ 2021-11-04  8:56 UTC (permalink / raw)
  To: qemu-devel; +Cc: Jason Wang, Michael S. Tsirkin, Juan Quintela

The -1 assumes that cvq device model is accounted in data_queue_pairs,
if cvq does not exists, but it's actually the opposite: Devices with
!cvq are ok but devices with cvq does not add the last queue to
data_queue_pairs.

This is not a problem to vhost-net, but it is to vhost-vdpa:
* Devices with cvq gets initialized at last data vq device model, not
at cvq one.
* Devices with !cvq never gets initialized, since last_index is the
first queue of the last device model.

Tested with vp_vdpa with host's vhost=on and vhost=off, and ctrol_vq
on and off.

v4:
* Rename last_index to index_end

v3:
* Recover cvq devices.
* Rename last_index to last_vq_index

v2:
* Delete all the conditional code instead of ROUND_DOWN in a
  deinitely too-bit-tricky way.

Eugenio Pérez (2):
  vhost: Rename last_index to vq_index_end
  vhost: Fix last vq queue index of devices with no cvq

 include/hw/virtio/vhost.h |  4 ++--
 hw/net/vhost_net.c        | 12 ++++++------
 hw/virtio/vhost-vdpa.c    |  2 +-
 3 files changed, 9 insertions(+), 9 deletions(-)

-- 
2.27.0




^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-11-06 11:50 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-04  8:56 [PATCH v4 0/2] vhost: Fix last queue index of devices with no cvq Eugenio Pérez
2021-11-04  8:56 ` [PATCH v4 1/2] vhost: Rename last_index to vq_index_end Eugenio Pérez
2021-11-06 11:49   ` Juan Quintela
2021-11-04  8:56 ` [PATCH v4 2/2] vhost: Fix last vq queue index of devices with no cvq Eugenio Pérez
2021-11-05  4:19   ` Jason Wang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).