* [PATCH] Fix incorrect int->float conversions caught by clang -Wimplicit-int-float-conversion
@ 2019-11-16 1:07 Fangrui Song
2019-11-19 15:14 ` Markus Armbruster
2019-11-19 20:49 ` Fangrui Song
0 siblings, 2 replies; 11+ messages in thread
From: Fangrui Song @ 2019-11-16 1:07 UTC (permalink / raw)
To: qemu-devel; +Cc: Markus Armbruster, Dr. David Alan Gilbert, Juan Quintela
The warning will be enabled by default in clang 10. It is not available for clang <= 9.
qemu/migration/migration.c:2038:24: error: implicit conversion from 'long' to 'double' changes value from 9223372036854775807 to 9223372036854775808 [-Werror,-Wimplicit-int-float-conversion]
...
qemu/util/cutils.c:245:23: error: implicit conversion from 'unsigned long' to 'double' changes value from 18446744073709550592 to 18446744073709551616 [-Werror,-Wimplicit-int-float-conversion]
Signed-off-by: Fangrui Song <i@maskray.me>
---
migration/migration.c | 4 ++--
util/cutils.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/migration/migration.c b/migration/migration.c
index 354ad072fa..ac3ea2934a 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -53,6 +53,7 @@
#include "monitor/monitor.h"
#include "net/announce.h"
#include "qemu/queue.h"
+#include <math.h>
#define MAX_THROTTLE (32 << 20) /* Migration transfer speed throttling */
@@ -2035,11 +2036,10 @@ void qmp_migrate_set_downtime(double value, Error **errp)
}
value *= 1000; /* Convert to milliseconds */
- value = MAX(0, MIN(INT64_MAX, value));
MigrateSetParameters p = {
.has_downtime_limit = true,
- .downtime_limit = value,
+ .downtime_limit = (int64_t)fmin(value, nextafter(0x1p63, 0)),
};
qmp_migrate_set_parameters(&p, errp);
diff --git a/util/cutils.c b/util/cutils.c
index fd591cadf0..2b4484c015 100644
--- a/util/cutils.c
+++ b/util/cutils.c
@@ -239,10 +239,10 @@ static int do_strtosz(const char *nptr, const char **end,
goto out;
}
/*
- * Values >= 0xfffffffffffffc00 overflow uint64_t after their trip
+ * Values > nextafter(0x1p64, 0) overflow uint64_t after their trip
* through double (53 bits of precision).
*/
- if ((val * mul >= 0xfffffffffffffc00) || val < 0) {
+ if ((val * mul > nextafter(0x1p64, 0)) || val < 0) {
retval = -ERANGE;
goto out;
}
--
2.24.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH] Fix incorrect int->float conversions caught by clang -Wimplicit-int-float-conversion
2019-11-16 1:07 [PATCH] Fix incorrect int->float conversions caught by clang -Wimplicit-int-float-conversion Fangrui Song
@ 2019-11-19 15:14 ` Markus Armbruster
2019-11-20 11:15 ` Juan Quintela
2019-11-19 20:49 ` Fangrui Song
1 sibling, 1 reply; 11+ messages in thread
From: Markus Armbruster @ 2019-11-19 15:14 UTC (permalink / raw)
To: Fangrui Song; +Cc: Juan Quintela, qemu-devel, Dr. David Alan Gilbert
Fangrui Song <i@maskray.me> writes:
> The warning will be enabled by default in clang 10. It is not available for clang <= 9.
>
> qemu/migration/migration.c:2038:24: error: implicit conversion from 'long' to 'double' changes value from 9223372036854775807 to 9223372036854775808 [-Werror,-Wimplicit-int-float-conversion]
> ...
> qemu/util/cutils.c:245:23: error: implicit conversion from 'unsigned long' to 'double' changes value from 18446744073709550592 to 18446744073709551616 [-Werror,-Wimplicit-int-float-conversion]
>
> Signed-off-by: Fangrui Song <i@maskray.me>
> ---
> migration/migration.c | 4 ++--
> util/cutils.c | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/migration/migration.c b/migration/migration.c
> index 354ad072fa..ac3ea2934a 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -53,6 +53,7 @@
> #include "monitor/monitor.h"
> #include "net/announce.h"
> #include "qemu/queue.h"
> +#include <math.h>
>
> #define MAX_THROTTLE (32 << 20) /* Migration transfer speed throttling */
>
> @@ -2035,11 +2036,10 @@ void qmp_migrate_set_downtime(double value, Error **errp)
if (value < 0 || value > MAX_MIGRATE_DOWNTIME_SECONDS) {
error_setg(errp, "Parameter 'downtime_limit' expects an integer in "
"the range of 0 to %d seconds",
MAX_MIGRATE_DOWNTIME_SECONDS);
return;
> }
@value is now in [0,2000].
>
> value *= 1000; /* Convert to milliseconds */
@value is in [0,2000000]
> - value = MAX(0, MIN(INT64_MAX, value));
This does nothing.
>
> MigrateSetParameters p = {
> .has_downtime_limit = true,
> - .downtime_limit = value,
> + .downtime_limit = (int64_t)fmin(value, nextafter(0x1p63, 0)),
This does nothing and is hard to read :)
Can we simply drop the offending line statement instead?
> };
>
> qmp_migrate_set_parameters(&p, errp);
> diff --git a/util/cutils.c b/util/cutils.c
> index fd591cadf0..2b4484c015 100644
> --- a/util/cutils.c
> +++ b/util/cutils.c
> @@ -239,10 +239,10 @@ static int do_strtosz(const char *nptr, const char **end,
> goto out;
> }
> /*
> - * Values >= 0xfffffffffffffc00 overflow uint64_t after their trip
> + * Values > nextafter(0x1p64, 0) overflow uint64_t after their trip
> * through double (53 bits of precision).
> */
> - if ((val * mul >= 0xfffffffffffffc00) || val < 0) {
> + if ((val * mul > nextafter(0x1p64, 0)) || val < 0) {
> retval = -ERANGE;
> goto out;
> }
*result = val * mul;
I figure this one is correct and hard to read.
0xfffffffffffffc00 is not representable exactly as double. It's
half-way between the representable values 0xfffffffffffff800 and
0x10000000000000000. Which one we get is implementation-defined. Bad.
nextafter(0x1p64, 0) is a clever way to write 0xfffffffffffff800, the
largest uint64_t exactly representable as double.
With your patch, val * mul in [0,0xfffffffffffff800] will be accepted.
The first val * mul above this range is 0x1p64. Rejecting it is
correct, because it overflows yint64_t.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] Fix incorrect int->float conversions caught by clang -Wimplicit-int-float-conversion
2019-11-16 1:07 [PATCH] Fix incorrect int->float conversions caught by clang -Wimplicit-int-float-conversion Fangrui Song
2019-11-19 15:14 ` Markus Armbruster
@ 2019-11-19 20:49 ` Fangrui Song
2019-11-21 17:38 ` Eric Blake
1 sibling, 1 reply; 11+ messages in thread
From: Fangrui Song @ 2019-11-19 20:49 UTC (permalink / raw)
To: Markus Armbruster; +Cc: qemu-devel, Dr. David Alan Gilbert, Juan Quintela
[-- Attachment #1: Type: text/plain, Size: 3701 bytes --]
> Fangrui Song <address@hidden> writes:
>
> > The warning will be enabled by default in clang 10. It is not available for
> > clang <= 9.
> >
> > qemu/migration/migration.c:2038:24: error: implicit conversion from 'long' to
> > 'double' changes value from 9223372036854775807 to 9223372036854775808
> > [-Werror,-Wimplicit-int-float-conversion]
> > ...
> > qemu/util/cutils.c:245:23: error: implicit conversion from 'unsigned long' to
> > 'double' changes value from 18446744073709550592 to 18446744073709551616
> > [-Werror,-Wimplicit-int-float-conversion]
> >
> > Signed-off-by: Fangrui Song <address@hidden>
> > ---
> > migration/migration.c | 4 ++--
> > util/cutils.c | 4 ++--
> > 2 files changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/migration/migration.c b/migration/migration.c
> > index 354ad072fa..ac3ea2934a 100644
> > --- a/migration/migration.c
> > +++ b/migration/migration.c
> > @@ -53,6 +53,7 @@
> > #include "monitor/monitor.h"
> > #include "net/announce.h"
> > #include "qemu/queue.h"
> > +#include <math.h>
> >
> > #define MAX_THROTTLE (32 << 20) /* Migration transfer speed
> > throttling */
> >
> > @@ -2035,11 +2036,10 @@ void qmp_migrate_set_downtime(double value, Error
> > **errp)
> if (value < 0 || value > MAX_MIGRATE_DOWNTIME_SECONDS) {
> error_setg(errp, "Parameter 'downtime_limit' expects an integer in "
> "the range of 0 to %d seconds",
> MAX_MIGRATE_DOWNTIME_SECONDS);
> return;
> > }
>
> @value is now in [0,2000].
>
> >
> > value *= 1000; /* Convert to milliseconds */
>
> @value is in [0,2000000]
>
> > - value = MAX(0, MIN(INT64_MAX, value));
>
> This does nothing.
>
> >
> > MigrateSetParameters p = {
> > .has_downtime_limit = true,
> > - .downtime_limit = value,
> > + .downtime_limit = (int64_t)fmin(value, nextafter(0x1p63, 0)),
>
> This does nothing and is hard to read :)
>
> Can we simply drop the offending line statement instead?
Fixed in the new patch.
> > };
> >
> > qmp_migrate_set_parameters(&p, errp);
> > diff --git a/util/cutils.c b/util/cutils.c
> > index fd591cadf0..2b4484c015 100644
> > --- a/util/cutils.c
> > +++ b/util/cutils.c
> > @@ -239,10 +239,10 @@ static int do_strtosz(const char *nptr, const char
> > **end,
> > goto out;
> > }
> > /*
> > - * Values >= 0xfffffffffffffc00 overflow uint64_t after their trip
> > + * Values > nextafter(0x1p64, 0) overflow uint64_t after their trip
> > * through double (53 bits of precision).
> > */
> > - if ((val * mul >= 0xfffffffffffffc00) || val < 0) {
> > + if ((val * mul > nextafter(0x1p64, 0)) || val < 0) {
> > retval = -ERANGE;
> > goto out;
> > }
> *result = val * mul;
>
> I figure this one is correct and hard to read.
>
> 0xfffffffffffffc00 is not representable exactly as double. It's
> half-way between the representable values 0xfffffffffffff800 and
> 0x10000000000000000. Which one we get is implementation-defined. Bad.
>
> nextafter(0x1p64, 0) is a clever way to write 0xfffffffffffff800, the
> largest uint64_t exactly representable as double.
>
> With your patch, val * mul in [0,0xfffffffffffff800] will be accepted.
>
> The first val * mul above this range is 0x1p64. Rejecting it is
> correct, because it overflows yint64_t.
I am not subscribed, so apologize that this email may be off the thread.
(The binutils mailing list allows a user to download the raw email so I
can still reply to a specific email, but this list does not provide such
feature.)
[-- Attachment #2: qemu.patch --]
[-- Type: text/x-diff, Size: 2067 bytes --]
From 5f1c5a42794ddcbabb63d9af920d9f437ea90a9f Mon Sep 17 00:00:00 2001
From: Fangrui Song <i@maskray.me>
Date: Fri, 15 Nov 2019 16:27:47 -0800
Subject: [PATCH] Fix incorrect integer->float conversions caught by clang
-Wimplicit-int-float-conversion
To: qemu-devel@nongnu.org
The warning will be enabled by default in clang 10. It is not available for clang <= 9.
qemu/migration/migration.c:2038:24: error: implicit conversion from 'long' to 'double' changes value from 9223372036854775807 to 9223372036854775808 [-Werror,-Wimplicit-int-float-conversion]
...
qemu/util/cutils.c:245:23: error: implicit conversion from 'unsigned long' to 'double' changes value from 18446744073709550592 to 18446744073709551616 [-Werror,-Wimplicit-int-float-conversion]
Signed-off-by: Fangrui Song <i@maskray.me>
---
migration/migration.c | 3 +--
util/cutils.c | 4 ++--
2 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/migration/migration.c b/migration/migration.c
index 354ad072fa..09b150663f 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -2035,11 +2035,10 @@ void qmp_migrate_set_downtime(double value, Error **errp)
}
value *= 1000; /* Convert to milliseconds */
- value = MAX(0, MIN(INT64_MAX, value));
MigrateSetParameters p = {
.has_downtime_limit = true,
- .downtime_limit = value,
+ .downtime_limit = (int64_t)value,
};
qmp_migrate_set_parameters(&p, errp);
diff --git a/util/cutils.c b/util/cutils.c
index fd591cadf0..2b4484c015 100644
--- a/util/cutils.c
+++ b/util/cutils.c
@@ -239,10 +239,10 @@ static int do_strtosz(const char *nptr, const char **end,
goto out;
}
/*
- * Values >= 0xfffffffffffffc00 overflow uint64_t after their trip
+ * Values > nextafter(0x1p64, 0) overflow uint64_t after their trip
* through double (53 bits of precision).
*/
- if ((val * mul >= 0xfffffffffffffc00) || val < 0) {
+ if ((val * mul > nextafter(0x1p64, 0)) || val < 0) {
retval = -ERANGE;
goto out;
}
--
2.24.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH] Fix incorrect int->float conversions caught by clang -Wimplicit-int-float-conversion
2019-11-19 15:14 ` Markus Armbruster
@ 2019-11-20 11:15 ` Juan Quintela
2019-11-20 17:30 ` Fangrui Song
0 siblings, 1 reply; 11+ messages in thread
From: Juan Quintela @ 2019-11-20 11:15 UTC (permalink / raw)
To: Markus Armbruster; +Cc: Fangrui Song, qemu-devel, Dr. David Alan Gilbert
Markus Armbruster <armbru@redhat.com> wrote:
> Fangrui Song <i@maskray.me> writes:
>
>> The warning will be enabled by default in clang 10. It is not
>> available for clang <= 9.
>>
>> qemu/migration/migration.c:2038:24: error: implicit conversion from
>> 'long' to 'double' changes value from 9223372036854775807 to
>> 9223372036854775808 [-Werror,-Wimplicit-int-float-conversion]
>> ...
>> qemu/util/cutils.c:245:23: error: implicit conversion from 'unsigned
>> long' to 'double' changes value from 18446744073709550592 to
>> 18446744073709551616 [-Werror,-Wimplicit-int-float-conversion]
>>
>> Signed-off-by: Fangrui Song <i@maskray.me>
>> ---
>> migration/migration.c | 4 ++--
>> util/cutils.c | 4 ++--
>> 2 files changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/migration/migration.c b/migration/migration.c
>> index 354ad072fa..ac3ea2934a 100644
>> --- a/migration/migration.c
>> +++ b/migration/migration.c
>> @@ -53,6 +53,7 @@
>> #include "monitor/monitor.h"
>> #include "net/announce.h"
>> #include "qemu/queue.h"
>> +#include <math.h>
>>
>> #define MAX_THROTTLE (32 << 20) /* Migration transfer speed throttling */
>>
>> @@ -2035,11 +2036,10 @@ void qmp_migrate_set_downtime(double value, Error **errp)
> if (value < 0 || value > MAX_MIGRATE_DOWNTIME_SECONDS) {
> error_setg(errp, "Parameter 'downtime_limit' expects an integer in "
> "the range of 0 to %d seconds",
> MAX_MIGRATE_DOWNTIME_SECONDS);
> return;
>> }
>
> @value is now in [0,2000].
>
>>
>> value *= 1000; /* Convert to milliseconds */
>
> @value is in [0,2000000]
>
>> - value = MAX(0, MIN(INT64_MAX, value));
>
> This does nothing.
>
>>
>> MigrateSetParameters p = {
>> .has_downtime_limit = true,
>> - .downtime_limit = value,
>> + .downtime_limit = (int64_t)fmin(value, nextafter(0x1p63, 0)),
>
> This does nothing and is hard to read :)
>
> Can we simply drop the offending line statement instead?
Agreed aboutdropping the whole bussines for migration.
>> };
>>
>> qmp_migrate_set_parameters(&p, errp);
>> diff --git a/util/cutils.c b/util/cutils.c
>> index fd591cadf0..2b4484c015 100644
>> --- a/util/cutils.c
>> +++ b/util/cutils.c
>> @@ -239,10 +239,10 @@ static int do_strtosz(const char *nptr, const char **end,
>> goto out;
>> }
>> /*
>> - * Values >= 0xfffffffffffffc00 overflow uint64_t after their trip
>> + * Values > nextafter(0x1p64, 0) overflow uint64_t after their trip
>> * through double (53 bits of precision).
>> */
>> - if ((val * mul >= 0xfffffffffffffc00) || val < 0) {
>> + if ((val * mul > nextafter(0x1p64, 0)) || val < 0) {
>> retval = -ERANGE;
>> goto out;
>> }
This comment was really bad (it says the same that the code).
On the other hand, I can *kind of* understand what does 0xffff<more
f's here>.
But I am at a complete loss about what value is:
nextafter(0x1p64, 0).
Can we put what value is that instead?
Thanks, Juan.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] Fix incorrect int->float conversions caught by clang -Wimplicit-int-float-conversion
2019-11-20 11:15 ` Juan Quintela
@ 2019-11-20 17:30 ` Fangrui Song
2019-11-21 12:18 ` Richard Henderson
0 siblings, 1 reply; 11+ messages in thread
From: Fangrui Song @ 2019-11-20 17:30 UTC (permalink / raw)
To: Juan Quintela; +Cc: Markus Armbruster, Dr. David Alan Gilbert, qemu-devel
On 2019-11-20, Juan Quintela wrote:
>Markus Armbruster <armbru@redhat.com> wrote:
>> Fangrui Song <i@maskray.me> writes:
>>
>>> The warning will be enabled by default in clang 10. It is not
>>> available for clang <= 9.
>>>
>>> qemu/migration/migration.c:2038:24: error: implicit conversion from
>>> 'long' to 'double' changes value from 9223372036854775807 to
>>> 9223372036854775808 [-Werror,-Wimplicit-int-float-conversion]
>>> ...
>>> qemu/util/cutils.c:245:23: error: implicit conversion from 'unsigned
>>> long' to 'double' changes value from 18446744073709550592 to
>>> 18446744073709551616 [-Werror,-Wimplicit-int-float-conversion]
>>>
>>> Signed-off-by: Fangrui Song <i@maskray.me>
>>> ---
>>> migration/migration.c | 4 ++--
>>> util/cutils.c | 4 ++--
>>> 2 files changed, 4 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/migration/migration.c b/migration/migration.c
>>> index 354ad072fa..ac3ea2934a 100644
>>> --- a/migration/migration.c
>>> +++ b/migration/migration.c
>>> @@ -53,6 +53,7 @@
>>> #include "monitor/monitor.h"
>>> #include "net/announce.h"
>>> #include "qemu/queue.h"
>>> +#include <math.h>
>>>
>>> #define MAX_THROTTLE (32 << 20) /* Migration transfer speed throttling */
>>>
>>> @@ -2035,11 +2036,10 @@ void qmp_migrate_set_downtime(double value, Error **errp)
>> if (value < 0 || value > MAX_MIGRATE_DOWNTIME_SECONDS) {
>> error_setg(errp, "Parameter 'downtime_limit' expects an integer in "
>> "the range of 0 to %d seconds",
>> MAX_MIGRATE_DOWNTIME_SECONDS);
>> return;
>>> }
>>
>> @value is now in [0,2000].
>>
>>>
>>> value *= 1000; /* Convert to milliseconds */
>>
>> @value is in [0,2000000]
>>
>>> - value = MAX(0, MIN(INT64_MAX, value));
>>
>> This does nothing.
>>
>>>
>>> MigrateSetParameters p = {
>>> .has_downtime_limit = true,
>>> - .downtime_limit = value,
>>> + .downtime_limit = (int64_t)fmin(value, nextafter(0x1p63, 0)),
>>
>> This does nothing and is hard to read :)
>>
>> Can we simply drop the offending line statement instead?
>
>Agreed aboutdropping the whole bussines for migration.
>
>
>>> };
>>>
>>> qmp_migrate_set_parameters(&p, errp);
>>> diff --git a/util/cutils.c b/util/cutils.c
>>> index fd591cadf0..2b4484c015 100644
>>> --- a/util/cutils.c
>>> +++ b/util/cutils.c
>>> @@ -239,10 +239,10 @@ static int do_strtosz(const char *nptr, const char **end,
>>> goto out;
>>> }
>>> /*
>>> - * Values >= 0xfffffffffffffc00 overflow uint64_t after their trip
>>> + * Values > nextafter(0x1p64, 0) overflow uint64_t after their trip
>>> * through double (53 bits of precision).
>>> */
>>> - if ((val * mul >= 0xfffffffffffffc00) || val < 0) {
>>> + if ((val * mul > nextafter(0x1p64, 0)) || val < 0) {
>>> retval = -ERANGE;
>>> goto out;
>>> }
>
>This comment was really bad (it says the same that the code).
>On the other hand, I can *kind of* understand what does 0xffff<more
>f's here>.
>
>But I am at a complete loss about what value is:
>
>nextafter(0x1p64, 0).
>
>Can we put what value is that instead?
It is a C99 hexadecimal floating-point literal.
0x1p64 represents hex fraction 1.0 scaled by 2**64, that is 2**64.
We can write this as `val * mul > 0xfffffffffffff800p0`, but I feel that
counting the number of f's is error-prone and is not fun.
(We cannot use val * mul >= 0x1p64.
If FLT_EVAL_METHOD == 2, the intermediate computation val * mul will be
performed at long double precision, val * mul may not by representable
by a double and will overflow as (double)0x1p64.)
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] Fix incorrect int->float conversions caught by clang -Wimplicit-int-float-conversion
2019-11-20 17:30 ` Fangrui Song
@ 2019-11-21 12:18 ` Richard Henderson
2019-11-21 14:51 ` Markus Armbruster
0 siblings, 1 reply; 11+ messages in thread
From: Richard Henderson @ 2019-11-21 12:18 UTC (permalink / raw)
To: Fangrui Song, Juan Quintela
Cc: qemu-devel, Markus Armbruster, Dr. David Alan Gilbert
On 11/20/19 6:30 PM, Fangrui Song wrote:
> On 2019-11-20, Juan Quintela wrote:
>> Markus Armbruster <armbru@redhat.com> wrote:
>>> Fangrui Song <i@maskray.me> writes:
>>>
>>>> The warning will be enabled by default in clang 10. It is not
>>>> available for clang <= 9.
>>>>
>>>> qemu/migration/migration.c:2038:24: error: implicit conversion from
>>>> 'long' to 'double' changes value from 9223372036854775807 to
>>>> 9223372036854775808 [-Werror,-Wimplicit-int-float-conversion]
>>>> ...
>>>> qemu/util/cutils.c:245:23: error: implicit conversion from 'unsigned
>>>> long' to 'double' changes value from 18446744073709550592 to
>>>> 18446744073709551616 [-Werror,-Wimplicit-int-float-conversion]
>>>>
>>>> Signed-off-by: Fangrui Song <i@maskray.me>
>>>> ---
>>>> migration/migration.c | 4 ++--
>>>> util/cutils.c | 4 ++--
>>>> 2 files changed, 4 insertions(+), 4 deletions(-)
>>>>
>>>> diff --git a/migration/migration.c b/migration/migration.c
>>>> index 354ad072fa..ac3ea2934a 100644
>>>> --- a/migration/migration.c
>>>> +++ b/migration/migration.c
>>>> @@ -53,6 +53,7 @@
>>>> #include "monitor/monitor.h"
>>>> #include "net/announce.h"
>>>> #include "qemu/queue.h"
>>>> +#include <math.h>
>>>>
>>>> #define MAX_THROTTLE (32 << 20) /* Migration transfer speed
>>>> throttling */
>>>>
>>>> @@ -2035,11 +2036,10 @@ void qmp_migrate_set_downtime(double value, Error
>>>> **errp)
>>> if (value < 0 || value > MAX_MIGRATE_DOWNTIME_SECONDS) {
>>> error_setg(errp, "Parameter 'downtime_limit' expects an integer
>>> in "
>>> "the range of 0 to %d seconds",
>>> MAX_MIGRATE_DOWNTIME_SECONDS);
>>> return;
>>>> }
>>>
>>> @value is now in [0,2000].
>>>
>>>>
>>>> value *= 1000; /* Convert to milliseconds */
>>>
>>> @value is in [0,2000000]
>>>
>>>> - value = MAX(0, MIN(INT64_MAX, value));
>>>
>>> This does nothing.
>>>
>>>>
>>>> MigrateSetParameters p = {
>>>> .has_downtime_limit = true,
>>>> - .downtime_limit = value,
>>>> + .downtime_limit = (int64_t)fmin(value, nextafter(0x1p63, 0)),
>>>
>>> This does nothing and is hard to read :)
>>>
>>> Can we simply drop the offending line statement instead?
>>
>> Agreed aboutdropping the whole bussines for migration.
>>
>>
>>>> };
>>>>
>>>> qmp_migrate_set_parameters(&p, errp);
>>>> diff --git a/util/cutils.c b/util/cutils.c
>>>> index fd591cadf0..2b4484c015 100644
>>>> --- a/util/cutils.c
>>>> +++ b/util/cutils.c
>>>> @@ -239,10 +239,10 @@ static int do_strtosz(const char *nptr, const char
>>>> **end,
>>>> goto out;
>>>> }
>>>> /*
>>>> - * Values >= 0xfffffffffffffc00 overflow uint64_t after their trip
>>>> + * Values > nextafter(0x1p64, 0) overflow uint64_t after their trip
>>>> * through double (53 bits of precision).
>>>> */
>>>> - if ((val * mul >= 0xfffffffffffffc00) || val < 0) {
>>>> + if ((val * mul > nextafter(0x1p64, 0)) || val < 0) {
>>>> retval = -ERANGE;
>>>> goto out;
>>>> }
>>
>> This comment was really bad (it says the same that the code).
>> On the other hand, I can *kind of* understand what does 0xffff<more
>> f's here>.
>>
>> But I am at a complete loss about what value is:
>>
>> nextafter(0x1p64, 0).
>>
>> Can we put what value is that instead?
>
> It is a C99 hexadecimal floating-point literal.
> 0x1p64 represents hex fraction 1.0 scaled by 2**64, that is 2**64.
>
> We can write this as `val * mul > 0xfffffffffffff800p0`, but I feel that
> counting the number of f's is error-prone and is not fun.
>
> (We cannot use val * mul >= 0x1p64.
> If FLT_EVAL_METHOD == 2, the intermediate computation val * mul will be
> performed at long double precision, val * mul may not by representable
> by a double and will overflow as (double)0x1p64.)
I agree about not spelling out the f's, or the 0x800 at the end. That's
something that the compiler can do for us, resolving this standard library
function at compile-time.
We just need a better comment. Perhaps:
/*
* Values near UINT64_MAX overflow to 2**64 when converting
* to double precision. Compare against the maximum representable
* double precision value below 2**64, computed as "the next value
* after 2**64 (0x1p64) in the direction of 0".
*/
r~
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] Fix incorrect int->float conversions caught by clang -Wimplicit-int-float-conversion
2019-11-21 12:18 ` Richard Henderson
@ 2019-11-21 14:51 ` Markus Armbruster
2019-11-21 17:11 ` Fangrui Song
0 siblings, 1 reply; 11+ messages in thread
From: Markus Armbruster @ 2019-11-21 14:51 UTC (permalink / raw)
To: Richard Henderson
Cc: Fangrui Song, qemu-devel, Dr. David Alan Gilbert, Juan Quintela
Richard Henderson <richard.henderson@linaro.org> writes:
> On 11/20/19 6:30 PM, Fangrui Song wrote:
>> On 2019-11-20, Juan Quintela wrote:
>>> Markus Armbruster <armbru@redhat.com> wrote:
>>>> Fangrui Song <i@maskray.me> writes:
[...]
>>>>> diff --git a/util/cutils.c b/util/cutils.c
>>>>> index fd591cadf0..2b4484c015 100644
>>>>> --- a/util/cutils.c
>>>>> +++ b/util/cutils.c
>>>>> @@ -239,10 +239,10 @@ static int do_strtosz(const char *nptr, const char
>>>>> **end,
>>>>> goto out;
>>>>> }
>>>>> /*
>>>>> - * Values >= 0xfffffffffffffc00 overflow uint64_t after their trip
>>>>> + * Values > nextafter(0x1p64, 0) overflow uint64_t after their trip
>>>>> * through double (53 bits of precision).
>>>>> */
>>>>> - if ((val * mul >= 0xfffffffffffffc00) || val < 0) {
>>>>> + if ((val * mul > nextafter(0x1p64, 0)) || val < 0) {
>>>>> retval = -ERANGE;
>>>>> goto out;
>>>>> }
>>>
>>> This comment was really bad (it says the same that the code).
>>> On the other hand, I can *kind of* understand what does 0xffff<more
>>> f's here>.
>>>
>>> But I am at a complete loss about what value is:
>>>
>>> nextafter(0x1p64, 0).
>>>
>>> Can we put what value is that instead?
>>
>> It is a C99 hexadecimal floating-point literal.
>> 0x1p64 represents hex fraction 1.0 scaled by 2**64, that is 2**64.
>>
>> We can write this as `val * mul > 0xfffffffffffff800p0`, but I feel that
>> counting the number of f's is error-prone and is not fun.
>>
>> (We cannot use val * mul >= 0x1p64.
>> If FLT_EVAL_METHOD == 2, the intermediate computation val * mul will be
>> performed at long double precision, val * mul may not by representable
>> by a double and will overflow as (double)0x1p64.)
>
> I agree about not spelling out the f's, or the 0x800 at the end. That's
> something that the compiler can do for us, resolving this standard library
> function at compile-time.
>
> We just need a better comment. Perhaps:
>
> /*
> * Values near UINT64_MAX overflow to 2**64 when converting
> * to double precision. Compare against the maximum representable
> * double precision value below 2**64, computed as "the next value
> * after 2**64 (0x1p64) in the direction of 0".
> */
Yes, please.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] Fix incorrect int->float conversions caught by clang -Wimplicit-int-float-conversion
2019-11-21 14:51 ` Markus Armbruster
@ 2019-11-21 17:11 ` Fangrui Song
0 siblings, 0 replies; 11+ messages in thread
From: Fangrui Song @ 2019-11-21 17:11 UTC (permalink / raw)
To: Markus Armbruster, Richard Henderson
Cc: qemu-devel, Dr. David Alan Gilbert, Juan Quintela
[-- Attachment #1: Type: text/plain, Size: 2432 bytes --]
On 2019-11-21, Markus Armbruster wrote:
>Richard Henderson <richard.henderson@linaro.org> writes:
>
>> On 11/20/19 6:30 PM, Fangrui Song wrote:
>>> On 2019-11-20, Juan Quintela wrote:
>>>> Markus Armbruster <armbru@redhat.com> wrote:
>>>>> Fangrui Song <i@maskray.me> writes:
>[...]
>>>>>> diff --git a/util/cutils.c b/util/cutils.c
>>>>>> index fd591cadf0..2b4484c015 100644
>>>>>> --- a/util/cutils.c
>>>>>> +++ b/util/cutils.c
>>>>>> @@ -239,10 +239,10 @@ static int do_strtosz(const char *nptr, const char
>>>>>> **end,
>>>>>> goto out;
>>>>>> }
>>>>>> /*
>>>>>> - * Values >= 0xfffffffffffffc00 overflow uint64_t after their trip
>>>>>> + * Values > nextafter(0x1p64, 0) overflow uint64_t after their trip
>>>>>> * through double (53 bits of precision).
>>>>>> */
>>>>>> - if ((val * mul >= 0xfffffffffffffc00) || val < 0) {
>>>>>> + if ((val * mul > nextafter(0x1p64, 0)) || val < 0) {
>>>>>> retval = -ERANGE;
>>>>>> goto out;
>>>>>> }
>>>>
>>>> This comment was really bad (it says the same that the code).
>>>> On the other hand, I can *kind of* understand what does 0xffff<more
>>>> f's here>.
>>>>
>>>> But I am at a complete loss about what value is:
>>>>
>>>> nextafter(0x1p64, 0).
>>>>
>>>> Can we put what value is that instead?
>>>
>>> It is a C99 hexadecimal floating-point literal.
>>> 0x1p64 represents hex fraction 1.0 scaled by 2**64, that is 2**64.
>>>
>>> We can write this as `val * mul > 0xfffffffffffff800p0`, but I feel that
>>> counting the number of f's is error-prone and is not fun.
>>>
>>> (We cannot use val * mul >= 0x1p64.
>>> If FLT_EVAL_METHOD == 2, the intermediate computation val * mul will be
>>> performed at long double precision, val * mul may not by representable
>>> by a double and will overflow as (double)0x1p64.)
>>
>> I agree about not spelling out the f's, or the 0x800 at the end. That's
>> something that the compiler can do for us, resolving this standard library
>> function at compile-time.
>>
>> We just need a better comment. Perhaps:
>>
>> /*
>> * Values near UINT64_MAX overflow to 2**64 when converting
>> * to double precision. Compare against the maximum representable
>> * double precision value below 2**64, computed as "the next value
>> * after 2**64 (0x1p64) in the direction of 0".
>> */
>
>Yes, please.
Thanks for the suggestion. Attached a new patch.
[-- Attachment #2: qemu.patch --]
[-- Type: text/x-diff, Size: 2258 bytes --]
From 13312e91e5565a6bed8c394d5711603c7a8f8a3c Mon Sep 17 00:00:00 2001
From: Fangrui Song <i@maskray.me>
Date: Fri, 15 Nov 2019 16:27:47 -0800
Subject: [PATCH] Fix incorrect integer->float conversion caught by clang -Wimplicit-int-float-conversion
To: qemu-devel@nongnu.org
The warning will be enabled by default in clang 10. It is not available for clang <= 9.
qemu/migration/migration.c:2038:24: error: implicit conversion from 'long' to 'double' changes value from 9223372036854775807 to 9223372036854775808 [-Werror,-Wimplicit-int-float-conversion]
...
qemu/util/cutils.c:245:23: error: implicit conversion from 'unsigned long' to 'double' changes value from 18446744073709550592 to 18446744073709551616 [-Werror,-Wimplicit-int-float-conversion]
Signed-off-by: Fangrui Song <i@maskray.me>
---
migration/migration.c | 3 +--
util/cutils.c | 8 +++++---
2 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/migration/migration.c b/migration/migration.c
index 354ad072fa..09b150663f 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -2035,11 +2035,10 @@ void qmp_migrate_set_downtime(double value, Error **errp)
}
value *= 1000; /* Convert to milliseconds */
- value = MAX(0, MIN(INT64_MAX, value));
MigrateSetParameters p = {
.has_downtime_limit = true,
- .downtime_limit = value,
+ .downtime_limit = (int64_t)value,
};
qmp_migrate_set_parameters(&p, errp);
diff --git a/util/cutils.c b/util/cutils.c
index fd591cadf0..77acadc70a 100644
--- a/util/cutils.c
+++ b/util/cutils.c
@@ -239,10 +239,12 @@ static int do_strtosz(const char *nptr, const char **end,
goto out;
}
/*
- * Values >= 0xfffffffffffffc00 overflow uint64_t after their trip
- * through double (53 bits of precision).
+ * Values near UINT64_MAX overflow to 2**64 when converting to double
+ * precision. Compare against the maximum representable double precision
+ * value below 2**64, computed as "the next value after 2**64 (0x1p64) in
+ * the direction of 0".
*/
- if ((val * mul >= 0xfffffffffffffc00) || val < 0) {
+ if ((val * mul > nextafter(0x1p64, 0)) || val < 0) {
retval = -ERANGE;
goto out;
}
--
2.24.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH] Fix incorrect int->float conversions caught by clang -Wimplicit-int-float-conversion
2019-11-19 20:49 ` Fangrui Song
@ 2019-11-21 17:38 ` Eric Blake
2019-11-22 0:00 ` [PATCH v2] Fix incorrect integer->float " Fangrui Song
0 siblings, 1 reply; 11+ messages in thread
From: Eric Blake @ 2019-11-21 17:38 UTC (permalink / raw)
To: Fangrui Song, Markus Armbruster
Cc: Juan Quintela, qemu-devel, Dr. David Alan Gilbert
On 11/19/19 2:49 PM, Fangrui Song wrote:
>>
>> Can we simply drop the offending line statement instead?
>
> Fixed in the new patch.
>
>> The first val * mul above this range is 0x1p64. Rejecting it is
>> correct, because it overflows yint64_t.
>
> I am not subscribed, so apologize that this email may be off the thread.
>
> (The binutils mailing list allows a user to download the raw email so I
> can still reply to a specific email, but this list does not provide such
> feature.)
Actually, it's better to post a v2 patch as a new top-level thread,
rather than buried as an attachment to a reply to v1, because our CI
tooling doesn't see through the attachment (nor was it easy for me to
reply to the v2 patch - I had to open the attachment to paste its text
inline below...).
More patch submission hints at https://wiki.qemu.org/Contribute/SubmitAPatch
>>From 5f1c5a42794ddcbabb63d9af920d9f437ea90a9f Mon Sep 17 00:00:00 2001
> From: Fangrui Song <i@maskray.me>
> Date: Fri, 15 Nov 2019 16:27:47 -0800
> Subject: [PATCH] Fix incorrect integer->float conversions caught by clang
> -Wimplicit-int-float-conversion
> To: qemu-devel@nongnu.org
>
> The warning will be enabled by default in clang 10. It is not available for clang <= 9.
>
> +++ b/migration/migration.c
> @@ -2035,11 +2035,10 @@ void qmp_migrate_set_downtime(double value, Error **errp)
> }
>
> value *= 1000; /* Convert to milliseconds */
> - value = MAX(0, MIN(INT64_MAX, value));
>
> MigrateSetParameters p = {
> .has_downtime_limit = true,
> - .downtime_limit = value,
> + .downtime_limit = (int64_t)value,
> };
The explicit cast looks odd without a comment (generally, we try to
avoid casts, so a comment such as /* explicit cast to silence compiler
*/ can be useful)
>
> qmp_migrate_set_parameters(&p, errp);
> diff --git a/util/cutils.c b/util/cutils.c
> index fd591cadf0..2b4484c015 100644
> --- a/util/cutils.c
> +++ b/util/cutils.c
> @@ -239,10 +239,10 @@ static int do_strtosz(const char *nptr, const char **end,
> goto out;
> }
> /*
> - * Values >= 0xfffffffffffffc00 overflow uint64_t after their trip
> + * Values > nextafter(0x1p64, 0) overflow uint64_t after their trip
> * through double (53 bits of precision).
I thought we agreed on more text than just this (in particular, that the
nextafter() call represents 2^64 rounded towards zero).
> */
> - if ((val * mul >= 0xfffffffffffffc00) || val < 0) {
> + if ((val * mul > nextafter(0x1p64, 0)) || val < 0) {
> retval = -ERANGE;
> goto out;
> }
> --
> 2.24.0
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v2] Fix incorrect integer->float conversions caught by clang -Wimplicit-int-float-conversion
2019-11-21 17:38 ` Eric Blake
@ 2019-11-22 0:00 ` Fangrui Song
2019-11-22 8:06 ` Markus Armbruster
0 siblings, 1 reply; 11+ messages in thread
From: Fangrui Song @ 2019-11-22 0:00 UTC (permalink / raw)
To: Eric Blake
Cc: Juan Quintela, Markus Armbruster, Dr. David Alan Gilbert, qemu-devel
[-- Attachment #1: Type: text/plain, Size: 3237 bytes --]
On 2019-11-21, Eric Blake wrote:
>On 11/19/19 2:49 PM, Fangrui Song wrote:
>
>>>
>>>Can we simply drop the offending line statement instead?
>>
>>Fixed in the new patch.
>>
>
>>>The first val * mul above this range is 0x1p64. Rejecting it is
>>>correct, because it overflows yint64_t.
>>
>>I am not subscribed, so apologize that this email may be off the thread.
>>
>>(The binutils mailing list allows a user to download the raw email so I
>>can still reply to a specific email, but this list does not provide such
>>feature.)
>
>Actually, it's better to post a v2 patch as a new top-level thread,
>rather than buried as an attachment to a reply to v1, because our CI
>tooling doesn't see through the attachment (nor was it easy for me to
>reply to the v2 patch - I had to open the attachment to paste its text
>inline below...).
>
>More patch submission hints at https://wiki.qemu.org/Contribute/SubmitAPatch
Retitled to [PATCH v2]
>>>From 5f1c5a42794ddcbabb63d9af920d9f437ea90a9f Mon Sep 17 00:00:00 2001
>>From: Fangrui Song <i@maskray.me>
>>Date: Fri, 15 Nov 2019 16:27:47 -0800
>>Subject: [PATCH] Fix incorrect integer->float conversions caught by clang
>> -Wimplicit-int-float-conversion
>>To: qemu-devel@nongnu.org
>>
>>The warning will be enabled by default in clang 10. It is not available for clang <= 9.
>>
>
>>+++ b/migration/migration.c
>>@@ -2035,11 +2035,10 @@ void qmp_migrate_set_downtime(double value, Error **errp)
>> }
>> value *= 1000; /* Convert to milliseconds */
>>- value = MAX(0, MIN(INT64_MAX, value));
>> MigrateSetParameters p = {
>> .has_downtime_limit = true,
>>- .downtime_limit = value,
>>+ .downtime_limit = (int64_t)value,
>> };
>
>The explicit cast looks odd without a comment (generally, we try to
>avoid casts, so a comment such as /* explicit cast to silence compiler
>*/ can be useful)
>
downtime_limit is an int64_t while value is a double.
There is a diagnostic (-Wfloat-conversion, included by -Wconversion)
warning: conversion from ‘double’ to ‘int64_t’ {aka ‘long int’} may change value [-Wfloat-conversion]
but it is not enabled by -Wall or -Wextra.
I am not familiar with qemu coding style, but I strongly feel it is a good
thing to add an explicit cast. If it does not fit the style, I hope a
maintainer can delete that for me.
>> qmp_migrate_set_parameters(&p, errp);
>>diff --git a/util/cutils.c b/util/cutils.c
>>index fd591cadf0..2b4484c015 100644
>>--- a/util/cutils.c
>>+++ b/util/cutils.c
>>@@ -239,10 +239,10 @@ static int do_strtosz(const char *nptr, const char **end,
>> goto out;
>> }
>> /*
>>- * Values >= 0xfffffffffffffc00 overflow uint64_t after their trip
>>+ * Values > nextafter(0x1p64, 0) overflow uint64_t after their trip
>> * through double (53 bits of precision).
>
>I thought we agreed on more text than just this (in particular, that
>the nextafter() call represents 2^64 rounded towards zero).
>
>> */
>>- if ((val * mul >= 0xfffffffffffffc00) || val < 0) {
>>+ if ((val * mul > nextafter(0x1p64, 0)) || val < 0) {
>> retval = -ERANGE;
>> goto out;
>> }
Sorry, I uploaded the wrong patch file. Attaching the correct one now.
[-- Attachment #2: qemu.patch --]
[-- Type: text/x-diff, Size: 2259 bytes --]
From d533585df39083e88adc50b881a4be74125c837e Mon Sep 17 00:00:00 2001
From: Fangrui Song <i@maskray.me>
Date: Fri, 15 Nov 2019 16:27:47 -0800
Subject: [PATCH] Fix incorrect integer->float conversion caught by clang
-Wimplicit-int-float-conversion
To: qemu-devel@nongnu.org
The warning will be enabled by default in clang 10. It is not available for clang <= 9.
qemu/migration/migration.c:2038:24: error: implicit conversion from 'long' to 'double' changes value from 9223372036854775807 to 9223372036854775808 [-Werror,-Wimplicit-int-float-conversion]
...
qemu/util/cutils.c:245:23: error: implicit conversion from 'unsigned long' to 'double' changes value from 18446744073709550592 to 18446744073709551616 [-Werror,-Wimplicit-int-float-conversion]
Signed-off-by: Fangrui Song <i@maskray.me>
---
migration/migration.c | 3 +--
util/cutils.c | 8 +++++---
2 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/migration/migration.c b/migration/migration.c
index 354ad072fa..09b150663f 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -2035,11 +2035,10 @@ void qmp_migrate_set_downtime(double value, Error **errp)
}
value *= 1000; /* Convert to milliseconds */
- value = MAX(0, MIN(INT64_MAX, value));
MigrateSetParameters p = {
.has_downtime_limit = true,
- .downtime_limit = value,
+ .downtime_limit = (int64_t)value,
};
qmp_migrate_set_parameters(&p, errp);
diff --git a/util/cutils.c b/util/cutils.c
index fd591cadf0..77acadc70a 100644
--- a/util/cutils.c
+++ b/util/cutils.c
@@ -239,10 +239,12 @@ static int do_strtosz(const char *nptr, const char **end,
goto out;
}
/*
- * Values >= 0xfffffffffffffc00 overflow uint64_t after their trip
- * through double (53 bits of precision).
+ * Values near UINT64_MAX overflow to 2**64 when converting to double
+ * precision. Compare against the maximum representable double precision
+ * value below 2**64, computed as "the next value after 2**64 (0x1p64) in
+ * the direction of 0".
*/
- if ((val * mul >= 0xfffffffffffffc00) || val < 0) {
+ if ((val * mul > nextafter(0x1p64, 0)) || val < 0) {
retval = -ERANGE;
goto out;
}
--
2.24.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH v2] Fix incorrect integer->float conversions caught by clang -Wimplicit-int-float-conversion
2019-11-22 0:00 ` [PATCH v2] Fix incorrect integer->float " Fangrui Song
@ 2019-11-22 8:06 ` Markus Armbruster
0 siblings, 0 replies; 11+ messages in thread
From: Markus Armbruster @ 2019-11-22 8:06 UTC (permalink / raw)
To: Fangrui Song; +Cc: qemu-devel, Dr. David Alan Gilbert, Juan Quintela
Fangrui Song <i@maskray.me> writes:
> On 2019-11-21, Eric Blake wrote:
>>On 11/19/19 2:49 PM, Fangrui Song wrote:
>>
>>>>
>>>>Can we simply drop the offending line statement instead?
>>>
>>>Fixed in the new patch.
>>>
>>
>>>>The first val * mul above this range is 0x1p64. Rejecting it is
>>>>correct, because it overflows yint64_t.
>>>
>>>I am not subscribed, so apologize that this email may be off the thread.
>>>
>>>(The binutils mailing list allows a user to download the raw email so I
>>>can still reply to a specific email, but this list does not provide such
>>>feature.)
There's <https://lists.gnu.org/archive/mbox/qemu-devel/>.
>> Actually, it's better to post a v2 patch as a new top-level thread,
>> rather than buried as an attachment to a reply to v1, because our CI
>> tooling doesn't see through the attachment (nor was it easy for me
>> to reply to the v2 patch - I had to open the attachment to paste its
>> text inline below...).
>>
>>More patch submission hints at https://wiki.qemu.org/Contribute/SubmitAPatch
>
> Retitled to [PATCH v2]
Good, such versioning is essential to avoid confusion. Next time, start
a new top-level thread for v2. Our patch submission processing
(automated as well as human) expects that.
I just did it for you: "[PATCH v3 0/2] Fix incorrect integer->float
conversion caught by clang".
Many thanks for your fixes!
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2019-11-22 8:09 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-16 1:07 [PATCH] Fix incorrect int->float conversions caught by clang -Wimplicit-int-float-conversion Fangrui Song
2019-11-19 15:14 ` Markus Armbruster
2019-11-20 11:15 ` Juan Quintela
2019-11-20 17:30 ` Fangrui Song
2019-11-21 12:18 ` Richard Henderson
2019-11-21 14:51 ` Markus Armbruster
2019-11-21 17:11 ` Fangrui Song
2019-11-19 20:49 ` Fangrui Song
2019-11-21 17:38 ` Eric Blake
2019-11-22 0:00 ` [PATCH v2] Fix incorrect integer->float " Fangrui Song
2019-11-22 8:06 ` Markus Armbruster
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).