* [PATCH] docs: fix qemu incorrect tag
@ 2021-11-05 13:01 huangy81
2021-11-05 13:26 ` Philippe Mathieu-Daudé
2021-11-06 11:33 ` Juan Quintela
0 siblings, 2 replies; 3+ messages in thread
From: huangy81 @ 2021-11-05 13:01 UTC (permalink / raw)
To: qemu-devel
Cc: Philippe Mathieu-Daudé,
Eric Blake, Hyman Huang(黄勇),
Juan Quintela
From: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
The last modification of the patchset may be 2 month before
merging dirtyrate implementation, it used the wrong tag, so
fix with 6.2.
Signed-off-by: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
---
qapi/migration.json | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/qapi/migration.json b/qapi/migration.json
index 87146ce..f0aefda 100644
--- a/qapi/migration.json
+++ b/qapi/migration.json
@@ -1740,7 +1740,7 @@
#
# @dirty-rate: dirty rate.
#
-# Since: 6.1
+# Since: 6.2
#
##
{ 'struct': 'DirtyRateVcpu',
@@ -1774,7 +1774,7 @@
#
# @dirty-bitmap: calculate dirtyrate by dirty bitmap.
#
-# Since: 6.1
+# Since: 6.2
#
##
{ 'enum': 'DirtyRateMeasureMode',
@@ -1796,13 +1796,13 @@
# @calc-time: time in units of second for sample dirty pages
#
# @sample-pages: page count per GB for sample dirty pages
-# the default value is 512 (since 6.1)
+# the default value is 512 (since 6.2)
#
# @mode: mode containing method of calculate dirtyrate includes
-# 'page-sampling' and 'dirty-ring' (Since 6.1)
+# 'page-sampling' and 'dirty-ring' (Since 6.2)
#
# @vcpu-dirty-rate: dirtyrate for each vcpu if dirty-ring
-# mode specified (Since 6.1)
+# mode specified (Since 6.2)
#
# Since: 5.2
#
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] docs: fix qemu incorrect tag
2021-11-05 13:01 [PATCH] docs: fix qemu incorrect tag huangy81
@ 2021-11-05 13:26 ` Philippe Mathieu-Daudé
2021-11-06 11:33 ` Juan Quintela
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-11-05 13:26 UTC (permalink / raw)
To: huangy81, qemu-devel, QEMU Trivial; +Cc: Eric Blake, Juan Quintela
Cc'ing qemu-trivial@
On 11/5/21 14:01, huangy81@chinatelecom.cn wrote:
> From: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
>
> The last modification of the patchset may be 2 month before
> merging dirtyrate implementation, it used the wrong tag, so
> fix with 6.2.
Maybe:
The patchset merged in 71864eadd9a ("migration/dirtyrate:
introduce struct and adjust DirtyRateStat") was targeting
QEMU 6.1 but got merged later, so correct the tag for 6.2.
Anyhow,
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Signed-off-by: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
> ---
> qapi/migration.json | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/qapi/migration.json b/qapi/migration.json
> index 87146ce..f0aefda 100644
> --- a/qapi/migration.json
> +++ b/qapi/migration.json
> @@ -1740,7 +1740,7 @@
> #
> # @dirty-rate: dirty rate.
> #
> -# Since: 6.1
> +# Since: 6.2
> #
> ##
> { 'struct': 'DirtyRateVcpu',
> @@ -1774,7 +1774,7 @@
> #
> # @dirty-bitmap: calculate dirtyrate by dirty bitmap.
> #
> -# Since: 6.1
> +# Since: 6.2
> #
> ##
> { 'enum': 'DirtyRateMeasureMode',
> @@ -1796,13 +1796,13 @@
> # @calc-time: time in units of second for sample dirty pages
> #
> # @sample-pages: page count per GB for sample dirty pages
> -# the default value is 512 (since 6.1)
> +# the default value is 512 (since 6.2)
> #
> # @mode: mode containing method of calculate dirtyrate includes
> -# 'page-sampling' and 'dirty-ring' (Since 6.1)
> +# 'page-sampling' and 'dirty-ring' (Since 6.2)
> #
> # @vcpu-dirty-rate: dirtyrate for each vcpu if dirty-ring
> -# mode specified (Since 6.1)
> +# mode specified (Since 6.2)
> #
> # Since: 5.2
> #
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] docs: fix qemu incorrect tag
2021-11-05 13:01 [PATCH] docs: fix qemu incorrect tag huangy81
2021-11-05 13:26 ` Philippe Mathieu-Daudé
@ 2021-11-06 11:33 ` Juan Quintela
1 sibling, 0 replies; 3+ messages in thread
From: Juan Quintela @ 2021-11-06 11:33 UTC (permalink / raw)
To: huangy81; +Cc: Philippe Mathieu-Daudé, Eric Blake, qemu-devel
huangy81@chinatelecom.cn wrote:
> From: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
>
> The last modification of the patchset may be 2 month before
> merging dirtyrate implementation, it used the wrong tag, so
> fix with 6.2.
>
> Signed-off-by: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
Reviewed-by: Juan Quintela <quintela@redhat.com>
queued.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-11-06 11:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-05 13:01 [PATCH] docs: fix qemu incorrect tag huangy81
2021-11-05 13:26 ` Philippe Mathieu-Daudé
2021-11-06 11:33 ` Juan Quintela
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).