From: Bin Meng <bmeng.cn@gmail.com>
To: Laurent Vivier <laurent@vivier.eu>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"QEMU Trivial" <qemu-trivial@nongnu.org>,
"Stefan Weil" <sw@weilnetz.de>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
"Alistair Francis" <alistair23@gmail.com>
Subject: Re: [PATCH] nsis: Install *.elf images
Date: Wed, 7 Apr 2021 20:13:49 +0800 [thread overview]
Message-ID: <CAEUhbmX9+=6+J1a0vyzTCWXfrQqjf205W0S=+UZCaxVz+URXRA@mail.gmail.com> (raw)
In-Reply-To: <cc5220ec-f694-3302-92c4-0107fd5af500@vivier.eu>
Hi Stefan,
On Wed, Apr 7, 2021 at 8:06 PM Laurent Vivier <laurent@vivier.eu> wrote:
>
> Le 06/04/2021 à 11:28, Stefan Weil a écrit :
> > Am 06.04.21 um 11:04 schrieb Bin Meng:
> >
> >> On Fri, Mar 26, 2021 at 2:22 PM Bin Meng <bmeng.cn@gmail.com> wrote:
> >>> As of today, the QEMU Windows installer does not include the
> >>> following two RISC-V BIOS images:
> >>>
> >>> - opensbi-riscv64-generic-fw_dynamic.elf
> >>> - opensbi-riscv32-generic-fw_dynamic.elf
> >>>
> >>> Update the installer script to include them.
> >>>
> >>> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> >>>
> >>> ---
> >>> Based on:
> >>> https://repo.or.cz/qemu/ar7.git/commit/657a6a90b69da971afdc71501c30275ba307ff6c
> >>>
> >>> The above commit does not land on QEMU master. I am not sure what
> >>> the process is, sending it here for comments.
> >>>
> >>> qemu.nsi | 2 ++
> >>> 1 file changed, 2 insertions(+)
> >> Ping?
> >
> >
> > Reviewed-by: Stefan Weil <sw@weilnetz.de>
> >
> > This is a small uncritical fix which can be merged via QEMU trivial.
>
> If it is merged via QEMU trivial, it will be after the 6.0 release.
> If it's needed for 6.0 it's better to go via the maintainer tree (W32,W64) [1]
I think this should go in 6.0.
But as I mentioned that the patch is based on
https://repo.or.cz/qemu/ar7.git/commit/657a6a90b69da971afdc71501c30275ba307ff6c
which is not in the QEMU mainline yet.
Is QEMU Windows installer fork (https://repo.or.cz/qemu/ar7.git/) not
supposed to merge back to QEMU mainline?
Regards,
Bin
prev parent reply other threads:[~2021-04-07 12:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-26 6:21 [PATCH] nsis: Install *.elf images Bin Meng
2021-03-26 18:40 ` Philippe Mathieu-Daudé
2021-03-30 16:15 ` Alistair Francis
2021-04-06 9:04 ` Bin Meng
2021-04-06 9:28 ` Stefan Weil
2021-04-07 12:06 ` Laurent Vivier
2021-04-07 12:13 ` Bin Meng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEUhbmX9+=6+J1a0vyzTCWXfrQqjf205W0S=+UZCaxVz+URXRA@mail.gmail.com' \
--to=bmeng.cn@gmail.com \
--cc=alistair23@gmail.com \
--cc=f4bug@amsat.org \
--cc=laurent@vivier.eu \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).