From: Laurent Vivier <laurent@vivier.eu>
To: "Stefan Weil" <sw@weilnetz.de>, "Bin Meng" <bmeng.cn@gmail.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
"QEMU Trivial" <qemu-trivial@nongnu.org>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Alistair Francis" <alistair23@gmail.com>
Subject: Re: [PATCH] nsis: Install *.elf images
Date: Wed, 7 Apr 2021 14:06:19 +0200 [thread overview]
Message-ID: <cc5220ec-f694-3302-92c4-0107fd5af500@vivier.eu> (raw)
In-Reply-To: <ce9214bb-d68b-defe-8af1-84373727b396@weilnetz.de>
Le 06/04/2021 à 11:28, Stefan Weil a écrit :
> Am 06.04.21 um 11:04 schrieb Bin Meng:
>
>> On Fri, Mar 26, 2021 at 2:22 PM Bin Meng <bmeng.cn@gmail.com> wrote:
>>> As of today, the QEMU Windows installer does not include the
>>> following two RISC-V BIOS images:
>>>
>>> - opensbi-riscv64-generic-fw_dynamic.elf
>>> - opensbi-riscv32-generic-fw_dynamic.elf
>>>
>>> Update the installer script to include them.
>>>
>>> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
>>>
>>> ---
>>> Based on:
>>> https://repo.or.cz/qemu/ar7.git/commit/657a6a90b69da971afdc71501c30275ba307ff6c
>>>
>>> The above commit does not land on QEMU master. I am not sure what
>>> the process is, sending it here for comments.
>>>
>>> qemu.nsi | 2 ++
>>> 1 file changed, 2 insertions(+)
>> Ping?
>
>
> Reviewed-by: Stefan Weil <sw@weilnetz.de>
>
> This is a small uncritical fix which can be merged via QEMU trivial.
If it is merged via QEMU trivial, it will be after the 6.0 release.
If it's needed for 6.0 it's better to go via the maintainer tree (W32,W64) [1]
Thanks,
Laurent
[1] the reason is: even a trivial change can break something, I don't like to break QEMU during RC
phase, so going via the maintainer tree helps to have tests more relevant to the area that is modified.
next prev parent reply other threads:[~2021-04-07 12:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-26 6:21 [PATCH] nsis: Install *.elf images Bin Meng
2021-03-26 18:40 ` Philippe Mathieu-Daudé
2021-03-30 16:15 ` Alistair Francis
2021-04-06 9:04 ` Bin Meng
2021-04-06 9:28 ` Stefan Weil
2021-04-07 12:06 ` Laurent Vivier [this message]
2021-04-07 12:13 ` Bin Meng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc5220ec-f694-3302-92c4-0107fd5af500@vivier.eu \
--to=laurent@vivier.eu \
--cc=alistair23@gmail.com \
--cc=bmeng.cn@gmail.com \
--cc=f4bug@amsat.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).