From: Peter Maydell <peter.maydell@linaro.org>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Corey Minyard <cminyard@mvista.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Shannon Zhao <shannon.zhaosl@gmail.com>,
qemu-arm <qemu-arm@nongnu.org>,
Igor Mammedov <imammedo@redhat.com>,
Heyi Guo <guoheyi@huawei.com>,
wanghaibin.wang@huawei.com
Subject: Re: [PATCH 2/2] arm/virt/acpi: remove _ADR from devices identified by _HID
Date: Mon, 6 Jan 2020 15:51:57 +0000 [thread overview]
Message-ID: <CAFEAcA-sduqVO3rrG2V1VsysE2chgd0SnSySvEXFfue-aZN8dg@mail.gmail.com> (raw)
In-Reply-To: <20200105072504-mutt-send-email-mst@kernel.org>
On Sun, 5 Jan 2020 at 12:34, Michael S. Tsirkin <mst@redhat.com> wrote:
>
> On Thu, Dec 19, 2019 at 02:47:59PM +0800, Heyi Guo wrote:
> > hw/arm/virt-acpi-build.c | 8 --------
> > tests/data/acpi/virt/DSDT | Bin 18449 -> 18426 bytes
> > tests/data/acpi/virt/DSDT.memhp | Bin 19786 -> 19763 bytes
> > tests/data/acpi/virt/DSDT.numamem | Bin 18449 -> 18426 bytes
> > 4 files changed, 8 deletions(-)
> Please do not include binary changes in acpi patches.
>
> See comment at the top of tests/bios-tables-test.c for documentation
> on how to update these.
If you want the patches not to include binary changes then
you will need to take these yourself through your own tree.
As the Arm subtree maintainer I am not going to follow a
specific process for acpi related patches that requires me
to do anything other than "apply patches from email, test
them, send pull request". I also have no way to
identify whether any differences that I might see if I
disassembled the ACPI tables make sense, as that comment
suggests I should be doing. The differences in the tables need
to be checked by the people reviewing the patches, which will
not be me for anything ACPI related -- I just don't know
enough about the ACPI specs.
Patches should be self contained, including updating test
cases as required. The underlying problem here is that
the 'golden master' data for the acpi tests is a pile
of binary blobs rather than something that's human
readable and reviewable as part of a patch.
thanks
-- PMM
next prev parent reply other threads:[~2020-01-06 15:53 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-19 6:47 [PATCH 0/2] Some cleanup in arm/virt/acpi Heyi Guo
2019-12-19 6:47 ` [PATCH 1/2] arm/virt/acpi: remove meaningless sub device "PR0" from PCI0 Heyi Guo
2020-01-13 12:37 ` Igor Mammedov
2020-01-16 12:36 ` Guoheyi
2020-01-21 3:48 ` Guoheyi
2020-01-21 6:35 ` Michael S. Tsirkin
2020-01-22 5:39 ` Michael S. Tsirkin
2020-01-22 6:38 ` Guoheyi
2019-12-19 6:47 ` [PATCH 2/2] arm/virt/acpi: remove _ADR from devices identified by _HID Heyi Guo
2020-01-05 12:33 ` Michael S. Tsirkin
2020-01-05 12:53 ` Michael S. Tsirkin
2020-01-06 2:10 ` Guoheyi
2020-01-13 8:46 ` Guoheyi
2020-01-16 11:56 ` Guoheyi
2020-01-16 13:25 ` Igor Mammedov
2020-01-17 1:54 ` Guoheyi
2020-01-05 22:54 ` Corey Minyard
2020-01-06 9:39 ` Michael S. Tsirkin
2020-01-06 13:07 ` Corey Minyard
2020-01-06 15:51 ` Peter Maydell [this message]
2020-01-15 2:03 ` Guoheyi
2020-01-15 6:30 ` Michael S. Tsirkin
2020-01-15 9:25 ` Guoheyi
2020-01-15 10:53 ` Michael S. Tsirkin
2020-01-15 10:55 ` Michael S. Tsirkin
2020-01-16 12:24 ` Peter Maydell
2020-01-17 2:08 ` Guoheyi
2020-01-13 12:08 ` Igor Mammedov
2020-01-13 13:57 ` Guoheyi
2020-01-13 15:26 ` Andrew Jones
2020-01-15 1:25 ` Guoheyi
2020-01-15 12:08 ` Igor Mammedov
2019-12-19 12:34 ` [PATCH 0/2] Some cleanup in arm/virt/acpi Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA-sduqVO3rrG2V1VsysE2chgd0SnSySvEXFfue-aZN8dg@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=cminyard@mvista.com \
--cc=guoheyi@huawei.com \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=shannon.zhaosl@gmail.com \
--cc=wanghaibin.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).