* [PATCH] hw/arm/strongarm: Fix 'time to transmit a char' unit comment
@ 2020-10-14 21:36 Philippe Mathieu-Daudé
2020-10-19 15:23 ` Peter Maydell
0 siblings, 1 reply; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-10-14 21:36 UTC (permalink / raw)
To: qemu-devel
Cc: qemu-trivial, Peter Maydell, qemu-arm, Philippe Mathieu-Daudé
The time to transmit a char is expressed in nanoseconds, not in ticks.
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
hw/arm/strongarm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/arm/strongarm.c b/hw/arm/strongarm.c
index d7133eea6f9..ca7c385f313 100644
--- a/hw/arm/strongarm.c
+++ b/hw/arm/strongarm.c
@@ -935,7 +935,7 @@ struct StrongARMUARTState {
uint8_t rx_start;
uint8_t rx_len;
- uint64_t char_transmit_time; /* time to transmit a char in ticks*/
+ uint64_t char_transmit_time; /* time to transmit a char in nanoseconds */
bool wait_break_end;
QEMUTimer *rx_timeout_timer;
QEMUTimer *tx_timer;
--
2.26.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] hw/arm/strongarm: Fix 'time to transmit a char' unit comment
2020-10-14 21:36 [PATCH] hw/arm/strongarm: Fix 'time to transmit a char' unit comment Philippe Mathieu-Daudé
@ 2020-10-19 15:23 ` Peter Maydell
0 siblings, 0 replies; 2+ messages in thread
From: Peter Maydell @ 2020-10-19 15:23 UTC (permalink / raw)
To: Philippe Mathieu-Daudé; +Cc: QEMU Trivial, qemu-arm, QEMU Developers
On Wed, 14 Oct 2020 at 22:36, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> The time to transmit a char is expressed in nanoseconds, not in ticks.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> hw/arm/strongarm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/arm/strongarm.c b/hw/arm/strongarm.c
> index d7133eea6f9..ca7c385f313 100644
> --- a/hw/arm/strongarm.c
> +++ b/hw/arm/strongarm.c
> @@ -935,7 +935,7 @@ struct StrongARMUARTState {
> uint8_t rx_start;
> uint8_t rx_len;
>
> - uint64_t char_transmit_time; /* time to transmit a char in ticks*/
> + uint64_t char_transmit_time; /* time to transmit a char in nanoseconds */
> bool wait_break_end;
> QEMUTimer *rx_timeout_timer;
> QEMUTimer *tx_timer;
Applied to target-arm.next, thanks.
-- PMM
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-19 15:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-14 21:36 [PATCH] hw/arm/strongarm: Fix 'time to transmit a char' unit comment Philippe Mathieu-Daudé
2020-10-19 15:23 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).