From: Peter Maydell <peter.maydell@linaro.org>
To: Michael Rolnik <mrolnik@gmail.com>
Cc: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"QEMU Developers" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v27 8/8] target/avr: Add tests
Date: Mon, 22 Jul 2019 13:40:26 +0100 [thread overview]
Message-ID: <CAFEAcA_duMOwnWd+941zLDVEAMTWgz=Ojo5FSfSiLCxUnOZXdA@mail.gmail.com> (raw)
In-Reply-To: <CAK4993i6uGJahzxRFGHyBqSzNrfb3Q=kUbQkjcLmTQSVem63dA@mail.gmail.com>
On Mon, 22 Jul 2019 at 13:33, Michael Rolnik <mrolnik@gmail.com> wrote:
> I changed it to info_report.
> raw binaries are totally fine, however if a user supplies a damaged elf he
> will never know if no warning/info is reported.
I find a good rule of thumb for architecture specific/board specific
code is that if other boards/architectures don't do a particular thing,
it's usually better to be consistent with the rest of QEMU, rather
than introducing an innovation.
"Try to load as an ELF file; if that didn't work fall back
to loading as a raw image" is what other parts of QEMU do,
and they don't complain about doing it. Otherwise, every
user of raw images gets a spurious complaint that their
raw image isn't an ELF file...
thanks
-- PMM
next prev parent reply other threads:[~2019-07-22 12:40 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-19 8:26 [Qemu-devel] [PATCH v27 0/8] QEMU AVR 8 bit cores Michael Rolnik
2019-07-19 8:26 ` [Qemu-devel] [PATCH v27 1/8] target/avr: Add outward facing interfaces and core CPU logic Michael Rolnik
2019-07-19 8:26 ` [Qemu-devel] [PATCH v27 2/8] target/avr: Add instruction helpers Michael Rolnik
2019-07-19 8:26 ` [Qemu-devel] [PATCH v27 3/8] target/avr: Add instruction decoding Michael Rolnik
2019-07-19 8:26 ` [Qemu-devel] [PATCH v27 4/8] target/avr: Add instruction translation Michael Rolnik
2019-07-19 8:26 ` [Qemu-devel] [PATCH v27 5/8] target/avr: Add limited support for USART and 16 bit timer peripherals Michael Rolnik
2019-07-25 10:00 ` Pavel Dovgalyuk
2019-07-25 17:52 ` Michael Rolnik
2019-07-26 14:53 ` Sarah Harris
2019-12-05 10:27 ` Aleksandar Markovic
2019-12-05 10:33 ` Aleksandar Markovic
2019-12-05 11:13 ` Aleksandar Markovic
2019-12-06 11:32 ` Pavel Dovgalyuk
2019-07-19 8:26 ` [Qemu-devel] [PATCH v27 6/8] target/avr: Add example board configuration Michael Rolnik
2019-07-19 14:02 ` Philippe Mathieu-Daudé
2019-07-19 15:04 ` Michael Rolnik
2019-07-19 15:14 ` Michael Rolnik
2019-07-19 15:29 ` Philippe Mathieu-Daudé
2019-07-19 8:26 ` [Qemu-devel] [PATCH v27 7/8] target/avr: Register AVR support with the rest of QEMU, the build system, and the MAINTAINERS file Michael Rolnik
2019-07-19 15:43 ` Eric Blake
2019-07-19 16:04 ` Michael Rolnik
2019-07-19 8:26 ` [Qemu-devel] [PATCH v27 8/8] target/avr: Add tests Michael Rolnik
2019-07-19 13:26 ` Philippe Mathieu-Daudé
2019-07-19 15:05 ` Michael Rolnik
2019-07-21 7:13 ` Thomas Huth
2019-07-22 9:16 ` Michael Rolnik
2019-07-22 9:41 ` Thomas Huth
2019-07-22 12:33 ` Michael Rolnik
2019-07-22 12:40 ` Peter Maydell [this message]
2019-07-22 13:45 ` Michael Rolnik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA_duMOwnWd+941zLDVEAMTWgz=Ojo5FSfSiLCxUnOZXdA@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=mrolnik@gmail.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).