From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Michael Rolnik" <mrolnik@gmail.com>,
qemu-devel@nongnu.org
Cc: richard.henderson@linaro.org
Subject: Re: [Qemu-devel] [PATCH v27 8/8] target/avr: Add tests
Date: Sun, 21 Jul 2019 09:13:45 +0200 [thread overview]
Message-ID: <aa9f5be1-3451-7f58-a868-bd31bf2af236@redhat.com> (raw)
In-Reply-To: <da64fd46-c0f0-b6b6-3b8f-d3da9041605d@redhat.com>
On 19/07/2019 15.26, Philippe Mathieu-Daudé wrote:
> On 7/19/19 10:26 AM, Michael Rolnik wrote:
[...]
>> diff --git a/tests/boot-serial-test.c b/tests/boot-serial-test.c
>> index 24852d4c7d..73d273b73f 100644
>> --- a/tests/boot-serial-test.c
>> +++ b/tests/boot-serial-test.c
>> @@ -16,6 +16,17 @@
>> #include "qemu/osdep.h"
>> #include "libqtest.h"
>>
>> +static const uint8_t bios_avr[] = {
>> + 0x89, 0xe1, /* ldi r24, 0x19 */
>> + 0x80, 0x93, 0xc5, 0x00, /* sts 0x00C5, r24 ; set baud rate to 38400 */
>
> FWIW we can remove the previous two lines, we don't care about the
> baudrate in this test.
>
>> + 0x88, 0xe0, /* ldi r24, 0x08 */
>> + 0x80, 0x93, 0xc1, 0x00, /* sts 0x00C1, r24 ; Enable tx */
>> + 0x86, 0xe0, /* ldi r24, 0x06 */
>> + 0x80, 0x93, 0xc2, 0x00, /* sts 0x00C2, r24 ; Set the data bits to 8 */
>> + 0x84, 0xe5, /* ldi r24, 0x54 */
>> + 0x80, 0x93, 0xc6, 0x00, /* sts 0x00C6, r24 ; Output 'T' */
>> +};
>> +
>> static const uint8_t kernel_mcf5208[] = {
>> 0x41, 0xf9, 0xfc, 0x06, 0x00, 0x00, /* lea 0xfc060000,%a0 */
>> 0x10, 0x3c, 0x00, 0x54, /* move.b #'T',%d0 */
>> @@ -92,6 +103,7 @@ typedef struct testdef {
>>
>> static testdef_t tests[] = {
>> { "alpha", "clipper", "", "PCI:" },
>> + { "avr", "sample", "", "T", sizeof(bios_avr), NULL, bios_avr },
>> { "ppc", "ppce500", "", "U-Boot" },
>> { "ppc", "40p", "-vga none -boot d", "Trying cd:," },
>> { "ppc", "g3beige", "", "PowerPC,750" },
>>
>
> Testing shows:
>
> TEST check-qtest-avr: tests/boot-serial-test
> qemu-system-avr: Unable to load /tmp/qtest-boot-serial-cOndewD as ELF,
> trying again as raw binary
>
> I wonder if this might fail Peter's testing, so Cc'ing Thomas.
Such messages are quite a bit anoying during "make check", indeed. Could
you please fence the message with qtest_enabled() ?
Thanks,
Thomas
next prev parent reply other threads:[~2019-07-21 7:14 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-19 8:26 [Qemu-devel] [PATCH v27 0/8] QEMU AVR 8 bit cores Michael Rolnik
2019-07-19 8:26 ` [Qemu-devel] [PATCH v27 1/8] target/avr: Add outward facing interfaces and core CPU logic Michael Rolnik
2019-07-19 8:26 ` [Qemu-devel] [PATCH v27 2/8] target/avr: Add instruction helpers Michael Rolnik
2019-07-19 8:26 ` [Qemu-devel] [PATCH v27 3/8] target/avr: Add instruction decoding Michael Rolnik
2019-07-19 8:26 ` [Qemu-devel] [PATCH v27 4/8] target/avr: Add instruction translation Michael Rolnik
2019-07-19 8:26 ` [Qemu-devel] [PATCH v27 5/8] target/avr: Add limited support for USART and 16 bit timer peripherals Michael Rolnik
2019-07-25 10:00 ` Pavel Dovgalyuk
2019-07-25 17:52 ` Michael Rolnik
2019-07-26 14:53 ` Sarah Harris
2019-12-05 10:27 ` Aleksandar Markovic
2019-12-05 10:33 ` Aleksandar Markovic
2019-12-05 11:13 ` Aleksandar Markovic
2019-12-06 11:32 ` Pavel Dovgalyuk
2019-07-19 8:26 ` [Qemu-devel] [PATCH v27 6/8] target/avr: Add example board configuration Michael Rolnik
2019-07-19 14:02 ` Philippe Mathieu-Daudé
2019-07-19 15:04 ` Michael Rolnik
2019-07-19 15:14 ` Michael Rolnik
2019-07-19 15:29 ` Philippe Mathieu-Daudé
2019-07-19 8:26 ` [Qemu-devel] [PATCH v27 7/8] target/avr: Register AVR support with the rest of QEMU, the build system, and the MAINTAINERS file Michael Rolnik
2019-07-19 15:43 ` Eric Blake
2019-07-19 16:04 ` Michael Rolnik
2019-07-19 8:26 ` [Qemu-devel] [PATCH v27 8/8] target/avr: Add tests Michael Rolnik
2019-07-19 13:26 ` Philippe Mathieu-Daudé
2019-07-19 15:05 ` Michael Rolnik
2019-07-21 7:13 ` Thomas Huth [this message]
2019-07-22 9:16 ` Michael Rolnik
2019-07-22 9:41 ` Thomas Huth
2019-07-22 12:33 ` Michael Rolnik
2019-07-22 12:40 ` Peter Maydell
2019-07-22 13:45 ` Michael Rolnik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa9f5be1-3451-7f58-a868-bd31bf2af236@redhat.com \
--to=thuth@redhat.com \
--cc=mrolnik@gmail.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).