Re: [Qemu-devel] [PATCH v27 8/8] target/avr: Add tests

[Michael Rolnik <mrolnik@gmail.com>]

I changed it to info_report.
raw binaries are totally fine, however if a user supplies a damaged elf he
will never know if no warning/info is reported.

On Mon, Jul 22, 2019 at 12:41 PM Thomas Huth <thuth@redhat.com> wrote:

>  Hi Michael,
>
> On 22/07/2019 11.16, Michael Rolnik wrote:
> > Hi Thomas.
> > where should I specify this command?
>
> In patch 6/8, you introduced the error message:
>
>         if (bytes_loaded < 0) {
>             error_report(
>                 "Unable to load %s as ELF, trying again as raw binary",
>                 firmware);
>             bytes_loaded = load_image_targphys(
>                 filename, OFFSET_CODE, SIZE_FLASH);
>         }
>
> You should fence it there like this:
>
>         if (bytes_loaded < 0) {
>             if (!qtest_enabled()) {
>                 error_report(
>                     "Unable to load %s as ELF, trying again as raw binary",
>                     firmware);
>             }
>             bytes_loaded = load_image_targphys(
>                 filename, OFFSET_CODE, SIZE_FLASH);
>         }
>
> Also, is this really an error, or should this rather be a warn_report()
> instead? Or maybe you don't even need this message at all, in case raw
> binaries are a valid alternative?
>
>   Thomas
>
>
> > On Sun, Jul 21, 2019 at 10:13 AM Thomas Huth <thuth@redhat.com
> > <mailto:thuth@redhat.com>> wrote:
> >
> >     On 19/07/2019 15.26, Philippe Mathieu-Daudé wrote:
> >     > On 7/19/19 10:26 AM, Michael Rolnik wrote:
> [...]
> >     > Testing shows:
> >     >
> >     >   TEST    check-qtest-avr: tests/boot-serial-test
> >     > qemu-system-avr: Unable to load /tmp/qtest-boot-serial-cOndewD as
> ELF,
> >     > trying again as raw binary
> >     >
> >     > I wonder if this might fail Peter's testing, so Cc'ing Thomas.
> >
> >     Such messages are quite a bit anoying during "make check", indeed.
> Could
> >     you please fence the message with qtest_enabled() ?
> >
> >      Thanks,
> >        Thomas
> >
> >
> >
> > --
> > Best Regards,
> > Michael Rolnik
>
>

-- 
Best Regards,
Michael Rolnik